tree: https://gitee.com/openeuler/kernel.git OLK-5.10 head: d5c6fe9611048ed35ceab6a450d2d8a801e946a6 commit: 16a9f8e683ea65ac4484e67742171cfa8b0234eb [12306/30000] hugetlbfs: fix a truncation issue in hugepages parameter :::::: branch date: 8 hours ago :::::: commit date: 1 year, 9 months ago config: x86_64-randconfig-161-20240129 (attached as .config) compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202401300555.biTw6IGs-lkp@intel.com/ smatch warnings: mm/hugetlb.c:3611 hugepages_setup() warn: potential spectre issue 'default_hugepages_in_node' [w] mm/hugetlb.c:3613 hugepages_setup() warn: potential spectre issue 'parsed_hstate->max_huge_pages_node' [w] vim +/default_hugepages_in_node +3611 mm/hugetlb.c a3437870160cf2 Nishanth Aravamudan 2008-07-23 3550 f4ada01a2c72a1 Zhenguo Yao 2022-01-17 3551 bool __init __weak hugetlb_node_alloc_supported(void) f4ada01a2c72a1 Zhenguo Yao 2022-01-17 3552 { f4ada01a2c72a1 Zhenguo Yao 2022-01-17 3553 return true; f4ada01a2c72a1 Zhenguo Yao 2022-01-17 3554 } 282f4214384ee2 Mike Kravetz 2020-06-03 3555 /* 282f4214384ee2 Mike Kravetz 2020-06-03 3556 * hugepages command line processing 282f4214384ee2 Mike Kravetz 2020-06-03 3557 * hugepages normally follows a valid hugepagsz or default_hugepagsz 282f4214384ee2 Mike Kravetz 2020-06-03 3558 * specification. If not, ignore the hugepages value. hugepages can also 282f4214384ee2 Mike Kravetz 2020-06-03 3559 * be the first huge page command line option in which case it implicitly 282f4214384ee2 Mike Kravetz 2020-06-03 3560 * specifies the number of huge pages for the default size. 282f4214384ee2 Mike Kravetz 2020-06-03 3561 */ 282f4214384ee2 Mike Kravetz 2020-06-03 3562 static int __init hugepages_setup(char *s) a3437870160cf2 Nishanth Aravamudan 2008-07-23 3563 { a3437870160cf2 Nishanth Aravamudan 2008-07-23 3564 unsigned long *mhp; 8faa8b077b2cdc Andi Kleen 2008-07-23 3565 static unsigned long *last_mhp; f4ada01a2c72a1 Zhenguo Yao 2022-01-17 3566 int node = NUMA_NO_NODE; f4ada01a2c72a1 Zhenguo Yao 2022-01-17 3567 int count; f4ada01a2c72a1 Zhenguo Yao 2022-01-17 3568 unsigned long tmp; f4ada01a2c72a1 Zhenguo Yao 2022-01-17 3569 char *p = s; a3437870160cf2 Nishanth Aravamudan 2008-07-23 3570 9fee021d15ddd8 Vaishali Thakkar 2016-05-19 3571 if (!parsed_valid_hugepagesz) { 282f4214384ee2 Mike Kravetz 2020-06-03 3572 pr_warn("HugeTLB: hugepages=%s does not follow a valid hugepagesz, ignoring\n", s); 9fee021d15ddd8 Vaishali Thakkar 2016-05-19 3573 parsed_valid_hugepagesz = true; 282f4214384ee2 Mike Kravetz 2020-06-03 3574 return 0; 9fee021d15ddd8 Vaishali Thakkar 2016-05-19 3575 } 282f4214384ee2 Mike Kravetz 2020-06-03 3576 a3437870160cf2 Nishanth Aravamudan 2008-07-23 3577 /* 282f4214384ee2 Mike Kravetz 2020-06-03 3578 * !hugetlb_max_hstate means we haven't parsed a hugepagesz= parameter 282f4214384ee2 Mike Kravetz 2020-06-03 3579 * yet, so this hugepages= parameter goes to the "default hstate". 282f4214384ee2 Mike Kravetz 2020-06-03 3580 * Otherwise, it goes with the previously parsed hugepagesz or 282f4214384ee2 Mike Kravetz 2020-06-03 3581 * default_hugepagesz. a3437870160cf2 Nishanth Aravamudan 2008-07-23 3582 */ 9fee021d15ddd8 Vaishali Thakkar 2016-05-19 3583 else if (!hugetlb_max_hstate) a3437870160cf2 Nishanth Aravamudan 2008-07-23 3584 mhp = &default_hstate_max_huge_pages; a3437870160cf2 Nishanth Aravamudan 2008-07-23 3585 else a3437870160cf2 Nishanth Aravamudan 2008-07-23 3586 mhp = &parsed_hstate->max_huge_pages; a3437870160cf2 Nishanth Aravamudan 2008-07-23 3587 8faa8b077b2cdc Andi Kleen 2008-07-23 3588 if (mhp == last_mhp) { 282f4214384ee2 Mike Kravetz 2020-06-03 3589 pr_warn("HugeTLB: hugepages= specified twice without interleaving hugepagesz=, ignoring hugepages=%s\n", s); 282f4214384ee2 Mike Kravetz 2020-06-03 3590 return 0; 8faa8b077b2cdc Andi Kleen 2008-07-23 3591 } 8faa8b077b2cdc Andi Kleen 2008-07-23 3592 f4ada01a2c72a1 Zhenguo Yao 2022-01-17 3593 while (*p) { f4ada01a2c72a1 Zhenguo Yao 2022-01-17 3594 count = 0; f4ada01a2c72a1 Zhenguo Yao 2022-01-17 3595 if (sscanf(p, "%lu%n", &tmp, &count) != 1) f4ada01a2c72a1 Zhenguo Yao 2022-01-17 3596 goto invalid; f4ada01a2c72a1 Zhenguo Yao 2022-01-17 3597 /* Parameter is node format */ f4ada01a2c72a1 Zhenguo Yao 2022-01-17 3598 if (p[count] == ':') { f4ada01a2c72a1 Zhenguo Yao 2022-01-17 3599 if (!hugetlb_node_alloc_supported()) { f4ada01a2c72a1 Zhenguo Yao 2022-01-17 3600 pr_warn("HugeTLB: architecture can't support node specific alloc, ignoring!\n"); f4ada01a2c72a1 Zhenguo Yao 2022-01-17 3601 return 0; f4ada01a2c72a1 Zhenguo Yao 2022-01-17 3602 } 16a9f8e683ea65 Liu Yuntao 2022-04-19 3603 if (tmp >= nr_online_nodes) 16a9f8e683ea65 Liu Yuntao 2022-04-19 3604 goto invalid; f4ada01a2c72a1 Zhenguo Yao 2022-01-17 3605 node = tmp; f4ada01a2c72a1 Zhenguo Yao 2022-01-17 3606 p += count + 1; f4ada01a2c72a1 Zhenguo Yao 2022-01-17 3607 /* Parse hugepages */ f4ada01a2c72a1 Zhenguo Yao 2022-01-17 3608 if (sscanf(p, "%lu%n", &tmp, &count) != 1) f4ada01a2c72a1 Zhenguo Yao 2022-01-17 3609 goto invalid; f4ada01a2c72a1 Zhenguo Yao 2022-01-17 3610 if (!hugetlb_max_hstate) f4ada01a2c72a1 Zhenguo Yao 2022-01-17 @3611 default_hugepages_in_node[node] = tmp; f4ada01a2c72a1 Zhenguo Yao 2022-01-17 3612 else f4ada01a2c72a1 Zhenguo Yao 2022-01-17 @3613 parsed_hstate->max_huge_pages_node[node] = tmp; f4ada01a2c72a1 Zhenguo Yao 2022-01-17 3614 *mhp += tmp; f4ada01a2c72a1 Zhenguo Yao 2022-01-17 3615 /* Go to parse next node*/ f4ada01a2c72a1 Zhenguo Yao 2022-01-17 3616 if (p[count] == ',') f4ada01a2c72a1 Zhenguo Yao 2022-01-17 3617 p += count + 1; f4ada01a2c72a1 Zhenguo Yao 2022-01-17 3618 else f4ada01a2c72a1 Zhenguo Yao 2022-01-17 3619 break; f4ada01a2c72a1 Zhenguo Yao 2022-01-17 3620 } else { f4ada01a2c72a1 Zhenguo Yao 2022-01-17 3621 if (p != s) f4ada01a2c72a1 Zhenguo Yao 2022-01-17 3622 goto invalid; f4ada01a2c72a1 Zhenguo Yao 2022-01-17 3623 *mhp = tmp; f4ada01a2c72a1 Zhenguo Yao 2022-01-17 3624 break; f4ada01a2c72a1 Zhenguo Yao 2022-01-17 3625 } f4ada01a2c72a1 Zhenguo Yao 2022-01-17 3626 } a3437870160cf2 Nishanth Aravamudan 2008-07-23 3627 8faa8b077b2cdc Andi Kleen 2008-07-23 3628 /* 8faa8b077b2cdc Andi Kleen 2008-07-23 3629 * Global state is always initialized later in hugetlb_init. 8faa8b077b2cdc Andi Kleen 2008-07-23 3630 * But we need to allocate >= MAX_ORDER hstates here early to still 8faa8b077b2cdc Andi Kleen 2008-07-23 3631 * use the bootmem allocator. 8faa8b077b2cdc Andi Kleen 2008-07-23 3632 */ 47d38344abd0c7 Aneesh Kumar K.V 2012-07-31 3633 if (hugetlb_max_hstate && parsed_hstate->order >= MAX_ORDER) 8faa8b077b2cdc Andi Kleen 2008-07-23 3634 hugetlb_hstate_alloc_pages(parsed_hstate); 8faa8b077b2cdc Andi Kleen 2008-07-23 3635 8faa8b077b2cdc Andi Kleen 2008-07-23 3636 last_mhp = mhp; 8faa8b077b2cdc Andi Kleen 2008-07-23 3637 a3437870160cf2 Nishanth Aravamudan 2008-07-23 3638 return 1; f4ada01a2c72a1 Zhenguo Yao 2022-01-17 3639 f4ada01a2c72a1 Zhenguo Yao 2022-01-17 3640 invalid: f4ada01a2c72a1 Zhenguo Yao 2022-01-17 3641 pr_warn("HugeTLB: Invalid hugepages parameter %s\n", p); f4ada01a2c72a1 Zhenguo Yao 2022-01-17 3642 return 0; a3437870160cf2 Nishanth Aravamudan 2008-07-23 3643 } 282f4214384ee2 Mike Kravetz 2020-06-03 3644 __setup("hugepages=", hugepages_setup); e11bfbfcb08ef4 Nick Piggin 2008-07-23 3645 :::::: The code at line 3611 was first introduced by commit :::::: f4ada01a2c72a1a69a6da3c56764b414081e639b hugetlbfs: extend the definition of hugepages parameter to support node allocation :::::: TO: Zhenguo Yao <yaozhenguo1@gmail.com> :::::: CC: Zheng Zengkai <zhengzengkai@huawei.com> -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki