checkpatch.pl: minor improvements. Jeff Layton (1): checkpatch.pl: adapt to new Assisted-by: format Tengda Wu (1): checkpatch: recognize Co-authored-by as a valid signature tag scripts/checkpatch.pl | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) -- 2.34.1
From: Jeff Layton <jlayton@kernel.org> mainline inclusion from mainline-v7.3-rc1 commit 2a8d68338ee77e200895f2697c56fd00094767f7 category: other bugzilla: https://atomgit.com/openeuler/kernel/issues/10261 Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/patch/?id... -------------------------------- There is a new format for the 'Assisted-by:' tag. Change checkpatch.pl to just check that it has a value rather than testing for a specific format. Assisted-by: LLM Signed-off-by: Jeff Layton <jlayton@kernel.org> Signed-off-by: Jonathan Corbet <corbet@lwn.net> Message-ID: <20260804-checkpatch-v1-1-27f29c79a46f@kernel.org> Signed-off-by: Tengda Wu <wutengda2@huawei.com> --- scripts/checkpatch.pl | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 61382510d497..eb7d1dbe73d7 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2790,11 +2790,12 @@ sub process { } } - # Assisted-by uses AGENT_NAME:MODEL_VERSION format, not email + # Assisted-by uses a free-form value (e.g. "LLM"), not an + # email address, so skip the email format checks below. if ($sign_off =~ /^Assisted-by:/i) { - if ($email !~ /^\S+:\S+/) { + if ($email =~ /^\s*$/) { WARN("BAD_SIGN_OFF", - "Assisted-by expects 'AGENT_NAME:MODEL_VERSION [TOOL1] [TOOL2]' format\n" . $herecurr); + "Assisted-by requires a value\n" . $herecurr); } next; } -- 2.34.1
hulk inclusion category: other bugzilla: https://atomgit.com/openeuler/kernel/issues/10261 -------------------------------- With the rise of agent-generated patches, Co-authored-by: is increasingly used to credit the large language model that contributed to the change. checkpatch currently treats this tag as a non-standard signature and emits a BAD_SIGN_OFF warning. Add Co-authored-by: to the signature_tags list so that the tag is recognized and the false-positive warning is suppressed. Signed-off-by: Tengda Wu <wutengda2@huawei.com> --- scripts/checkpatch.pl | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index eb7d1dbe73d7..e091a80e94a7 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -503,6 +503,7 @@ our $signature_tags = qr{(?xi: Reported-by:| Suggested-by:| Assisted-by:| + Co-authored-by:| To:| Cc: )}; -- 2.34.1
反馈: 您发送到kernel@openeuler.org的补丁/补丁集,已成功转换为PR! PR链接地址: https://atomgit.com/openeuler/kernel/merge_requests/30714 邮件列表地址:https://mailweb.openeuler.org/archives/list/kernel@openeuler.org/message/TBU... FeedBack: The patch(es) which you have sent to kernel@openeuler.org mailing list has been converted to a pull request successfully! Pull request link: https://atomgit.com/openeuler/kernel/merge_requests/30714 Mailing list address: https://mailweb.openeuler.org/archives/list/kernel@openeuler.org/message/TBU...
participants (2)
-
patchwork bot -
Tengda Wu