[openeuler:OLK-6.6 13/13] drivers/ub/ubus/cap.c:12:6: warning: no previous prototype for 'ub_set_cap_bitmap'

26 Dec 2025

      tree:   https://gitee.com/openeuler/kernel.git OLK-6.6
head:   03c9c649e6f28e26260d276ce755f785b2435da3
commit: c21b483526d766fd97d491f3951433f69fde3ac3 [13/13] ub:ubus: Add UBUS capability interfaces
config: arm64-randconfig-004-20251226 (https://download.01.org/0day-ci/archive/20251226/202512261449.EGuzfA3r-lkp@i...)
compiler: aarch64-linux-gcc (GCC) 13.4.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251226/202512261449.EGuzfA3r-lkp@i...)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202512261449.EGuzfA3r-lkp@intel.com/

All warnings (new ones prefixed by >>):
...
...
drivers/ub/ubus/cap.c:12:6: warning: no previous prototype for 'ub_set_cap_bitmap' [-Wmissing-prototypes]
      12 | void ub_set_cap_bitmap(struct ub_entity *uent)
         |      ^~~~~~~~~~~~~~~~~
drivers/ub/ubus/cap.c:47:5: warning: no previous prototype for 'ub_find_capability' [-Wmissing-prototypes]
      47 | u32 ub_find_capability(u32 cap)
         |     ^~~~~~~~~~~~~~~~~~
drivers/ub/ubus/cap.c:52:5: warning: no previous prototype for 'ub_cap_read_byte' [-Wmissing-prototypes]
      52 | int ub_cap_read_byte(struct ub_entity *uent, u32 cap, u32 off, u8 *val)
         |     ^~~~~~~~~~~~~~~~
drivers/ub/ubus/cap.c:70:5: warning: no previous prototype for 'ub_cap_read_word' [-Wmissing-prototypes]
      70 | int ub_cap_read_word(struct ub_entity *uent, u32 cap, u32 off, u16 *val)
         |     ^~~~~~~~~~~~~~~~
drivers/ub/ubus/cap.c:88:5: warning: no previous prototype for 'ub_cap_read_dword' [-Wmissing-prototypes]
      88 | int ub_cap_read_dword(struct ub_entity *uent, u32 cap, u32 off, u32 *val)
         |     ^~~~~~~~~~~~~~~~~
drivers/ub/ubus/cap.c:106:5: warning: no previous prototype for 'ub_cap_write_byte' [-Wmissing-prototypes]
     106 | int ub_cap_write_byte(struct ub_entity *uent, u32 cap, u32 off, u8 val)
         |     ^~~~~~~~~~~~~~~~~
drivers/ub/ubus/cap.c:117:5: warning: no previous prototype for 'ub_cap_write_word' [-Wmissing-prototypes]
     117 | int ub_cap_write_word(struct ub_entity *uent, u32 cap, u32 off, u16 val)
         |     ^~~~~~~~~~~~~~~~~
drivers/ub/ubus/cap.c:128:5: warning: no previous prototype for 'ub_cap_write_dword' [-Wmissing-prototypes]
     128 | int ub_cap_write_dword(struct ub_entity *uent, u32 cap, u32 off, u32 val)
         |     ^~~~~~~~~~~~~~~~~~
drivers/ub/ubus/cap.c:139:5: warning: no previous prototype for 'ub_cap_clear_and_set_word' [-Wmissing-prototypes]
     139 | int ub_cap_clear_and_set_word(struct ub_entity *dev, u32 cap, u32 off,
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/ub/ubus/cap.c:155:5: warning: no previous prototype for 'ub_cap_clear_and_set_dword' [-Wmissing-prototypes]
     155 | int ub_cap_clear_and_set_dword(struct ub_entity *dev, u32 cap, u32 off,
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/ub/ubus/cap.c:224:6: warning: no previous prototype for 'ub_init_capabilities' [-Wmissing-prototypes]
     224 | void ub_init_capabilities(struct ub_entity *uent)
         |      ^~~~~~~~~~~~~~~~~~~~
drivers/ub/ubus/cap.c:238:6: warning: no previous prototype for 'ub_uninit_capabilities' [-Wmissing-prototypes]
     238 | void ub_uninit_capabilities(struct ub_entity *uent)
         |      ^~~~~~~~~~~~~~~~~~~~~~
Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for RESCTRL_FS
   Depends on [n]: MISC_FILESYSTEMS [=n] && ARCH_HAS_CPU_RESCTRL [=y]
   Selected by [y]:
   - ARM64_MPAM [=y]

vim +/ub_set_cap_bitmap +12 drivers/ub/ubus/cap.c

    11
...
12	void ub_set_cap_bitmap(struct ub_entity *uent)
    13	{
    14		int ret;
    15		u32 i;
    16	
    17		for (i = 0; i < SZ_8; i++) {
    18			ret = ub_cfg_read_dword(uent, UB_CFG1_CAP_BITMAP + (i << SZ_2),
    19						&uent->cfg1_bitmap[i]);
    20			if (ret)
    21				ub_err(uent, "Read cfg1 cap bitmap failed, ret=%d\n",
    22				       ret);
    23		}
    24	
    25		if (is_p_device(uent))
    26			return;
    27	
    28		for (i = 0; i < SZ_8; i++) {
    29			ret = ub_cfg_read_dword(uent, UB_CFG0_CAP_BITMAP + (i << SZ_2),
    30						&uent->cfg0_bitmap[i]);
    31			if (ret)
    32				ub_err(uent, "Read cfg0 cap bitmap failed, ret=%d\n",
    33				       ret);
    34		}
    35	}
    36	
    37	/* Check whether the capbility register is implemented. */
    38	static bool ub_cap_reg_implemented(struct ub_entity *uent, u32 cap)
    39	{
    40		u32 i = (cap & 0xFF) / SZ_32;
    41		u32 val = (cap >> SZ_8) ? uent->cfg1_bitmap[i] : uent->cfg0_bitmap[i];
    42	
    43		return val & BIT((cap & 0xFF) % SZ_32);
    44	}
    45	
    46	/* find the start address of capability */
47	u32 ub_find_capability(u32 cap)
    48	{
    49		return (cap << BITS_PER_BYTE) << SZ_2;
    50	}
    51	
52	int ub_cap_read_byte(struct ub_entity *uent, u32 cap, u32 off, u8 *val)
    53	{
    54		int ret;
    55	
    56		*val = 0;
    57		if (off >= SZ_1K)
    58			return -EFAULT;
    59	
    60		if (!ub_cap_reg_implemented(uent, cap))
    61			return -ENXIO;
    62	
    63		ret = ub_cfg_read_byte(uent, ub_find_capability(cap) + off, val);
    64		if (ret)
    65			*val = 0;
    66	
    67		return ret;
    68	}
    69	
70	int ub_cap_read_word(struct ub_entity *uent, u32 cap, u32 off, u16 *val)
    71	{
    72		int ret;
    73	
    74		*val = 0;
    75		if (off & 1 || off >= SZ_1K)
    76			return -EFAULT;
    77	
    78		if (!ub_cap_reg_implemented(uent, cap))
    79			return -ENXIO;
    80	
    81		ret = ub_cfg_read_word(uent, ub_find_capability(cap) + off, val);
    82		if (ret)
    83			*val = 0;
    84	
    85		return ret;
    86	}
    87	
88	int ub_cap_read_dword(struct ub_entity *uent, u32 cap, u32 off, u32 *val)
    89	{
    90		int ret;
    91	
    92		*val = 0;
    93		if (off & DW_CHECK || off >= SZ_1K)
    94			return -EFAULT;
    95	
    96		if (!ub_cap_reg_implemented(uent, cap))
    97			return -ENXIO;
    98	
    99		ret = ub_cfg_read_dword(uent, ub_find_capability(cap) + off, val);
   100		if (ret)
   101			*val = 0;
   102	
   103		return ret;
   104	}
   105	
106	int ub_cap_write_byte(struct ub_entity *uent, u32 cap, u32 off, u8 val)
   107	{
   108		if (off >= SZ_1K)
   109			return -EFAULT;
   110	
   111		if (!ub_cap_reg_implemented(uent, cap))
   112			return -ENXIO;
   113	
   114		return ub_cfg_write_byte(uent, ub_find_capability(cap) + off, val);
   115	}
   116	
117	int ub_cap_write_word(struct ub_entity *uent, u32 cap, u32 off, u16 val)
   118	{
   119		if (off & 1 || off >= SZ_1K)
   120			return -EFAULT;
   121	
   122		if (!ub_cap_reg_implemented(uent, cap))
   123			return -ENXIO;
   124	
   125		return ub_cfg_write_word(uent, ub_find_capability(cap) + off, val);
   126	}
   127	
128	int ub_cap_write_dword(struct ub_entity *uent, u32 cap, u32 off, u32 val)
   129	{
   130		if (off & DW_CHECK || off >= SZ_1K)
   131			return -EFAULT;
   132	
   133		if (!ub_cap_reg_implemented(uent, cap))
   134			return -ENXIO;
   135	
   136		return ub_cfg_write_dword(uent, ub_find_capability(cap) + off, val);
   137	}
   138	
139	int ub_cap_clear_and_set_word(struct ub_entity *dev, u32 cap, u32 off,
   140				      u16 clear, u16 set)
   141	{
   142		u16 val;
   143		int ret;
   144	
   145		ret = ub_cap_read_word(dev, cap, off, &val);
   146		if (!ret) {
   147			val &= ~clear;
   148			val |= set;
   149			ret = ub_cap_write_word(dev, cap, off, val);
   150		}
   151	
   152		return ret;
   153	}
   154	
155	int ub_cap_clear_and_set_dword(struct ub_entity *dev, u32 cap, u32 off,
   156				       u32 clear, u32 set)
   157	{
   158		u32 val;
   159		int ret;
   160	
   161		ret = ub_cap_read_dword(dev, cap, off, &val);
   162		if (!ret) {
   163			val &= ~clear;
   164			val |= set;
   165			ret = ub_cap_write_dword(dev, cap, off, val);
   166		}
   167	
   168		return ret;
   169	}
   170
-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

kernel test robot

tags

participants (1)