[openeuler:OLK-6.6 2377/2961] kernel/sched/psi.c:384:13: error: invalid storage class for function 'test_fine_grained_stat'

5 Feb 2024

      tree:   https://gitee.com/openeuler/kernel.git OLK-6.6
head:   413aaa5179daf233ab0cf4c22869ac607c838236
commit: 654944510822988390470cbc5b6f914c19dd9b88 [2377/2961] sched/psi: add cpu fine grained stall tracking in pressure.stat
config: loongarch-randconfig-001-20240205 (https://download.01.org/0day-ci/archive/20240205/202402051440.1AwHgCIo-lkp@i...)
compiler: loongarch64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240205/202402051440.1AwHgCIo-lkp@i...)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202402051440.1AwHgCIo-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from include/linux/irq.h:23,
                    from kernel/sched/build_utility.c:29:
   include/linux/nmi.h: In function 'trigger_all_cpu_backtrace':
   arch/loongarch/include/asm/irq.h:42:40: error: void value not ignored as it ought to be
      42 | #define arch_trigger_cpumask_backtrace arch_trigger_cpumask_backtrace
   include/linux/nmi.h:160:16: note: in expansion of macro 'arch_trigger_cpumask_backtrace'
     160 |         return arch_trigger_cpumask_backtrace(cpu_online_mask, -1);
         |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/nmi.h: In function 'trigger_allbutcpu_cpu_backtrace':
   arch/loongarch/include/asm/irq.h:42:40: error: void value not ignored as it ought to be
      42 | #define arch_trigger_cpumask_backtrace arch_trigger_cpumask_backtrace
   include/linux/nmi.h:165:16: note: in expansion of macro 'arch_trigger_cpumask_backtrace'
     165 |         return arch_trigger_cpumask_backtrace(cpu_online_mask, exclude_cpu);
         |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/nmi.h: In function 'trigger_cpumask_backtrace':
   arch/loongarch/include/asm/irq.h:42:40: error: void value not ignored as it ought to be
      42 | #define arch_trigger_cpumask_backtrace arch_trigger_cpumask_backtrace
   include/linux/nmi.h:170:16: note: in expansion of macro 'arch_trigger_cpumask_backtrace'
     170 |         return arch_trigger_cpumask_backtrace(mask, -1);
         |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/nmi.h: In function 'trigger_single_cpu_backtrace':
   arch/loongarch/include/asm/irq.h:42:40: error: void value not ignored as it ought to be
      42 | #define arch_trigger_cpumask_backtrace arch_trigger_cpumask_backtrace
   include/linux/nmi.h:175:16: note: in expansion of macro 'arch_trigger_cpumask_backtrace'
     175 |         return arch_trigger_cpumask_backtrace(cpumask_of(cpu), -1);
         |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   In file included from kernel/sched/build_utility.c:97:
   kernel/sched/psi.c: In function 'record_stat_times':
...
...
kernel/sched/psi.c:384:13: error: invalid storage class for function 'test_fine_grained_stat'
     384 | static bool test_fine_grained_stat(unsigned int *stat_tasks,
         |             ^~~~~~~~~~~~~~~~~~~~~~
kernel/sched/psi.c:419:13: error: invalid storage class for function 'psi_group_stat_change'
     419 | static void psi_group_stat_change(struct psi_group *group, int cpu,
         |             ^~~~~~~~~~~~~~~~~~~~~
kernel/sched/psi.c:447:13: error: invalid storage class for function 'psi_stat_flags_change'
     447 | static void psi_stat_flags_change(struct task_struct *task, int *stat_set,
         |             ^~~~~~~~~~~~~~~~~~~~~
kernel/sched/psi.c:469:13: error: invalid storage class for function 'get_recent_stat_times'
     469 | static void get_recent_stat_times(struct psi_group *group, int cpu,
         |             ^~~~~~~~~~~~~~~~~~~~~
kernel/sched/psi.c:496:13: error: invalid storage class for function 'update_throttle_type'
     496 | static void update_throttle_type(struct task_struct *task, int cpu, bool next)
         |             ^~~~~~~~~~~~~~~~~~~~
kernel/sched/psi.c:520:13: error: invalid storage class for function 'collect_percpu_times'
     520 | static void collect_percpu_times(struct psi_group *group,
         |             ^~~~~~~~~~~~~~~~~~~~
kernel/sched/psi.c:588:13: error: invalid storage class for function 'window_reset'
     588 | static void window_reset(struct psi_window *win, u64 now, u64 value,
         |             ^~~~~~~~~~~~
kernel/sched/psi.c:607:12: error: invalid storage class for function 'window_update'
     607 | static u64 window_update(struct psi_window *win, u64 now, u64 value)
         |            ^~~~~~~~~~~~~
kernel/sched/psi.c:633:12: error: invalid storage class for function 'update_triggers'
     633 | static u64 update_triggers(struct psi_group *group, u64 now, bool *update_total,
         |            ^~~~~~~~~~~~~~~
kernel/sched/psi.c:706:12: error: invalid storage class for function 'update_averages'
     706 | static u64 update_averages(struct psi_group *group, u64 now)
         |            ^~~~~~~~~~~~~~~
kernel/sched/psi.c:771:13: error: invalid storage class for function 'psi_avgs_work'
     771 | static void psi_avgs_work(struct work_struct *work)
         |             ^~~~~~~~~~~~~
kernel/sched/psi.c:807:13: error: invalid storage class for function 'init_rtpoll_triggers'
     807 | static void init_rtpoll_triggers(struct psi_group *group, u64 now)
         |             ^~~~~~~~~~~~~~~~~~~~
kernel/sched/psi.c:820:13: error: invalid storage class for function 'psi_schedule_rtpoll_work'
     820 | static void psi_schedule_rtpoll_work(struct psi_group *group, unsigned long delay,
         |             ^~~~~~~~~~~~~~~~~~~~~~~~
kernel/sched/psi.c:847:13: error: invalid storage class for function 'psi_rtpoll_work'
     847 | static void psi_rtpoll_work(struct psi_group *group)
         |             ^~~~~~~~~~~~~~~
kernel/sched/psi.c:931:12: error: invalid storage class for function 'psi_rtpoll_worker'
     931 | static int psi_rtpoll_worker(void *data)
         |            ^~~~~~~~~~~~~~~~~
kernel/sched/psi.c:949:13: error: invalid storage class for function 'poll_timer_fn'
     949 | static void poll_timer_fn(struct timer_list *t)
         |             ^~~~~~~~~~~~~
kernel/sched/psi.c:957:13: error: invalid storage class for function 'record_times'
     957 | static void record_times(struct psi_group_cpu *groupc, u64 now)
         |             ^~~~~~~~~~~~
kernel/sched/psi.c:990:13: error: invalid storage class for function 'psi_group_change'
     990 | static void psi_group_change(struct psi_group *group, int cpu,
         |             ^~~~~~~~~~~~~~~~
kernel/sched/psi.c:1106:13: error: invalid storage class for function 'task_is_in_psi_v1'
    1106 | static bool task_is_in_psi_v1(void)
         |             ^~~~~~~~~~~~~~~~~
kernel/sched/psi.c:1112:33: error: invalid storage class for function 'task_psi_group'
    1112 | static inline struct psi_group *task_psi_group(struct task_struct *task)
         |                                 ^~~~~~~~~~~~~~
   kernel/sched/psi.c:1130:13: error: invalid storage class for function 'psi_flags_change'
    1130 | static void psi_flags_change(struct task_struct *task, int clear, int set)
         |             ^~~~~~~~~~~~~~~~
   In file included from include/linux/linkage.h:7,
                    from include/linux/kernel.h:17,
                    from include/linux/cpumask.h:10,
                    from include/linux/smp.h:13,
                    from include/linux/sched/clock.h:5,
                    from kernel/sched/build_utility.c:12:
   kernel/sched/psi.c:1338:19: error: non-static declaration of 'psi_memstall_enter' follows static declaration
    1338 | EXPORT_SYMBOL_GPL(psi_memstall_enter);
         |                   ^~~~~~~~~~~~~~~~~~
   include/linux/export.h:74:28: note: in definition of macro '__EXPORT_SYMBOL'
      74 |         extern typeof(sym) sym;                                 \
         |                            ^~~
   include/linux/export.h:87:41: note: in expansion of macro '_EXPORT_SYMBOL'
      87 | #define EXPORT_SYMBOL_GPL(sym)          _EXPORT_SYMBOL(sym, "GPL")
         |                                         ^~~~~~~~~~~~~~
   kernel/sched/psi.c:1338:1: note: in expansion of macro 'EXPORT_SYMBOL_GPL'
    1338 | EXPORT_SYMBOL_GPL(psi_memstall_enter);
         | ^~~~~~~~~~~~~~~~~
   kernel/sched/psi.c:1306:6: note: previous definition of 'psi_memstall_enter' with type 'void(long unsigned int *)'
    1306 | void psi_memstall_enter(unsigned long *flags)
         |      ^~~~~~~~~~~~~~~~~~
   kernel/sched/psi.c:1370:19: error: non-static declaration of 'psi_memstall_leave' follows static declaration
    1370 | EXPORT_SYMBOL_GPL(psi_memstall_leave);
         |                   ^~~~~~~~~~~~~~~~~~
   include/linux/export.h:74:28: note: in definition of macro '__EXPORT_SYMBOL'
      74 |         extern typeof(sym) sym;                                 \
         |                            ^~~
   include/linux/export.h:87:41: note: in expansion of macro '_EXPORT_SYMBOL'
      87 | #define EXPORT_SYMBOL_GPL(sym)          _EXPORT_SYMBOL(sym, "GPL")
         |                                         ^~~~~~~~~~~~~~
   kernel/sched/psi.c:1370:1: note: in expansion of macro 'EXPORT_SYMBOL_GPL'
    1370 | EXPORT_SYMBOL_GPL(psi_memstall_leave);
         | ^~~~~~~~~~~~~~~~~
   kernel/sched/psi.c:1346:6: note: previous definition of 'psi_memstall_leave' with type 'void(long unsigned int *)'
    1346 | void psi_memstall_leave(unsigned long *flags)
         |      ^~~~~~~~~~~~~~~~~~
   kernel/sched/psi.c:1763:12: error: invalid storage class for function 'psi_io_show'
    1763 | static int psi_io_show(struct seq_file *m, void *v)
         |            ^~~~~~~~~~~
   kernel/sched/psi.c:1768:12: error: invalid storage class for function 'psi_memory_show'
    1768 | static int psi_memory_show(struct seq_file *m, void *v)
         |            ^~~~~~~~~~~~~~~
   kernel/sched/psi.c:1773:12: error: invalid storage class for function 'psi_cpu_show'
    1773 | static int psi_cpu_show(struct seq_file *m, void *v)
         |            ^~~~~~~~~~~~
   kernel/sched/psi.c:1778:12: error: invalid storage class for function 'psi_io_open'
    1778 | static int psi_io_open(struct inode *inode, struct file *file)
         |            ^~~~~~~~~~~
   kernel/sched/psi.c:1783:12: error: invalid storage class for function 'psi_memory_open'
    1783 | static int psi_memory_open(struct inode *inode, struct file *file)
         |            ^~~~~~~~~~~~~~~
   kernel/sched/psi.c:1788:12: error: invalid storage class for function 'psi_cpu_open'
    1788 | static int psi_cpu_open(struct inode *inode, struct file *file)
         |            ^~~~~~~~~~~~
   kernel/sched/psi.c:1793:16: error: invalid storage class for function 'psi_write'
    1793 | static ssize_t psi_write(struct file *file, const char __user *user_buf,
         |                ^~~~~~~~~
   kernel/sched/psi.c:1836:16: error: invalid storage class for function 'psi_io_write'
    1836 | static ssize_t psi_io_write(struct file *file, const char __user *user_buf,
         |                ^~~~~~~~~~~~
   kernel/sched/psi.c:1842:16: error: invalid storage class for function 'psi_memory_write'
    1842 | static ssize_t psi_memory_write(struct file *file, const char __user *user_buf,
         |                ^~~~~~~~~~~~~~~~
   kernel/sched/psi.c:1848:16: error: invalid storage class for function 'psi_cpu_write'
    1848 | static ssize_t psi_cpu_write(struct file *file, const char __user *user_buf,
         |                ^~~~~~~~~~~~~
   kernel/sched/psi.c:1854:17: error: invalid storage class for function 'psi_fop_poll'
    1854 | static __poll_t psi_fop_poll(struct file *file, poll_table *wait)
         |                 ^~~~~~~~~~~~
   kernel/sched/psi.c:1861:12: error: invalid storage class for function 'psi_fop_release'
    1861 | static int psi_fop_release(struct inode *inode, struct file *file)
         |            ^~~~~~~~~~~~~~~
   kernel/sched/psi.c:1870:27: error: initializer element is not constant
    1870 |         .proc_open      = psi_io_open,
         |                           ^~~~~~~~~~~
   kernel/sched/psi.c:1870:27: note: (near initialization for 'psi_io_proc_ops.proc_open')
   kernel/sched/psi.c:1873:27: error: initializer element is not constant
    1873 |         .proc_write     = psi_io_write,
         |                           ^~~~~~~~~~~~
   kernel/sched/psi.c:1873:27: note: (near initialization for 'psi_io_proc_ops.proc_write')
   kernel/sched/psi.c:1874:27: error: initializer element is not constant
    1874 |         .proc_poll      = psi_fop_poll,
         |                           ^~~~~~~~~~~~
   kernel/sched/psi.c:1874:27: note: (near initialization for 'psi_io_proc_ops.proc_poll')
   kernel/sched/psi.c:1875:27: error: initializer element is not constant
    1875 |         .proc_release   = psi_fop_release,
         |                           ^~~~~~~~~~~~~~~
   kernel/sched/psi.c:1875:27: note: (near initialization for 'psi_io_proc_ops.proc_release')
   kernel/sched/psi.c:1879:27: error: initializer element is not constant
    1879 |         .proc_open      = psi_memory_open,
         |                           ^~~~~~~~~~~~~~~
   kernel/sched/psi.c:1879:27: note: (near initialization for 'psi_memory_proc_ops.proc_open')
   kernel/sched/psi.c:1882:27: error: initializer element is not constant
    1882 |         .proc_write     = psi_memory_write,
         |                           ^~~~~~~~~~~~~~~~
vim +/test_fine_grained_stat

a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin 25d00f6853c3c6 Lu Jialin 25d00f6853c3c6 Lu Jialin 25d00f6853c3c6 Lu Jialin 25d00f6853c3c6 Lu Jialin 25d00f6853c3c6 Lu Jialin 25d00f6853c3c6 Lu Jialin 25d00f6853c3c6 Lu Jialin 25d00f6853c3c6 Lu Jialin 25d00f6853c3c6 Lu Jialin 25d00f6853c3c6 Lu Jialin 25d00f6853c3c6 Lu Jialin 25d00f6853c3c6 Lu Jialin 25d00f6853c3c6 Lu Jialin 25d00f6853c3c6 Lu Jialin 25d00f6853c3c6 Lu Jialin 25d00f6853c3c6 Lu Jialin 25d00f6853c3c6 Lu Jialin 25d00f6853c3c6 Lu Jialin 25d00f6853c3c6 Lu Jialin 25d00f6853c3c6 Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin 65494451082298 Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin 0df60cce43301d Lu Jialin 0df60cce43301d Lu Jialin 0df60cce43301d Lu Jialin 0df60cce43301d Lu Jialin 0df60cce43301d Lu Jialin 0df60cce43301d Lu Jialin 0df60cce43301d Lu Jialin 0df60cce43301d Lu Jialin 0df60cce43301d Lu Jialin 0df60cce43301d Lu Jialin 0df60cce43301d Lu Jialin 0df60cce43301d Lu Jialin 0df60cce43301d Lu Jialin 0df60cce43301d Lu Jialin 0df60cce43301d Lu Jialin 0df60cce43301d Lu Jialin 0df60cce43301d Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin a65983d90bfb5e Lu Jialin 65494451082298 Lu Jialin 65494451082298 Lu Jialin 65494451082298 Lu Jialin 65494451082298 Lu Jialin 65494451082298 Lu Jialin 65494451082298 Lu Jialin 65494451082298 Lu Jialin 65494451082298 Lu Jialin 65494451082298 Lu Jialin 65494451082298 Lu Jialin 65494451082298 Lu Jialin 65494451082298 Lu Jialin 65494451082298 Lu Jialin 65494451082298 Lu Jialin 65494451082298 Lu Jialin 65494451082298 Lu Jialin 65494451082298 Lu Jialin 65494451082298 Lu Jialin 65494451082298 Lu Jialin 65494451082298 Lu Jialin 65494451082298 Lu Jialin 65494451082298 Lu Jialin 65494451082298 Lu Jialin 65494451082298 Lu Jialin 65494451082298 Lu Jialin 65494451082298 Lu Jialin 0e94682b73bfa6 0e94682b73bfa6 0e94682b73bfa6 eb414681d5a07d Johannes Weiner 0df60cce43301d Lu Jialin 0df60cce43301d Lu Jialin 0df60cce43301d Lu Jialin eb414681d5a07d Johannes Weiner eb414681d5a07d Johannes Weiner 333f3017c5a893 eb414681d5a07d Johannes Weiner eb414681d5a07d Johannes Weiner eb414681d5a07d Johannes Weiner eb414681d5a07d Johannes Weiner eb414681d5a07d Johannes Weiner eb414681d5a07d Johannes Weiner eb414681d5a07d Johannes Weiner eb414681d5a07d Johannes Weiner eb414681d5a07d Johannes Weiner eb414681d5a07d Johannes Weiner eb414681d5a07d Johannes Weiner eb414681d5a07d Johannes Weiner eb414681d5a07d Johannes Weiner eb414681d5a07d Johannes Weiner 333f3017c5a893 eb414681d5a07d Johannes Weiner 0e94682b73bfa6 333f3017c5a893 333f3017c5a893 eb414681d5a07d Johannes Weiner eb414681d5a07d Johannes Weiner eb414681d5a07d Johannes Weiner eb414681d5a07d Johannes Weiner eb414681d5a07d Johannes Weiner eb414681d5a07d Johannes Weiner 0df60cce43301d Lu Jialin 0df60cce43301d Lu Jialin 0df60cce43301d Lu Jialin eb414681d5a07d Johannes Weiner eb414681d5a07d Johannes Weiner eb414681d5a07d Johannes Weiner eb414681d5a07d Johannes Weiner eb414681d5a07d Johannes Weiner eb414681d5a07d Johannes Weiner eb414681d5a07d Johannes Weiner eb414681d5a07d Johannes Weiner eb414681d5a07d Johannes Weiner eb414681d5a07d Johannes Weiner eb414681d5a07d Johannes Weiner eb414681d5a07d Johannes Weiner eb414681d5a07d Johannes Weiner eb414681d5a07d Johannes Weiner eb414681d5a07d Johannes Weiner eb414681d5a07d Johannes Weiner 0e94682b73bfa6 0e94682b73bfa6 eb414681d5a07d Johannes Weiner

:::::: The code :::::: a65983d90bfb5e031

:::::: TO: Lu Jialin :::::: CC: yanhaitao

-- 0-DAY CI Kernel Test Service pcpu, cpu); 2024-01-04  426 2024-01-04  427  	write_seqcount_begin(&groupc->seq); 2024-01-04  428 2024-01-04  429  	for (t = 0; clear; clear &= ~(1 << t), t++) 2024-01-04  430  		if (clear & (1 << t)) 2024-01-04  431  			groupc->fine_grained_tasks[t]--; 2024-01-04  432  	for (t = 0; set; set &= ~(1 << t), t++) 2024-01-04  433  		if (set & (1 << t)) 2024-01-04  434  			groupc->fine_grained_tasks[t]++; 2024-01-04  435  	for (s = 0; s < PSI_CPU_CFS_BANDWIDTH_FULL; s++) 2024-01-04  436  		if (test_fine_grained_stat(groupc->fine_grained_tasks, 2024-01-04  437  					   groupc->tasks[NR_RUNNING], s)) 2024-01-04  438  			state_mask |= (1 << s); 2024-01-04  439  	if (unlikely(groupc->state_mask & PSI_ONCPU) && 2024-01-04  440  		     cpu_curr(cpu)->memstall_type) 2024-01-04  441  		state_mask |= (1 << (cpu_curr(cpu)->memstall_type * 2 - 1)); 2024-01-04  442 2024-01-04  443  	groupc->fine_grained_state_mask = state_mask; 2024-01-04  444  	write_seqcount_end(&groupc->seq); 2024-01-04  445  } 2024-01-04  446 2024-01-04 @447  static void psi_stat_flags_change(struct task_struct *task, int *stat_set, 2024-01-04  448  				  int *stat_clear, int set, int clear) 2024-01-04  449  { 2024-01-04  450  	if (!task->memstall_type) 2024-01-04  451  		return; 2024-01-04  452 2024-01-04  453  	if (clear) { 2024-01-04  454  		if (clear & TSK_MEMSTALL) 2024-01-04  455  			*stat_clear |= 1 << (2 * task->memstall_type - 2); 2024-01-04  456  		if (clear & TSK_MEMSTALL_RUNNING) 2024-01-04  457  			*stat_clear |= 1 << (2 * task->memstall_type - 1); 2024-01-04  458  	} 2024-01-04  459  	if (set) { 2024-01-04  460  		if (set & TSK_MEMSTALL) 2024-01-04  461  			*stat_set |= 1 << (2 * task->memstall_type - 2); 2024-01-04  462  		if (set & TSK_MEMSTALL_RUNNING) 2024-01-04  463  			*stat_set |= 1 << (2 * task->memstall_type - 1); 2024-01-04  464  	} 2024-01-04  465  	if (!task->in_memstall) 2024-01-04  466  		task->memstall_type = 0; 2024-01-04  467  } 2024-01-04  468 2024-01-04 @469  static void get_recent_stat_times(struct psi_group *group, int cpu, 2024-01-04  470  				  enum psi_aggregators aggregator, u64 *stat_delta, u64 nonidle) 2024-01-04  471  { 2024-01-04  472  	struct psi_group_cpu *groupc = per_cpu_ptr(group->pcpu, cpu); 2024-01-04  473  	u32 times[NR_PSI_STAT_STATES] = {0}; 2024-01-04  474  	enum psi_stat_states s; 2024-01-04  475  	u32 delta; 2024-01-04  476 2024-01-04  477  	memcpy(times, groupc->fine_grained_times, sizeof(groupc->fine_grained_times)); 2024-01-04  478  	for (s = 0; s < NR_PSI_STAT_STATES; s++) { 2024-01-04  479  		if (groupc->fine_grained_state_mask & (1 << s)) 2024-01-04  480  			times[s] += groupc->fine_grained_times_delta; 2024-01-04  481  		delta = times[s] - groupc->fine_grained_times_prev[aggregator][s]; 2024-01-04  482  		groupc->fine_grained_times_prev[aggregator][s] = times[s]; 2024-01-04  483  		stat_delta[s] += (u64)delta * nonidle; 2024-01-04  484  	} 2024-01-04  485  } 2024-01-04  486  #else 2024-01-04  487  static inline void psi_group_stat_change(struct psi_group *group, int cpu, 2024-01-04  488  					 int clear, int set) {} 2024-01-04  489  static inline void psi_stat_flags_change(struct task_struct *task, 2024-01-04  490  					 int *stat_set, int *stat_clear, 2024-01-04  491  					 int set, int clear) {} 2024-01-04  492  #endif 2024-01-04  493 2024-01-04  494  #if defined(CONFIG_CFS_BANDWIDTH) && defined(CONFIG_CGROUP_CPUACCT) && \ 2024-01-04  495  	defined(CONFIG_PSI_FINE_GRAINED) 2024-01-04 @496  static void update_throttle_type(struct task_struct *task, int cpu, bool next) 2024-01-04  497  { 2024-01-04  498  	if (!cgroup_subsys_on_dfl(cpuacct_cgrp_subsys)) { 2024-01-04  499  		struct cgroup *cpuacct_cgrp; 2024-01-04  500  		struct psi_group_cpu *groupc; 2024-01-04  501  		struct task_group *tsk_grp; 2024-01-04  502 2024-01-04  503  		rcu_read_lock(); 2024-01-04  504  		cpuacct_cgrp = task_cgroup(task, cpuacct_cgrp_id); 2024-01-04  505  		if (cgroup_parent(cpuacct_cgrp)) { 2024-01-04  506  			groupc = per_cpu_ptr(cgroup_psi(cpuacct_cgrp)->pcpu, cpu); 2024-01-04  507  			tsk_grp = task_group(task); 2024-01-04  508  			if (next) 2024-01-04  509  				groupc->prev_throttle = groupc->cur_throttle; 2024-01-04  510  			groupc->cur_throttle = tsk_grp->cfs_rq[cpu]->throttled; 2024-01-04  511  		} 2024-01-04  512  		rcu_read_unlock(); 2024-01-04  513  	} 2024-01-04  514  } 2024-01-04  515  #else 2024-01-04  516  static inline void update_throttle_type(struct task_struct *task, int cpu, 2024-01-04  517  					bool next) {} 2024-01-04  518  #endif 2024-01-04  519 Suren Baghdasaryan 2019-05-14 @520  static void collect_percpu_times(struct psi_group *group, Suren Baghdasaryan 2019-05-14  521  				 enum psi_aggregators aggregator, Suren Baghdasaryan 2019-05-14  522  				 u32 *pchanged_states) 2018-10-26  523  { 2024-01-04  524  #ifdef CONFIG_PSI_FINE_GRAINED 2024-01-04  525  	u64 stat_delta[NR_PSI_STAT_STATES] = { 0 }; 2024-01-04  526  #endif 2018-10-26  527  	u64 deltas[NR_PSI_STATES - 1] = { 0, }; 2018-10-26  528  	unsigned long nonidle_total = 0; Suren Baghdasaryan 2019-05-14  529  	u32 changed_states = 0; 2018-10-26  530  	int cpu; 2018-10-26  531  	int s; 2018-10-26  532 2018-10-26  533  	/* 2018-10-26  534  	 * Collect the per-cpu time buckets and average them into a 2018-10-26  535  	 * single time sample that is normalized to wallclock time. 2018-10-26  536  	 * 2018-10-26  537  	 * For averaging, each CPU is weighted by its non-idle time in 2018-10-26  538  	 * the sampling period. This eliminates artifacts from uneven 2018-10-26  539  	 * loading, or even entirely idle CPUs. 2018-10-26  540  	 */ 2018-10-26  541  	for_each_possible_cpu(cpu) { 2018-10-26  542  		u32 times[NR_PSI_STATES]; 2018-10-26  543  		u32 nonidle; Suren Baghdasaryan 2019-05-14  544  		u32 cpu_changed_states; 2018-10-26  545 Suren Baghdasaryan 2019-05-14  546  		get_recent_times(group, cpu, aggregator, times, Suren Baghdasaryan 2019-05-14  547  				&cpu_changed_states); Suren Baghdasaryan 2019-05-14  548  		changed_states |= cpu_changed_states; 2018-10-26  549 2018-10-26  550  		nonidle = nsecs_to_jiffies(times[PSI_NONIDLE]); 2018-10-26  551  		nonidle_total += nonidle; 2018-10-26  552 2018-10-26  553  		for (s = 0; s < PSI_NONIDLE; s++) 2018-10-26  554  			deltas[s] += (u64)times[s] * nonidle; 2024-01-04  555  #ifdef CONFIG_PSI_FINE_GRAINED 2024-01-04  556  		get_recent_stat_times(group, cpu, aggregator, stat_delta, nonidle); 2024-01-04  557  #endif 2018-10-26  558  	} 2018-10-26  559 2018-10-26  560  	/* 2018-10-26  561  	 * Integrate the sample into the running statistics that are 2018-10-26  562  	 * reported to userspace: the cumulative stall times and the 2018-10-26  563  	 * decaying averages. 2018-10-26  564  	 * 2018-10-26  565  	 * Pressure percentages are sampled at PSI_FREQ. We might be 2018-10-26  566  	 * called more often when the user polls more frequently than 2018-10-26  567  	 * that; we might be called less often when there is no task 2018-10-26  568  	 * activity, thus no data, and clock ticks are sporadic. The 2018-10-26  569  	 * below handles both. 2018-10-26  570  	 */ 2018-10-26  571 2018-10-26  572  	/* total= */ 2018-10-26  573  	for (s = 0; s < NR_PSI_STATES - 1; s++) Suren Baghdasaryan 2019-05-14  574  		group->total[aggregator][s] += Suren Baghdasaryan 2019-05-14  575  				div_u64(deltas[s], max(nonidle_total, 1UL)); 2018-10-26  576 at line 384 was first introduced by commit 444fea492b32f931c83ffcf sched/psi: Introduce fine grained stall time collect for cgroup reclaim <lujialin4@huawei.com> <yanhaitao2@huawei.com> href="https://github.com/intel/lkp-tests/wiki">https://github.com/intel/lkp-tests/wiki

kernel test robot

tags

participants (1)