- Linuxarm - mailweb.openeuler.org

[RFCv3 PATCH net-next] net: extend netdev_features_t
by Jian Shen 01 Nov '21

01 Nov '21

For the prototype of netdev_features_t is u64, and the number of netdevice feature bits is 64 now. So there is no space to introduce new feature bit. This patchset try to solve it by change the prototype of netdev_features_t from u64 to structure below: typedef struct { DECLARE_BITMAP(bits, NETDEV_FEATURE_COUNT); } netdev_features_t; With this change, it's necessary to introduce a set of bitmap operation helpers for netdev features. As the nic drivers are not supposed to modify netdev_features directly, it also introduces wrappers helpers to this. The whole work is not complete yet. I just use these changes on HNS3 drivers and part of net/core/dev.c, in order to show how these helpers will be used. I want to get more suggestions for this scheme, any comments would be appreciated. The former discussion please see [1]. [1]:https://www.spinics.net/lists/netdev/msg769952.html ChangeLog: V2->V3: use structure for bitmap, suggest by Edward Cree V1->V2: Extend the prototype from u64 to bitmap, suggest by Andrew Lunn Signed-off-by: Jian Shen <shenjian15(a)huawei.com> --- .../net/ethernet/hisilicon/hns3/hns3_enet.c | 89 ++-- include/linux/netdev_features.h | 471 +++++++++++++++--- net/core/dev.c | 119 +++-- 3 files changed, 528 insertions(+), 151 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c index a2b993d62822..3352c38fd927 100644 --- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c @@ -2306,48 +2306,55 @@ static int hns3_nic_do_ioctl(struct net_device *netdev, static int hns3_nic_set_features(struct net_device *netdev, netdev_features_t features) { - netdev_features_t changed = netdev->features ^ features; + netdev_features_t changed = netdev_active_features_xor(netdev, + features); struct hns3_nic_priv *priv = netdev_priv(netdev); struct hnae3_handle *h = priv->ae_handle; bool enable; int ret; - if (changed & (NETIF_F_GRO_HW) && h->ae_algo->ops->set_gro_en) { - enable = !!(features & NETIF_F_GRO_HW); + if (netdev_features_test_bit(NETIF_F_GRO_HW_BIT, changed) && + h->ae_algo->ops->set_gro_en) { + enable = netdev_features_test_bit(NETIF_F_GRO_HW_BIT, features); ret = h->ae_algo->ops->set_gro_en(h, enable); if (ret) return ret; } - if ((changed & NETIF_F_HW_VLAN_CTAG_RX) && + if (netdev_features_test_bit(NETIF_F_HW_VLAN_CTAG_RX_BIT, changed) && h->ae_algo->ops->enable_hw_strip_rxvtag) { - enable = !!(features & NETIF_F_HW_VLAN_CTAG_RX); + enable = netdev_features_test_bit(NETIF_F_HW_VLAN_CTAG_RX_BIT, + features); ret = h->ae_algo->ops->enable_hw_strip_rxvtag(h, enable); if (ret) return ret; } - if ((changed & NETIF_F_NTUPLE) && h->ae_algo->ops->enable_fd) { + if (netdev_features_test_bit(NETIF_F_NTUPLE_BIT, changed) && + h->ae_algo->ops->enable_fd) { enable = !!(features & NETIF_F_NTUPLE); h->ae_algo->ops->enable_fd(h, enable); } - if ((netdev->features & NETIF_F_HW_TC) > (features & NETIF_F_HW_TC) && + if (netdev_active_features_test_bit(netdev, NETIF_F_HW_TC_BIT) > + netdev_features_test_bit(NETIF_F_NTUPLE_BIT, features) && h->ae_algo->ops->cls_flower_active(h)) { netdev_err(netdev, "there are offloaded TC filters active, cannot disable HW TC offload"); return -EINVAL; } - if ((changed & NETIF_F_HW_VLAN_CTAG_FILTER) && + if (netdev_features_test_bit(NETIF_F_HW_VLAN_CTAG_FILTER_BIT, + changed) && h->ae_algo->ops->enable_vlan_filter) { - enable = !!(features & NETIF_F_HW_VLAN_CTAG_FILTER); + enable = netdev_features_test_bit(NETIF_F_HW_VLAN_CTAG_FILTER_BIT, + features); ret = h->ae_algo->ops->enable_vlan_filter(h, enable); if (ret) return ret; } - netdev->features = features; + netdev_set_active_features(netdev, features); return 0; } @@ -2377,7 +2384,8 @@ static netdev_features_t hns3_features_check(struct sk_buff *skb, * len of 480 bytes. */ if (len > HNS3_MAX_HDR_LEN) - features &= ~(NETIF_F_CSUM_MASK | NETIF_F_GSO_MASK); + netdev_features_clear_bits(NETIF_F_CSUM_MASK | NETIF_F_GSO_MASK, + &features); return features; } @@ -3122,55 +3130,68 @@ static struct pci_driver hns3_driver = { .err_handler = &hns3_err_handler, }; +#define HNS3_DEFAULT_ACTIVE_FEATURES \ + (NETIF_F_HW_VLAN_CTAG_FILTER | NETIF_F_HW_VLAN_CTAG_TX | \ + NETIF_F_HW_VLAN_CTAG_RX | NETIF_F_RXCSUM | NETIF_F_SG | \ + NETIF_F_GSO | NETIF_F_GRO | NETIF_F_TSO | NETIF_F_TSO6 | \ + NETIF_F_GSO_GRE | NETIF_F_GSO_GRE_CSUM | NETIF_F_SCTP_CRC \ + NETIF_F_GSO_UDP_TUNNEL | NETIF_F_FRAGLIST) + /* set default feature to hns3 */ static void hns3_set_default_feature(struct net_device *netdev) { struct hnae3_handle *h = hns3_get_handle(netdev); struct pci_dev *pdev = h->pdev; struct hnae3_ae_dev *ae_dev = pci_get_drvdata(pdev); + netdev_features_t tmp1, tmp2; netdev->priv_flags |= IFF_UNICAST_FLT; - netdev->gso_partial_features |= NETIF_F_GSO_GRE_CSUM; + netdev_gso_partial_features_set_bit(netdev, NETIF_F_GSO_GRE_CSUM_BIT); - netdev->features |= NETIF_F_HW_VLAN_CTAG_FILTER | - NETIF_F_HW_VLAN_CTAG_TX | NETIF_F_HW_VLAN_CTAG_RX | - NETIF_F_RXCSUM | NETIF_F_SG | NETIF_F_GSO | - NETIF_F_GRO | NETIF_F_TSO | NETIF_F_TSO6 | NETIF_F_GSO_GRE | - NETIF_F_GSO_GRE_CSUM | NETIF_F_GSO_UDP_TUNNEL | - NETIF_F_SCTP_CRC | NETIF_F_FRAGLIST; + netdev_active_features_set_bits(netdev, HNS3_DEFAULT_ACTIVE_FEATURES); if (ae_dev->dev_version >= HNAE3_DEVICE_VERSION_V2) { - netdev->features |= NETIF_F_GRO_HW; + netdev_active_features_set_bit(netdev, NETIF_F_GRO_HW_BIT); if (!(h->flags & HNAE3_SUPPORT_VF)) - netdev->features |= NETIF_F_NTUPLE; + netdev_active_features_set_bit(netdev, + NETIF_F_NTUPLE_BIT); } if (test_bit(HNAE3_DEV_SUPPORT_UDP_GSO_B, ae_dev->caps)) - netdev->features |= NETIF_F_GSO_UDP_L4; + netdev_active_features_set_bit(netdev, NETIF_F_GSO_UDP_L4_BIT); if (test_bit(HNAE3_DEV_SUPPORT_HW_TX_CSUM_B, ae_dev->caps)) - netdev->features |= NETIF_F_HW_CSUM; + netdev_active_features_set_bit(netdev, NETIF_F_HW_CSUM_BIT); else - netdev->features |= NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM; + netdev_active_features_set_bits(netdev, + NETIF_F_IP_CSUM | + NETIF_F_IPV6_CSUM); if (test_bit(HNAE3_DEV_SUPPORT_UDP_TUNNEL_CSUM_B, ae_dev->caps)) - netdev->features |= NETIF_F_GSO_UDP_TUNNEL_CSUM; + netdev_active_features_set_bit(netdev, + NETIF_F_GSO_UDP_TUNNEL_CSUM_BIT); if (test_bit(HNAE3_DEV_SUPPORT_FD_FORWARD_TC_B, ae_dev->caps)) - netdev->features |= NETIF_F_HW_TC; + netdev_active_features_set_bit(netdev, NETIF_F_HW_TC_BIT); - netdev->hw_features |= netdev->features; + tmp1 = netdev_get_active_features(netdev); + tmp2 = netdev_hw_features_or(netdev, tmp1); + netdev_set_hw_features(tmp2); if (!test_bit(HNAE3_DEV_SUPPORT_VLAN_FLTR_MDF_B, ae_dev->caps)) - netdev->hw_features &= ~NETIF_F_HW_VLAN_CTAG_FILTER; - - netdev->vlan_features |= netdev->features & - ~(NETIF_F_HW_VLAN_CTAG_FILTER | NETIF_F_HW_VLAN_CTAG_TX | - NETIF_F_HW_VLAN_CTAG_RX | NETIF_F_GRO_HW | NETIF_F_NTUPLE | - NETIF_F_HW_TC); - - netdev->hw_enc_features |= netdev->vlan_features | NETIF_F_TSO_MANGLEID; + netdev_hw_features_clear_bit(netdev, + NETIF_F_HW_VLAN_CTAG_FILTER_BIT); + + netdev_features_clear_bits(NETIF_F_HW_VLAN_CTAG_FILTER | + NETIF_F_HW_VLAN_CTAG_TX | + NETIF_F_HW_VLAN_CTAG_RX | NETIF_F_GRO_HW | + NETIF_F_NTUPLE | NETIF_F_HW_TC, &tmp1); + netdev_set_vlan_features(tmp1); + + netdev_features_set_bit(NETIF_F_TSO_MANGLEID_BIT, &tmp1); + tmp1 = netdev_hw_enc_features_or(netdev, tmp1); + netdev_set_hw_enc_features(tmp1); } static int hns3_alloc_buffer(struct hns3_enet_ring *ring, diff --git a/include/linux/netdev_features.h b/include/linux/netdev_features.h index 16f778887e14..9b3ab11e19c8 100644 --- a/include/linux/netdev_features.h +++ b/include/linux/netdev_features.h @@ -101,12 +101,12 @@ enum { typedef struct { DECLARE_BITMAP(bits, NETDEV_FEATURE_COUNT); -} netdev_features_t; +} netdev_features_t; #define NETDEV_FEATURE_DWORDS DIV_ROUND_UP(NETDEV_FEATURE_COUNT, 64) /* copy'n'paste compression ;) */ -#define __NETIF_F_BIT(bit) ((netdev_features_t)1 << (bit)) +#define __NETIF_F_BIT(bit) ((u64)1 << (bit)) #define __NETIF_F(name) __NETIF_F_BIT(NETIF_F_##name##_BIT) #define NETIF_F_FCOE_CRC __NETIF_F(FCOE_CRC) @@ -189,10 +189,7 @@ static inline int find_next_netdev_feature(u64 feature, unsigned long start) * mask_addr should be a u64 and bit an int */ #define for_each_netdev_feature(mask_addr, bit) \ - for ((bit) = find_next_netdev_feature((mask_addr), \ - NETDEV_FEATURE_COUNT); \ - (bit) >= 0; \ - (bit) = find_next_netdev_feature((mask_addr), (bit) - 1)) + for_each_set_bit(bit, (unsigned long *)mask_addr, NETDEV_FEATURE_COUNT) /* Features valid for ethtool to change */ /* = all defined minus driver/device-class-related */ @@ -265,131 +262,471 @@ static inline int find_next_netdev_feature(u64 feature, unsigned long start) NETIF_F_GSO_UDP_TUNNEL | \ NETIF_F_GSO_UDP_TUNNEL_CSUM) -static inline void netdev_feature_zero(netdev_features_t *dst) +static inline void netdev_features_zero(netdev_features_t *dst) { bitmap_zero(dst->bits, NETDEV_FEATURE_COUNT); } -static inline void netdev_feature_fill(netdev_features_t *dst) +static inline void netdev_features_fill(netdev_features_t *dst) { bitmap_fill(dst->bits, NETDEV_FEATURE_COUNT); } -static inline void netdev_feature_and(netdev_features_t *dst, - const netdev_features_t a, - const netdev_features_t b) +static inline netdev_features_t netdev_features_and(netdev_features_t a, + netdev_features_t b) { - bitmap_and(dst->bits, a.bits, b.bits, NETDEV_FEATURE_COUNT); + netdev_features_t dst; + + bitmap_and(dst.bits, a.bits, b.bits, NETDEV_FEATURE_COUNT); + return dst; } -static inline void netdev_feature_or(netdev_features_t *dst, - const netdev_features_t a, - const netdev_features_t b) +static inline netdev_features_t netdev_features_or(netdev_features_t a, + netdev_features_t b) { - bitmap_or(dst->bits, a.bits, b.bits, NETDEV_FEATURE_COUNT); + netdev_features_t dst; + + bitmap_or(dst.bits, a.bits, b.bits, NETDEV_FEATURE_COUNT); + return dst; } -static inline void netdev_feature_xor(netdev_features_t *dst, - const netdev_features_t a, - const netdev_features_t b) +static inline netdev_features_t netdev_features_xor(netdev_features_t a, + netdev_features_t b) { - bitmap_xor(dst->bits, a.bits, b.bits, NETDEV_FEATURE_COUNT); + netdev_features_t dst; + + bitmap_xor(dst.bits, a.bits, b.bits, NETDEV_FEATURE_COUNT); + return dst; } -static inline bool netdev_feature_empty(netdev_features_t src) +static inline bool netdev_features_empty(netdev_features_t src) { return bitmap_empty(src.bits, NETDEV_FEATURE_COUNT); } -static inline bool netdev_feature_equal(const netdev_features_t src1, - const netdev_features_t src2) +static inline bool netdev_features_equal(netdev_features_t src1, + netdev_features_t src2) { - return src1 == src2; + return bitmap_equal(src1.bits, src2.bits, NETDEV_FEATURE_COUNT); } -static inline int netdev_feature_andnot(netdev_features_t *dst, - const netdev_features_t src1, - const netdev_features_t src2) +static inline netdev_features_t netdev_features_andnot(netdev_features_t src1, + netdev_features_t src2) { - *dst = src1 & ~src2; - return 0; + netdev_features_t dst; + + bitmap_andnot(dst.bits, src1.bits, src2.bits, NETDEV_FEATURE_COUNT); + return dst; } -static inline void netdev_feature_set_bit(int nr, netdev_features_t *addr) +static inline void netdev_features_set_bit(int nr, netdev_features_t *src) { - *addr |= __NETIF_F_BIT(nr); + __set_bit(nr, src->bits); } -static inline void netdev_feature_clear_bit(int nr, netdev_features_t *addr) +static inline void netdev_features_clear_bit(int nr, netdev_features_t *src) { - *addr &= ~(__NETIF_F_BIT(nr)); + __clear_bit(nr, src->bits); } -static inline void netdev_feature_mod_bit(int nr, netdev_features_t *addr, - int set) +static inline void netdev_features_change_bit(int nr, netdev_features_t *src) { - if (set) - netdev_feature_set_bit(nr, addr); - else - netdev_feature_clear_bit(nr, addr); + __change_bit(nr, src->bits); } -static inline void netdev_feature_change_bit(int nr, netdev_features_t *addr) +static inline bool netdev_features_test_bit(int nr, netdev_features_t src) { - *addr ^= __NETIF_F_BIT(nr); + return test_bit(nr, src.bits); } -static inline int netdev_feature_test_bit(int nr, const netdev_features_t addr) +/* only be used for the first 64 bits features */ +static inline void netdev_features_set_bits(u64 bits, netdev_features_t *src) { - return (addr & __NETIF_F_BIT(nr)) > 0; + netdev_features_t tmp; + + bitmap_from_u64(tmp.bits, bits); + *src = netdev_features_or(*src, tmp); } -static inline void netdev_feature_set_bit_array(const int *array, - int array_size, - netdev_features_t *addr) +/* only be used for the first 64 bits features */ +static inline void netdev_features_clear_bits(u64 bits, netdev_features_t *src) { - int i; + netdev_features_t tmp; - for (i = 0; i < array_size; i++) - netdev_feature_set_bit(array[i], addr); + bitmap_from_u64(tmp.bits, bits); + *src = netdev_features_andnot(*src, tmp); } /* only be used for the first 64 bits features */ -static inline void netdev_feature_set_bits(u64 bits, netdev_features_t *addr) +static inline bool netdev_features_test_bits(u64 bits, netdev_features_t src) { - *addr |= bits; + netdev_features_t tmp; + + bitmap_from_u64(tmp.bits, bits); + tmp = netdev_features_and(tmp, src); + return netdev_features_empty(tmp); } /* only be used for the first 64 bits features */ -static inline void netdev_feature_clear_bits(u64 bits, netdev_features_t *addr) +static inline void netdev_features_and_bits(u64 bits, netdev_features_t *src) { - *addr &= ~bits; + netdev_features_t tmp; + + bitmap_from_u64(tmp.bits, bits); + *src = netdev_features_and(tmp, *src); } -/* only be used for the first 64 bits features */ -static inline bool netdev_feature_test_bits(u64 bits, - const netdev_features_t addr) +static inline bool netdev_features_intersects(netdev_features_t src1, + netdev_features_t src2) { - return (addr & bits) > 0; + return bitmap_intersects(src1.bits, src2.bits, NETDEV_FEATURE_COUNT); } -/* only be used for the first 64 bits features */ -static inline void netdev_feature_and_bits(u64 bits, - netdev_features_t *addr) +static inline bool netdev_features_subset(netdev_features_t src1, + netdev_features_t src2) +{ + return bitmap_subset(src1.bits, src2.bits, NETDEV_FEATURE_COUNT); +} + +static inline void netdev_set_active_features(struct net_device *netdev, + netdev_features_t src) +{ + netdev->features = src; +} + +static inline netdev_features_t +netdev_get_active_features(struct net_device *netdev) +{ + return netdev->features; +} + +#define netdev_active_features_zero(ndev) \ + netdev_features_zero(&ndev->features) + +#define netdev_active_features_and(ndev, features) \ + netdev_features_and(ndev->features, features) + +#define netdev_active_features_or(ndev, features) \ + netdev_features_or(ndev->features, features) + +#define netdev_active_features_xor(ndev, features) \ + netdev_features_xor(ndev->features, features) + +#define netdev_active_features_andnot(ndev, features) \ + netdev_features_andnot(ndev->features, features) + +#define netdev_active_features_set_bit(ndev, nr) \ + netdev_features_set_bit(nr, &ndev->features) + +#define netdev_active_features_clear_bit(ndev, nr) \ + netdev_features_clear_bit(nr, &ndev->features) + +#define netdev_active_features_test_bit(ndev, nr) \ + netdev_features_test_bit(nr, &ndev->features) + +#define netdev_active_features_set_bits(ndev, bits) \ + netdev_features_set_bits(bits, &ndev->features) + +#define netdev_active_features_clear_bits(ndev, bits) \ + netdev_features_clear_bits(bits, &ndev->features) + +#define netdev_active_features_test_bits(ndev, bits) \ + netdev_features_test_bits(bits, &ndev->features) + +#define netdev_active_features_and_bits(ndev, bits) \ + netdev_features_and_bits(bits, &ndev->features) + + +static inline void netdev_set_hw_features(struct net_device *netdev, + netdev_features_t src) +{ + netdev->hw_features = src; +} + +static inline netdev_features_t +netdev_get_hw_features(struct net_device *netdev) +{ + return netdev->hw_features; +} + +#define netdev_hw_features_zero(ndev) \ + netdev_features_zero(&ndev->hw_features) + +#define netdev_hw_features_copy(features) \ + netdev_features_copy(&ndev->hw_features) + + +#define netdev_hw_features_and(ndev, features) \ + netdev_features_and(ndev->hw_features, features) + +#define netdev_hw_features_or(ndev, features) \ + netdev_features_or(ndev->hw_features, features) + +#define netdev_hw_features_xor(ndev, features) \ + netdev_features_xor(ndev->hw_features, features) + +#define netdev_hw_features_andnot(ndev, features) \ + netdev_features_andnot(ndev->hw_features, features) + +#define netdev_hw_features_set_bit(ndev, nr) \ + netdev_features_set_bit(nr, &ndev->hw_features) + +#define netdev_hw_features_clear_bit(ndev, nr) \ + netdev_features_clear_bit(nr, &ndev->hw_features) + +#define netdev_hw_features_test_bit(ndev, nr) \ + netdev_features_test_bit(nr, &ndev->hw_features) + +#define netdev_hw_features_set_bits(ndev, bits) \ + netdev_features_set_bits(bits, &ndev->hw_features) + +#define netdev_hw_features_clear_bits(ndev, bits) \ + netdev_features_clear_bits(bits, &ndev->hw_features) + +#define netdev_hw_features_test_bits(ndev, bits) \ + netdev_features_test_bits(bits, &ndev->hw_features) + +#define netdev_hw_features_and_bits(ndev, bits) \ + netdev_features_and_bits(bits, &ndev->hw_features) + +static inline void netdev_set_wanted_features(struct net_device *netdev, + netdev_features_t src) +{ + netdev->wanted_features = src; +} + +static inline netdev_features_t +netdev_get_wanted_features(struct net_device *netdev) +{ + return netdev->wanted_features; +} + +#define netdev_wanted_features_zero(ndev) \ + netdev_features_zero(&ndev->wanted_features) + +#define netdev_wanted_features_and(ndev, features) \ + netdev_features_and(ndev->wanted_features, features) + +#define netdev_wanted_features_or(ndev, features) \ + netdev_features_or(ndev->wanted_features, features) + +#define netdev_wanted_features_xor(ndev, features) \ + netdev_features_xor(ndev->wanted_features, features) + +#define netdev_wanted_features_andnot(ndev, features) \ + netdev_features_andnot(ndev->wanted_features, features) + +#define netdev_wanted_features_set_bit(ndev, nr) \ + netdev_features_set_bit(nr, &ndev->wanted_features) + +#define netdev_wanted_features_clear_bit(ndev, nr) \ + netdev_features_clear_bit(nr, &ndev->wanted_features) + +#define netdev_wanted_features_test_bit(ndev, nr) \ + netdev_features_test_bit(nr, &ndev->wanted_features) + +#define netdev_wanted_features_set_bits(ndev, bits) \ + netdev_features_set_bits(bits, &ndev->wanted_features) + +#define netdev_wanted_features_clear_bits(ndev, bits) \ + netdev_features_clear_bits(bits, &ndev->wanted_features) + +#define netdev_wanted_features_test_bits(ndev, bits) \ + netdev_features_test_bits(bits, &ndev->wanted_features) + +#define netdev_wanted_features_and_bits(ndev, bits) \ + netdev_features_and_bits(bits, &ndev->wanted_features) + +static inline void netdev_set_vlan_features(struct net_device *netdev, + netdev_features_t src) +{ + netdev->vlan_features = src; +} + +static inline netdev_features_t +netdev_get_vlan_features(struct net_device *netdev) +{ + return netdev->vlan_features; +} + +#define netdev_vlan_features_zero(ndev) \ + netdev_features_zero(&ndev->vlan_features) + +#define netdev_vlan_features_and(ndev, features) \ + netdev_features_and(ndev->vlan_features, features) + +#define netdev_vlan_features_or(ndev, features) \ + netdev_features_or(ndev->vlan_features, features) + +#define netdev_vlan_features_xor(ndev, features) \ + netdev_features_xor(ndev->vlan_features, features) + +#define netdev_vlan_features_andnot(ndev, features) \ + netdev_features_andnot(ndev->vlan_features, features) + +#define netdev_vlan_features_set_bit(ndev, nr) \ + netdev_features_set_bit(nr, &ndev->vlan_features) + +#define netdev_vlan_features_clear_bit(ndev, nr) \ + netdev_features_clear_bit(nr, &ndev->vlan_features) + +#define netdev_vlan_features_test_bit(ndev, nr) \ + netdev_features_test_bit(nr, &ndev->vlan_features) + +#define netdev_vlan_features_set_bits(ndev, bits) \ + netdev_features_set_bits(bits, &ndev->vlan_features) + +#define netdev_vlan_features_clear_bits(ndev, bits) \ + netdev_features_clear_bits(bits, &ndev->vlan_features) + +#define netdev_vlan_features_test_bits(ndev, bits) \ + netdev_features_test_bits(bits, &ndev->vlan_features) + +#define netdev_vlan_features_and_bits(ndev, bits) \ + netdev_features_and_bits(bits, &ndev->vlan_features) + +static inline void netdev_set_hw_enc_features(struct net_device *netdev, + netdev_features_t src) { - *addr &= bits; + netdev->hw_enc_features = src; } -static inline int netdev_feature_intersects(const netdev_features_t src1, - const netdev_features_t src2) +static inline netdev_features_t +netdev_get_hw_enc_features(struct net_device *netdev) { - return (src1 & src2) > 0; + return netdev->hw_enc_features; } -static inline int netdev_feature_subset(const netdev_features_t src1, - const netdev_features_t src2) +#define netdev_hw_enc_features_zero(ndev) \ + netdev_features_zero(&ndev->hw_enc_features) + +#define netdev_hw_enc_features_and(ndev, features) \ + netdev_features_and(ndev->hw_enc_features, features) + +#define netdev_hw_enc_features_or(ndev, features) \ + netdev_features_or(ndev->hw_enc_features, features) + +#define netdev_hw_enc_features_xor(ndev, features) \ + netdev_features_xor(ndev->hw_enc_features, features) + +#define netdev_hw_enc_features_andnot(ndev, features) \ + netdev_features_andnot(ndev->hw_enc_features, features) + +#define netdev_hw_enc_features_set_bit(ndev, nr) \ + netdev_features_set_bit(nr, &ndev->hw_enc_features) + +#define netdev_hw_enc_features_clear_bit(ndev, nr) \ + netdev_features_clear_bit(nr, &ndev->hw_enc_features) + +#define netdev_hw_enc_features_test_bit(ndev, nr) \ + netdev_features_test_bit(nr, &ndev->hw_enc_features) + +#define netdev_hw_enc_features_set_bits(ndev, bits) \ + netdev_features_set_bits(bits, &ndev->hw_enc_features) + +#define netdev_hw_enc_features_clear_bits(ndev, bits) \ + netdev_features_clear_bits(bits, &ndev->hw_enc_features) + +#define netdev_hw_enc_features_test_bits(ndev, bits) \ + netdev_features_test_bits(bits, &ndev->hw_enc_features) + +#define netdev_hw_enc_features_and_bits(ndev, bits) \ + netdev_features_and_bits(bits, &ndev->hw_enc_features) + +static inline void netdev_set_mpls_features(struct net_device *netdev, + netdev_features_t src) { - return (src1 & src2) == src2; + netdev->mpls_features = src; } +static inline netdev_features_t +netdev_get_mpls_features(struct net_device *netdev) +{ + return netdev->mpls_features; +} + +#define netdev_mpls_features_zero(ndev) \ + netdev_features_zero(&ndev->mpls_features) + +#define netdev_mpls_features_and(ndev, features) \ + netdev_features_and(ndev->mpls_features, features) + +#define netdev_mpls_features_or(ndev, features) \ + netdev_features_or(ndev->mpls_features, features) + +#define netdev_mpls_features_xor(ndev, features) \ + netdev_features_xor(ndev->mpls_features, features) + +#define netdev_mpls_features_andnot(ndev, features) \ + netdev_features_andnot(ndev->mpls_features, features) + +#define netdev_mpls_features_set_bit(ndev, nr) \ + netdev_features_set_bit(nr, &ndev->mpls_features) + +#define netdev_mpls_features_clear_bit(ndev, nr) \ + netdev_features_clear_bit(nr, &ndev->mpls_features) + +#define netdev_mpls_features_test_bit(ndev, nr) \ + netdev_features_test_bit(nr, &ndev->mpls_features) + +#define netdev_mpls_features_set_bits(ndev, bits) \ + netdev_features_set_bits(bits, &ndev->mpls_features) + +#define netdev_mpls_features_clear_bits(ndev, bits) \ + netdev_features_clear_bits(bits, &ndev->mpls_features) + +#define netdev_mpls_features_test_bits(ndev, bits) \ + netdev_features_test_bits(bits, &ndev->mpls_features) + +#define netdev_mpls_features_and_bits(ndev, bits) \ + netdev_features_and_bits(bits, &ndev->mpls_features) + +static inline void netdev_set_gso_partial_features(struct net_device *netdev, + netdev_features_t src) +{ + netdev->gso_partial_features = src; +} + +static inline netdev_features_t +netdev_get_gso_partial_features(struct net_device *netdev) +{ + return netdev->gso_partial_features; +} + +#define netdev_gso_partial_features_zero(ndev) \ + netdev_features_zero(&ndev->gso_partial_features) + +#define netdev_gso_partial_features_and(ndev, features) \ + netdev_features_and(ndev->gso_partial_features, features) + +#define netdev_gso_partial_features_or(ndev, features) \ + netdev_features_or(ndev->gso_partial_features, features) + +#define netdev_gso_partial_features_xor(ndev, features) \ + netdev_features_xor(ndev->gso_partial_features, features) + +#define netdev_gso_partial_features_andnot(ndev, features) \ + netdev_features_andnot(ndev->gso_partial_features, features) + +#define netdev_gso_partial_features_set_bit(ndev, nr) \ + netdev_features_set_bit(nr, &ndev->gso_partial_features) + +#define netdev_gso_partial_features_clear_bit(ndev, nr) \ + netdev_features_clear_bit(nr, &ndev->gso_partial_features) + +#define netdev_gso_partial_features_test_bit(ndev, nr) \ + netdev_features_test_bit(nr, &ndev->gso_partial_features) + +#define netdev_gso_partial_features_set_bits(ndev, bits) \ + netdev_features_set_bits(bits, &ndev->gso_partial_features) + +#define netdev_gso_partial_features_clear_bits(ndev, bits) \ + netdev_features_clear_bits(bits, &ndev->gso_partial_features) + +#define netdev_gso_partial_features_test_bits(ndev, bits) \ + netdev_features_test_bits(bits, &ndev->gso_partial_features) + +#define netdev_gso_partial_features_and_bits(ndev, bits) \ + netdev_features_and_bits(bits, &ndev->gso_partial_features) + #endif /* _LINUX_NETDEV_FEATURES_H */ diff --git a/net/core/dev.c b/net/core/dev.c index edeb811c454e..58aa2f4789b9 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -1642,10 +1642,10 @@ void dev_disable_lro(struct net_device *dev) struct net_device *lower_dev; struct list_head *iter; - dev->wanted_features &= ~NETIF_F_LRO; + netdev_wanted_features_clear_bit(dev, NETIF_F_LRO_BIT); netdev_update_features(dev); - if (unlikely(dev->features & NETIF_F_LRO)) + if (unlikely(netdev_active_features_test_bits(dev, NETIF_F_LRO_BIT))) netdev_WARN(dev, "failed to disable LRO!\n"); netdev_for_each_lower_dev(dev, lower_dev, iter) @@ -1663,10 +1663,10 @@ EXPORT_SYMBOL(dev_disable_lro); */ static void dev_disable_gro_hw(struct net_device *dev) { - dev->wanted_features &= ~NETIF_F_GRO_HW; + netdev_wanted_features_clear_bit(dev, NETIF_F_GRO_HW_BIT); netdev_update_features(dev); - if (unlikely(dev->features & NETIF_F_GRO_HW)) + if (unlikely(netdev_active_features_test_bits(dev, NETIF_F_GRO_HW_BIT))) netdev_WARN(dev, "failed to disable GRO_HW!\n"); } @@ -3391,13 +3391,17 @@ struct sk_buff *__skb_gso_segment(struct sk_buff *skb, * support segmentation on this frame without needing additional * work. */ - if (features & NETIF_F_GSO_PARTIAL) { - netdev_features_t partial_features = NETIF_F_GSO_ROBUST; + if (netdev_features_test_bit(NETIF_F_GSO_PARTIAL_BIT, features)) { + netdev_features_t partial_features; struct net_device *dev = skb->dev; - partial_features |= dev->features & dev->gso_partial_features; - if (!skb_gso_ok(skb, features | partial_features)) - features &= ~NETIF_F_GSO_PARTIAL; + partial_features = netdev_features_and(dev->features, + dev->gso_partial_features); + netdev_features_set_bit(NETIF_F_GSO_ROBUST_BIT, &partial_features); + if (!skb_gso_ok(skb, + netdev_features_or(features, partial_features))) + netdev_features_clear_bit(NETIF_F_GSO_PARTIAL_BIT, + &features); } BUILD_BUG_ON(SKB_GSO_CB_OFFSET + @@ -3440,7 +3444,7 @@ static int illegal_highdma(struct net_device *dev, struct sk_buff *skb) #ifdef CONFIG_HIGHMEM int i; - if (!(dev->features & NETIF_F_HIGHDMA)) { + if (!netdev_active_features_test_bit(dev, NETIF_F_HIGHDMA_BIT)) { for (i = 0; i < skb_shinfo(skb)->nr_frags; i++) { skb_frag_t *frag = &skb_shinfo(skb)->frags[i]; @@ -3460,8 +3464,11 @@ static netdev_features_t net_mpls_features(struct sk_buff *skb, netdev_features_t features, __be16 type) { - if (eth_p_mpls(type)) - features &= skb->dev->mpls_features; + if (eth_p_mpls(type)) { + netdev_features_t mpls = netdev_get_mpls_features(skb->dev); + + features = netdev_features_and(features, mpls); + } return features; } @@ -3484,10 +3491,11 @@ static netdev_features_t harmonize_features(struct sk_buff *skb, if (skb->ip_summed != CHECKSUM_NONE && !can_checksum_protocol(features, type)) { - features &= ~(NETIF_F_CSUM_MASK | NETIF_F_GSO_MASK); + netdev_features_clear_bits(NETIF_F_CSUM_MASK | NETIF_F_GSO_MASK, + &features); } if (illegal_highdma(skb->dev, skb)) - features &= ~NETIF_F_SG; + netdev_features_clear_bit(NETIF_F_SG_BIT, &features); return features; } @@ -3513,12 +3521,15 @@ static netdev_features_t gso_features_check(const struct sk_buff *skb, { u16 gso_segs = skb_shinfo(skb)->gso_segs; - if (gso_segs > dev->gso_max_segs) - return features & ~NETIF_F_GSO_MASK; + if (gso_segs > dev->gso_max_segs) { + netdev_features_clear_bits(NETIF_F_GSO_MASK, &features); + return features; + } if (!skb_shinfo(skb)->gso_type) { skb_warn_bad_offload(skb); - return features & ~NETIF_F_GSO_MASK; + netdev_features_clear_bits(NETIF_F_GSO_MASK, &features); + return features; } /* Support for GSO partial features requires software @@ -3527,8 +3538,11 @@ static netdev_features_t gso_features_check(const struct sk_buff *skb, * and we can pull them back in after we have partially * segmented the frame. */ - if (!(skb_shinfo(skb)->gso_type & SKB_GSO_PARTIAL)) - features &= ~dev->gso_partial_features; + if (!(skb_shinfo(skb)->gso_type & SKB_GSO_PARTIAL)) { + netdev_features_t gso = netdev_get_gso_partial_features(dev); + + features = netdev_features_andnot(features, gso); + } /* Make sure to clear the IPv4 ID mangling feature if the * IPv4 header has the potential to be fragmented. @@ -3538,7 +3552,8 @@ static netdev_features_t gso_features_check(const struct sk_buff *skb, inner_ip_hdr(skb) : ip_hdr(skb); if (!(iph->frag_off & htons(IP_DF))) - features &= ~NETIF_F_TSO_MANGLEID; + netdev_features_clear_bit(NETIF_F_TSO_MANGLEID_BIT, + &features); } return features; @@ -3547,7 +3562,8 @@ static netdev_features_t gso_features_check(const struct sk_buff *skb, netdev_features_t netif_skb_features(struct sk_buff *skb) { struct net_device *dev = skb->dev; - netdev_features_t features = dev->features; + netdev_features_t features = netdev_get_active_features(dev); + netdev_features_t tmp; if (skb_is_gso(skb)) features = gso_features_check(skb, dev, features); @@ -3557,19 +3573,20 @@ netdev_features_t netif_skb_features(struct sk_buff *skb) * features for the netdev */ if (skb->encapsulation) - features &= dev->hw_enc_features; + features = netdev_hw_enc_features_and(dev, features) if (skb_vlan_tagged(skb)) - features = netdev_intersect_features(features, - dev->vlan_features | - NETIF_F_HW_VLAN_CTAG_TX | - NETIF_F_HW_VLAN_STAG_TX); + tmp = netdev_get_vlan_features(dev); + + netdev_features_set_bits(NETIF_F_HW_VLAN_CTAG_TX | + NETIF_F_HW_VLAN_STAG_TX, &tmp); + features = netdev_intersect_features(features, tmp); if (dev->netdev_ops->ndo_features_check) - features &= dev->netdev_ops->ndo_features_check(skb, dev, - features); + tmp = dev->netdev_ops->ndo_features_check(skb, dev, features); else - features &= dflt_features_check(skb, dev, features); + tmp = dflt_features_check(skb, dev, features); + features = netdev_features_and(features, tmp); return harmonize_features(skb, features); } @@ -3634,13 +3651,14 @@ int skb_csum_hwoffload_help(struct sk_buff *skb, const netdev_features_t features) { if (unlikely(skb_csum_is_sctp(skb))) - return !!(features & NETIF_F_SCTP_CRC) ? 0 : - skb_crc32c_csum_help(skb); + return netdev_features_test_bit(NETIF_F_SCTP_CRC_BIT, features) ? + 0 : skb_crc32c_csum_help(skb); - if (features & NETIF_F_HW_CSUM) + if (netdev_features_test_bit(NETIF_F_HW_CSUM_BIT, features)) return 0; - if (features & (NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM)) { + if (netdev_features_test_bits(NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM, + features)) { switch (skb->csum_offset) { case offsetof(struct tcphdr, check): case offsetof(struct udphdr, check): @@ -9812,17 +9830,17 @@ static void net_set_todo(struct net_device *dev) static netdev_features_t netdev_sync_upper_features(struct net_device *lower, struct net_device *upper, netdev_features_t features) { - netdev_features_t upper_disables = NETIF_F_UPPER_DISABLES; - netdev_features_t feature; + netdev_features_t upper_disables; int feature_bit; + netdev_features_zero(upper_disables); + netdev_features_set_bits(NETIF_F_UPPER_DISABLES, upper_disables); for_each_netdev_feature(upper_disables, feature_bit) { - feature = __NETIF_F_BIT(feature_bit); - if (!(upper->wanted_features & feature) - && (features & feature)) { - netdev_dbg(lower, "Dropping feature %pNF, upper dev %s has it off.\n", - &feature, upper->name); - features &= ~feature; + if (!netdev_wanted_features_test_bit(upper, feature_bit) && + netdev_features_test_bit(feature_bit, features)) { + netdev_dbg(lower, "Dropping feature bit %d, upper dev %s has it off.\n", + feature_bit, upper->name); + netdev_features_clear_bit(feature_bit, &features) } } @@ -9833,20 +9851,21 @@ static void netdev_sync_lower_features(struct net_device *upper, struct net_device *lower, netdev_features_t features) { netdev_features_t upper_disables = NETIF_F_UPPER_DISABLES; - netdev_features_t feature; int feature_bit; + netdev_features_zero(upper_disables); + netdev_features_set_bits(NETIF_F_UPPER_DISABLES, upper_disables); for_each_netdev_feature(upper_disables, feature_bit) { - feature = __NETIF_F_BIT(feature_bit); - if (!(features & feature) && (lower->features & feature)) { - netdev_dbg(upper, "Disabling feature %pNF on lower dev %s.\n", - &feature, lower->name); - lower->wanted_features &= ~feature; + if (!netdev_features_test_bit(feature_bit, features) && + netdev_active_features_test_bit(lower, feature_bit)) { + netdev_dbg(upper, "Disabling feature %d on lower dev %s.\n", + feature_bit, lower->name); + netdev_wanted_features_clear_bit(lower, feature_bit); __netdev_update_features(lower); - if (unlikely(lower->features & feature)) - netdev_WARN(upper, "failed to disable %pNF on %s!\n", - &feature, lower->name); + if (unlikely(netdev_active_features_test_bit(lower, feature_bit)) + netdev_WARN(upper, "failed to disable %d on %s!\n", + feature_bit, lower->name); else netdev_features_change(lower); } -- 2.33.0

3 4

[linuxarm][PATCH v5 0/1] Add new mmap implementation
by Chengchang Tang 27 Oct '21

27 Oct '21

This patch add new mmap implementation for hns RDMA. Changes in v5: ============== - Remove uAPI relative stuff - Remove userspace implementation Chengchang Tang (1): RDMA/hns: Add a new mmap implementation drivers/infiniband/hw/hns/hns_roce_device.h | 24 +++++ drivers/infiniband/hw/hns/hns_roce_main.c | 139 ++++++++++++++++++++++------ include/rdma/ib_verbs.h | 8 ++ 3 files changed, 145 insertions(+), 26 deletions(-) -- 2.9.5

2 2

Re:
by Vany 20 Oct '21

20 Oct '21

Dear Sir/Madam, I am contacting you to know if you are open for Investors into your company or business as we have potential investors who are willing and able to provide financial support to companies, corporate Organizations and private Business Owners for business expansion. We also pay 1% commission to individuals who direct clients to us for financing. Kindly respond accordingly if you have interest for possible corporation. Regards, Vany Ego Email: md.riahimi(a)gmail.com

1 0

[PATCH] Revert "iommu/arm-smmu-v3: Decrease the queue size of evtq and priq"
by Zhou Wang 15 Oct '21

15 Oct '21

The commit f115f3c0d5d8 decreases evtq and priq, which may lead evtq/priq to be full with fault events, e.g HiSilicon ZIP/SEC/HPRE have maximum 1024 queues in one device, every queue could be binded with one process and trigger a fault event. So let's revert f115f3c0d5d8. In fact, if an implementation of SMMU really does not need so long evtq and priq, value of IDR1_EVTQS and IDR1_PRIQS can be set to proper ones. Signed-off-by: Zhou Wang <wangzhou1(a)hisilicon.com> --- drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h index 4cb136f..cd48590 100644 --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h @@ -184,7 +184,6 @@ #else #define Q_MAX_SZ_SHIFT (PAGE_SHIFT + MAX_ORDER - 1) #endif -#define Q_MIN_SZ_SHIFT (PAGE_SHIFT) /* * Stream table. @@ -374,7 +373,7 @@ /* Event queue */ #define EVTQ_ENT_SZ_SHIFT 5 #define EVTQ_ENT_DWORDS ((1 << EVTQ_ENT_SZ_SHIFT) >> 3) -#define EVTQ_MAX_SZ_SHIFT (Q_MIN_SZ_SHIFT - EVTQ_ENT_SZ_SHIFT) +#define EVTQ_MAX_SZ_SHIFT (Q_MAX_SZ_SHIFT - EVTQ_ENT_SZ_SHIFT) #define EVTQ_0_ID GENMASK_ULL(7, 0) @@ -400,7 +399,7 @@ /* PRI queue */ #define PRIQ_ENT_SZ_SHIFT 4 #define PRIQ_ENT_DWORDS ((1 << PRIQ_ENT_SZ_SHIFT) >> 3) -#define PRIQ_MAX_SZ_SHIFT (Q_MIN_SZ_SHIFT - PRIQ_ENT_SZ_SHIFT) +#define PRIQ_MAX_SZ_SHIFT (Q_MAX_SZ_SHIFT - PRIQ_ENT_SZ_SHIFT) #define PRIQ_0_SID GENMASK_ULL(31, 0) #define PRIQ_0_SSID GENMASK_ULL(51, 32) -- 2.8.1

1 0

[PATCH net-next -v5 0/4] some optimization for page pool
by Yunsheng Lin 12 Oct '21

12 Oct '21

Patch 1: disable dma mapping support for 32-bit arch with 64-bit DMA. Patch 2 - 4: pp page frag tracking support The small packet drop test show no notiable performance degradation when page pool is disabled. V5: Keep the put_page()/get_page() semantics. V4: 1. Change error code to EOPNOTSUPP in patch 1. 2. Drop patch 2. 3. Use pp_frag_count to indicate if a pp page can be tracked, to avoid breaking the mlx5 driver. V3: 1. add patch 1/4/6/7. 2. use pp_magic to identify pp page uniquely too. 3. avoid unnecessary compound_head() calling. V2: add patch 2, adjust the commit log accroding to the discussion in V1, and fix a compiler error reported by kernel test robot. Yunsheng Lin (4): page_pool: disable dma mapping support for 32-bit arch with 64-bit DMA page_pool: change BIAS_MAX to support incrementing mm: introduce __get_page() and __put_page() skbuff: keep track of pp page when pp_frag_count is used include/linux/mm.h | 21 ++++++++++++++------- include/linux/mm_types.h | 13 +------------ include/linux/skbuff.h | 30 ++++++++++++++++++++---------- include/net/page_pool.h | 36 ++++++++++++++++++++++++------------ mm/swap.c | 6 +++--- net/core/page_pool.c | 29 +++++++++-------------------- net/core/skbuff.c | 10 ++++++++-- 7 files changed, 79 insertions(+), 66 deletions(-) -- 2.33.0

6 13

[linuxarm] [PATCH v4 0/1] RDMA/hns: Add new mmap implementation
by Chengchang Tang 09 Oct '21

09 Oct '21

This patch add a new mmap implementaion for hns, subsequent new mmap types will be implemented using this method. Changes in v4: ============== - Replace rdma_user_mmap_entry with hns_user_mmap_entry. - Use rdma_user_mmap_entry_insert_range() to achieve compatibility with legacy mode and always keep the mmap routine in new mode. Chengchang Tang (1): RDMA/hns: Add a new mmap implementation drivers/infiniband/hw/hns/hns_roce_device.h | 23 ++++ drivers/infiniband/hw/hns/hns_roce_main.c | 196 ++++++++++++++++++++++++---- include/uapi/rdma/hns-abi.h | 21 ++- 3 files changed, 213 insertions(+), 27 deletions(-) -- 2.9.5

1 1

[PATCH] rasdaemon: Fix the issue of sprintf data type mismatch in uuid_le()
by Xiaofei Tan 08 Oct '21

08 Oct '21

The data type of sprintf called in the function uuid_le() is not mismatch. Arm64 compiler force it to unsigned char by default, and can work normally. But if someone compile it with the option -fsigned-char, the function can't work correctly. Signed-off-by: Xiaofei Tan <tanxiaofei(a)huawei.com> --- ras-extlog-handler.c | 2 +- ras-non-standard-handler.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ras-extlog-handler.c b/ras-extlog-handler.c index 5fd3580..1834687 100644 --- a/ras-extlog-handler.c +++ b/ras-extlog-handler.c @@ -152,7 +152,7 @@ static char *uuid_le(const char *uu) static const unsigned char le[16] = {3,2,1,0,5,4,7,6,8,9,10,11,12,13,14,15}; for (i = 0; i < 16; i++) { - p += sprintf(p, "%.2x", uu[le[i]]); + p += sprintf(p, "%.2x", (unsigned char) uu[le[i]]); switch (i) { case 3: case 5: diff --git a/ras-non-standard-handler.c b/ras-non-standard-handler.c index 6ccf5bc..879f394 100644 --- a/ras-non-standard-handler.c +++ b/ras-non-standard-handler.c @@ -36,7 +36,7 @@ static char *uuid_le(const char *uu) static const unsigned char le[16] = {3,2,1,0,5,4,7,6,8,9,10,11,12,13,14,15}; for (i = 0; i < 16; i++) { - p += sprintf(p, "%.2x", uu[le[i]]); + p += sprintf(p, "%.2x", (unsigned char) uu[le[i]]); switch (i) { case 3: case 5: -- 2.33.0

1 0

[PATCH net-next v4 0/3] some optimization for page pool
by Yunsheng Lin 05 Oct '21

05 Oct '21

Patch 1: disable dma mapping support for 32-bit arch with 64-bit DMA. Patch 2 & 3: pp page frag tracking support The small packet drop test show no notiable performance degradation when page pool is disabled. V4: 1. Change error code to EOPNOTSUPP in patch 1. 2. Drop patch 2. 3. Use pp_frag_count to indicate if a pp page can be tracked, to avoid breaking the mlx5 driver. V3: 1. add patch 1/4/6/7. 2. use pp_magic to identify pp page uniquely too. 3. avoid unnecessary compound_head() calling. V2: add patch 2, adjust the commit log accroding to the discussion in V1, and fix a compiler error reported by kernel test robot. Yunsheng Lin (3): page_pool: disable dma mapping support for 32-bit arch with 64-bit DMA page_pool: change BIAS_MAX to support incrementing skbuff: keep track of pp page when pp_frag_count is used include/linux/mm_types.h | 13 +------------ include/linux/skbuff.h | 30 ++++++++++++++++++++---------- include/net/page_pool.h | 36 ++++++++++++++++++++++++------------ net/core/page_pool.c | 29 +++++++++-------------------- net/core/skbuff.c | 10 ++++++++-- 5 files changed, 62 insertions(+), 56 deletions(-) -- 2.33.0

3 6

Greetings dear
by MRS HANNAH VANDRAD 04 Oct '21

04 Oct '21

Greetings dear This letter might be a surprise to you, But I believe that you will be honest to fulfill my final wish. I bring peace and love to you. It is by the grace of god, I had no choice than to do what is lawful and right in the sight of God for eternal life and in the sight of man for witness of god’s mercy and glory upon my life. My dear, I sent this mail praying it will find you in a good condition, since I myself am in a very critical health condition in which I sleep every night without knowing if I may be alive to see the next day. I am Mrs.Hannah Vandrad, a widow suffering from a long time illness. I have some funds I inherited from my late husband, the sum of ( Eleven Million Dollars) my Doctor told me recently that I have serious sickness which is a cancer problem. What disturbs me most is my stroke sickness. Having known my condition, I decided to donate this fund to a good person that will utilize it the way I am going to instruct herein. I need a very honest and God fearing person who can claim this money and use it for Charity works, for orphanages and gives justice and help to the poor, needy and widows says The Lord." Jeremiah 22:15-16.“ and also build schools for less privilege that will be named after my late husband if possible and to promote the word of god and the effort that the house of god is maintained. I do not want a situation where this money will be used in an ungodly manner. That's why I'm taking this decision. I'm not afraid of death, so I know where I'm going. I accept this decision because I do not have any child who will inherit this money after I die. Please I want your sincere and urgent answer to know if you will be able to execute this project, and I will give you more information on how the fund will be transferred to your bank account. May the grace, peace, love and the truth in the Word of god be with you and all those that you love and care for. I am waiting for your reply. May God Bless you, Mrs. Hannah Vandrad.

1 0

Hi
by Grace Johnson 30 Sep '21

30 Sep '21

How are you doing? I want to share a message that has been spreading all over the internet that concerns the times we are living in. Whether you believe in God or not, this is a must read message! We can see throughout time how we have been slowly conditioned to come to this point where we are on the verge of a cashless society. Would it surprise you to know that the Bible foretold of this event? Don't believe me? This may be the most imporant message you will read in these times...please do not ignore this! This messsage reveals what the Mark of the Beast is, and the meaning behind counting a number people have been pondering for centuries, 666. This message also shares why Barack Obama is the Antichrist as well as the gospel message. This is truly a message from God! In the Revelation of Jesus Christ given to the apostle John, we read: ...."And he (the false prophet who deceives many by his miracles) causeth all, both small and great, rich and poor, free and bond, to receive a mark in their right hand, or in their foreheads: And that no man might buy or sell, save he that had the mark, or the name of the beast, or the number of his name. Here is wisdom. Let him that hath understanding count the number of the beast: for it is the number of a man; and his number is Six hundred threescore and six" (Revelation 13:16-18 BRG)..... Referring to the last generation, this could only be speaking of a cashless society. Why? Revelation 13:17 tells us that we cannot buy or sell unless we receive the mark of the beast. If physical money was still in use, we could buy or sell with one another without receiving the mark. This would contradict scripture. So, it deduces itself to this conclusion. These verses could not be referring to something spiritual as scripture references two physical locations (our right-hand or forehead) stating the mark will be on one "OR" the other. It once again deduces itself to this conclusion. Also, how could you determine who truly has a spiritual mark so that they may buy or sell? And, as you will read further in this message, to have the mark of the beast is the same to have the name of the beast, and the number of its name. You will begin to see even more clearly why this mark cannot be something purely spiritual. Here is where it really starts to come together. It is shocking how accurate the Bible is concerning the RFID microchip. These are notes from a man named Carl Sanders who worked with a team of engineers to help develop this microchip in the late 1960's. Carl Sanders attended 17 New World Order meetings with heads-of-state officials such as Henry Kissinger and Bob Gates of the CIA to talk about plans on how to bring forth this one-world system. The US government commissioned Carl Sanders to design a microchip for identifying and controlling the peoples of the nations-a microchip that could be inserted under the skin with a hypodermic needle (a quick, convenient procedure that would be gradually accepted by the people). Carl Sanders, along with a team of engineers with him, with U.S. grant monies supplied by tax dollars, took on this mission and designed a microchip which is powered by a lithium battery, rechargeable with the aid of the temperature changes in our skin. With out the knowledge of the holy Bible (Mr. Sanders was not a Christian at the time), these engineers spent one and a half million dollars gathering information on the best and most convenient spot to have the microchip placed under the skin. These researchers found that the forehead and the back of the hand (the two spots Revelation says the mark will be received) aren't just the most convenient places, however are also the only viable spots for constant, consistent temperature changes in the skin to recharge the lithium battery. The microchip is about 7 millimeters in length, .75 millimeters in diameter, about the size of a grain of rice. It is capable of containing many pages of data about you. All your basic information, work information, crime history, health history, and financial history could be stored on this chip. Carl Sanders believes that this microchip, which he remorsefully helped engineer, is the "beast's mark" spoke of in Revelation 13:16-18. The original Greek word for "mark" is "charagma," which means a "scratch or etching." Additionally it is fascinating to note that the number 666 is actually a word in the original Greek language. That word is "chi xi stigma," with the final word, "stigma," also meaning "to stick or prick. Mr. Sanders believes that is referring to the usage of a hypodermic needle being poked into the human flesh to insert the microchip." Mr. Sanders asked a Boston Medical Center doctor what would happen if the lithium contained within the RFID microchip leaked into the body. The doctor responded that if the microchip broke inside a human body, the lithium would cause a severe and painful wound filled with pus. This is what the book of Revelation says: "And the first (angel) went, and poured out his bowl into the earth; and it became a noisome and grievous sore upon the men that had the mark of the beast, and that worshipped his image" (Revelation 16:2 ASV). THE HIDDEN MEANING BEHIND THE NUMBER 666 REVEALED! What I first want to mention, before I share what the Holy Spirit has revealed to me concerning the number of the beast, is that God confirms in threes. We can see this throughout scripture: "For there are three that bear witness in heaven: the Father, the Word, and the Holy Spirit; and these three are one" (1 John 5:7 NKJV). "and that He was buried, and that He rose again the third day according to the Scriptures" (1 Corinthians 15:4 NKJV). "...Holy, holy, holy, Lord God Almighty, Who was and is and is to come!" (Revelation 4:8 NKJV). There are many more examples, but I thought I would just share three of them to make the point. Examining Revelation 13:16,17,18, the first group of three I would like to point out is that the mark of the beast is described in three separate verses, 16, 17 and 18. The next three I see is in verse 16, "He causes all..." is followed by three contrasting categories of people, 1 - "both small and great, 2 - rich and poor, 3 - free and slave...". Then unto verse 17, it opens with, "and that no one may buy or sell except one who has...", followed by three explanations of what one must have to buy or sell, 1 - "...the mark 2 - or the name of the beast, 3 - or the number of his name". Now unto verse 18, we read "Let him who has understanding calculate...", which is followed by, 1 - "the number of the beast, 2 - for it is the number of a man: 3 - His number is 666". The last three I see is the number "6" being used three times in a row. The reason I'm making this point about God confirming in three is because it is the key to unlocking how to calculate the number 666. Throughout the centuries there have been people trying to calculate numbers based on titles and names that come up to the number 666 to identify one person, the Antichrist; but from Revelation 13:18, I do not see where God is telling us to count up to 666, but rather to count the number of the beast. This number is identified as 666. So the verse is telling us to count the number 666. What does it mean to count? It means to add up. So how could we add up 666? Remember my previous point about God confirming in threes is key to unlocking the number 666. So logically, what would be the best way to count the number 666? To count it equally by using the rule of three based off the number. We cannot count it equally as 600+60+6, this would also bring us back to the start. We cannot count it as 600+600+600, or 60+60+60 because there are no zeroes in between or at the end of 666. The only logical option is 6+6+6=18. What is interesting is that the verse that reveals for us to count the number itself is verse 18 (there a total of 18 verses in Revelation Chapter 13), being the third verse out of the three verses that describe the mark of the beast in Revelation 13:16,17,18. What is 18 divided by 3? 6. So 3x6=18, or 6+6+6=18. Another interesting point is the only two other combinations (making a total of three possible combinations) for placing a "+" symbol in between 666 are: • 66+6=72 and 6+66=72. • Add both 72's together and you get 144. Why the number 144 is worth our attention is because the verse following Revelation 13:18 is the first time in the Bible where the 144,000 are being described in detail: "Then I looked, and behold, a Lamb standing on Mount Zion, and with Him one hundred and forty-four thousand, having His Father’s name written on their foreheads..." (Revelation 14:1). Now if you add up all three numbers from counting 666 by moving the "+" symbol around, it would be 72+72+18=162. What is compelling about the number 162, is, if you divide 144,000 by 162, you get 888. The name of Jesus in Greek gematria adds up to 888. The New Testament was originally written in the Greek language. Revelation 14:1 not only mentions the 144,000, but also the Lamb who is Jesus. Now what is interesting about the number for Jesus, 888, is that if you apply the same formula that was used to count 666, you get 8+8+8=24. Why the number 24? Revelation chapter 4 tells us there are 24 elders seated around the throne of God. This is the same throne where Jesus sits. Now if you take: • 8+8+8=24 • 8+88=96 • 88+8=96 you get 24+96+96=216. Take 144,000 divided by 216 and you get 666. Remember that this was the same exact formula we used to count the number 666 that ultimately brought forth the number 888. Here is a quick recap to demonstrate how this formula confirms itself as being the true way to count 666: 1: 6+6+6=18 » 66+6=72 » 6+66=72 » 18+72+72=162 2: 144,000 divided by 162=888 3: 8+8+8=24 » 88+8=96 » 8+88=96 » 24+96+96=216 4: 144,000 divided by 216=666 1: 6+6+6=18 » 66+6=72... As you can see, it is perpetual. And remember that we consistently used a formula that worked in threes being the number that God uses for confirmation. By utilizing the same formulation of counting by including the plus symbol in between the numbers, why do all these numbers relate in such a manner? The book of Revelation contains the use of the number 7 in various forms. For instance 7 seals, 7 trumpets, and 7 bowls. What is interesting about the number 37 (three sevens) is if if you divide any number that contains the same single digit three times in a row, such as 111 to 999, it comes out to the value of if you were to add all three numbers up. For example 888 divided by 37 equals 24. So 8+8+8=24. Or 666 divided by 37 equals 18. So 6+6+6=18. Could this be another way of God's word confirming itself that the mystery behind calculating the number 666 indeed is 18? Another fascinating factor to note is that if you add up all the numbers from 1 to 36 (1+2+3...+36), it totals 666. The number 36, as in three sixes? May this be a hint that we need to add up three sixes as opposed to perceiving the number as six-hundred sixty six? So what may this suggest? We know in this world we are identified by numbers in numerous forms. Starting from our birth certificate to our social security card, also with our drivers license, being identified based on a system of ruler ship. So it's possible that this RFID microchip will contain a brand new identification that has a total of 18 characters. "here the wisdom is, the one having the mind let him calculate the number of the wild beast, number for "of human" it is, and the number of it 666" (Revelation 13:1, Greek Translation). The Greek word "anthrōpos" being used in verse 18 where it says "of human" is the Greek strongs concordance G444. The first two definitions of the word are "a human being, whether male or female", and, "generically, to include all human individuals". Could the number of the beast apply to all mankind? In the Greek (the New Testament was originally written in the Greek language), and other translations, you will notice the beast is described as an "it", instead of "him". The reason I'm making this point is because when a translation says "His number is 666", this would imply a singular person, the Antichrist. But by saying "the number of it 666", implies that it is of the beast system as a whole. We can know the number of the beast cannot be to identify products (like a new barcode) to buy or sell because scripture says we cannot buy or sell without the number of the beast. What am I getting at? There will be instances where you could buy something someone made themselves and it wouldn't have a store branded identification on it. But for this number to be in our chips, that is where it must be to conclude ultimately that we cannot buy or sell without having the number of the beast. As previously mentioned in Revelation 13:18, the number of the beast (6+6+6=18) is a "human number", definition "generically, to include all human individuals". May this be the identification of the beast, the number of its name? The one-world beast system which is identified by 18 characters? This might fit the scriptures that speaks of a mark that we ought to have to buy or sell in our right-hand or forehead, and that it also incorporates the number of the beast, during a future cashless money society. Here is another mathematical confirmation: 144,000 divided by 6, divided by 6, divided by 6 (6,6,6) equals 666. To see many more of these amazing calculations, read the article about the RFID Mark of the Beast and the number 666... Do we believe blind forces gave us eyes to see? That deaf forces gave us ears to hear? That careless forces gave us a heart to care for others? That faithless forces uphold the universe and all the laws that govern it and that is why we should trust them? That mindless forces gave us a mind to think and comprehend these things? If there is a God, He must be personal, because we as His creation are personal beings. How do we get to personally know anybody? By their word...The words of Jesus have been translated into over 2,000 languages, and nothing comes remotely close (the Quran about 110). If that is not God's word, nothing is. Why? Why would a personal loving God who desires for us to know Him, who is all powerful, allow man to create a word far surperior than His to be spread around the world throughout time in so many different languages to deceive the world so we may not know the truth about Him? God has shown me some time ago that Trump will have a second term (he will be back soon!), and that this will be the time where the two witnesses of Revelation 11 will rise up (who are the 144,000) to prophesy for 42 months to every tribe, tongue, nation and people before the beast rises from the sea in Revelation 13. We will see His Holy Spirit move across the world in a mighty way bringing a great multitude to God. God gave me a vision that Obama will be back in 2024. To see much more, go to: http://go.bible-woke.org [http://k12-us-teachers.live/index.php/campaigns/[CAMPAIGN_UID/track-url/xy1… [http://k12-us-teachers.live/index.php/campaigns/fy214lwwf4d70/track-url/xy1… [http://k12-us-teachers.live/index.php/campaigns/fy214lwwf4d70/track-url/xy1… [http://k12-us-teachers.live/index.php/campaigns/fy214lwwf4d70/track-url/xy1… [http://k12-us-teachers.live/index.php/campaigns/fy214lwwf4d70/track-url/xy1… [http://k12-us-teachers.live/index.php/campaigns/fy214lwwf4d70/track-url/xy1… [http://k12-us-teachers.live/index.php/campaigns/fy214lwwf4d70/track-url/xy1… [http://k12-us-teachers.live/index.php/campaigns/fy214lwwf4d70/track-url/xy1… [http://k12-us-teachers.live/index.php/campaigns/fy214lwwf4d70/track-url/xy1…]] to see all the proof! If you feel led to, please forward this email to your friends and family so they may know that God is moving in these times in mighty ways, even through His prophets to proclaim the truth of His word to the ends of the earth. God bless! "Why did the Biden campaign choose 30330? 2020 divided by 666 = 3.0330 Who believes this to be a coincidence? October 2020 Isaiah 53:6 Someone said we are being whipsawed in 2020. Truly a great division is taking place between good and evil—both symbolically and literally (riots, unrest, politics). If you take the current year 2020 and divide it by the number 666 (known for its satanic implications) you will get the number 30330 (repeated). This number 30330 happens to be the number used to vote for Joe Biden and Kamala Harris. Freaky? Supernatural? Odd for sure. Whatever this means, it doesn’t seem good to me. First, why would anyone knowingly choose those particular numbers for their campaign? If they weren’t knowingly chosen, then it appears to be a supernatural act by the evil one himself and I would want to change those numbers ASAP. And if the numbers were chosen knowing their significance, are you satanic? Is this campaign satanic? Either way I do not believe this is a coincidence. And one thing is certain, 2020 is truly being divided by Satan. He is the master deceiver and spreader of chaos. Jesus calls him the father of lies." So I looked up this number 30330 concerning Joe Biden, and I found this information: If you send a text to that number (at that time), you would get a response asking to support Joe's campaign to take down Donald Trump, with one part in caps saying "CHIP IN >>" pointing to a link to go and donate. "CHIP IN"? Obama has used this phrase in the past on his twitter and people believe it is a subliminal message to receive the mark of the beast, that is to say the implantable RFID microCHIP that will go IN our body. God's word warns us in the end times that a false prophet will stand up doing miraculous signs to deceive many to acquire the beasts mark: ...."And the beast was taken, and with him the false prophet that wrought the signs in his sight, wherewith he deceived them that had received the mark of the beast and them that worshipped his image: they two were cast alive into the lake of fire that burneth with brimstone" (Revelation 19:20 ASV).... At all costs, DO NOT TAKE IT! "Then a third angel followed them, saying with a loud voice, "If anyone worships the beast and his image, and receives his mark on his forehead or on his hand, he himself shall also drink of the wine of the wrath of God, which is poured out full strength into the cup of His indignation. He shall be tormented with fire and brimstone in the presence of the holy angels and in the presence of the Lamb. And the smoke of their torment ascends forever and ever; and they have no rest day or night, who worship the beast and his image, and whoever receives the mark of his name" (Revelation 14:9-11). We're living in very prophetic times with major Biblical prophecies coming to pass. When Donald Trump recognized Jerusalem as capital of Israel on December 6 2017, this was a big step to bring forth the Third Temple prophesied in the Bible. God's Holy scriptures tells us that the Antichrist will seat himself in this temple: "...and the man of sin is revealed, the son of perdition, who opposes and exalts himself above all that is called God or that is worshiped, so that he sits as God in the temple of God, showing himself that he is God" (2 Thessalonians 2:3-4). Within the Islamic faith, there is a figure called the Mahdi, referred to as their messiah who they're awaiting to appear. There are many testimonies from individuals on line who consider this man will be Barack Obama who may be the biblical Antichrist. I myself have had unusual dreams (you can read them in my article on the website above) concerning Barack. He came on stage claiming to be a follower of Christ with no affiliation to the Muslim religion, however it was later revealed by his circle of relatives that he indeed is a religious Muslim. So what's in the name? The meaning of someones name can say a lot about a person. God throughout history has given names to people that have a specific meaning tied to their lives. How about the name Barack Obama? Let us take a look at what may be hiding beneath the surface... Jesus says, "And He said to them, 'I saw Satan fall like lightning from heaven'" (Luke 10:18). In Hebrew, the word "Barack" means "lighting", and the use of "Bama" (Strongs Hebrew word 1116) is used to mean the "heights" of heaven. The day after the election of Barack Obama (11/04/08), the triumphing pick three lotto numbers in Illinois (Obama’s home state) for 11/5/08 were 666. Obama was a U.S. senator for Illinois, and his zip code was 60606. The names of both of Obama's daughters are Malia and Natasha. If we were to write those names backwards we would get "ailam ahsatan". Now if we remove the letters that spell "Alah" (Allah being the God of Islam), we get "I am Satan". Coincidence? I don't think so. These are just a few of many evidences why Barack Obama is the Antichrist. You can see many more in my article on the website above, as well as read about the dreams I've had concerning this man. I'm more than convinced that God has shown me that he is without a doubt the Antichrist, and we will see him rise to power in the not so dinstant future. Why do we need Jesus? "for all have sinned and fall short of the glory of God" (Romans 2:23). "For the wages of sin is death, but the gift of God is eternal life in Christ Jesus our Lord" (Romans 6:23). Our good works cannot save our souls. If we step in front of a judge, being responsible for committing a crime, the judge is not going to judge us by the good that we have accomplished, rather the crimes we have committed. If we as fallen humanity, created in God's image, pose this type of justice, how much more a perfect, righteous, and Holy God? God has introduced to us His moral law's by the ten commandments handed to Moses at Mt. Siani. These legal guidelines were not given so we can be justified, but in order that we might see the need for our saviour. They're the mirror of God's character of what He has put in each and every one of us, with our conscious bearing witness that we know that it's wrong to steal, lie, dishonor our mother and father, and so on. We may attempt to follow all the moral laws of the ten commandments, but we will never catch up to them to be justified before a Holy God. That same word of the law received by Moses was brought forth as flesh over 2000 years ago in the body of Jesus Christ. He came to be our justification by perfectly fulfilling the commandments of God, living a sinless life that solely God may accomplish. The distance between us and the law of God can never be reconciled by our own merit, however the arm of Jesus is stretched out by the grace and mercy of God. And if we are to grab on, by faith in Him, He'll pull us forward being the one to justify us. As in the court of law, if someone steps in and pays your debt, despite the fact that you're guilty, the judge can do what is legal and just and set you free. That is what Jesus did almost 2000 years ago on the cross. It was a legal transaction being fulfilled in the spiritual realm by the shedding of His blood, with His last words being, "...It is finished!..." (John 19:30). So why did Jesus have to die for us? Because God is Holy and just, the wrath that we deserve could not be overlooked. Through the perfect righteousness and justice of God's character, it ought to be reconciled, it ought to be quenched and satisfied. For God takes no pleasure in the demise of the wicked (Ezekiel 18:23). That is why in Isaiah chapter 53, where it speaks of the coming Messiah and His soul being a sacrifice for our sins, why it says it pleased God to crush His only begotten Son. That is because the wrath that we deserve was justified by being poured out upon His Son. For if it was poured out upon us who have earned it, we'd all die and go to hell. God created a means of escape by pouring it out on His Son who's soul could not be left in Hades, but was raised and seated at the right hand of God in power. Now after we put on the Lord Jesus Christ (Romans 13:14), God no longer see's the person who deserves His wrath, but the glorious image of His perfect Son dwelling in us, justifying us as if we acquired the wrath we deserve, making a means of escape from the curse of death. Now what we ought to do is repent and believe in the saviour, confessing and turning from our sins. That is not just a head knowledge of believing in Jesus, but rather receiving His words, taking them to heart. Where we no longer live to practice sin, but turn from our sins and practice righteousness: "Do you not know that the unrighteous will not inherit the kingdom of God? Do not be deceived. Neither fornicators, nor idolaters, nor adulterers, nor homosexuals, nor sodomites, nor thieves, nor covetous, nor drunkards, nor revilers, nor extortioners will inherit the kingdom of God. And such were some of you. But you were washed, but you were sanctified, but you were justified in the name of the Lord Jesus and by the Spirit of our God" (1 Corinthians 6:9-11). By doing so we will become transformed into the image of God by faith in His Son Christ Jesus Who's willing to give the Holy Spirit to those that ask of Him: "Most assuredly, I (Jesus) say to you, unless one is born of water and the Spirit, he cannot enter the kingdom of God. That which is born of the flesh is flesh, and that which is born of the Spirit is spirit. Do not marvel that I said to you, 'You must be born again.' (John 3:5-6). "But you are not in the flesh but in the Spirit, if indeed the Spirit of God dwells in you. Now if anyone does not have the Spirit of Christ, he is not His" (Romans 8:9). What are you waiting for? Our Father in heaven only wants the best for us all, restoring all the pieces this world has stolen from us. That is what it means to be "holy". To be made whole. He's waiting to listen to you. That God given tongue to speak language, by way of faith, pray to Him, ask Him to forgive you by confessing to Him your sins and be willing to forsake them; that you accept the sacrifice of His Son Jesus on the cross, and that you want His Holy Spirit living inside you transforming you into a child of God. Jesus says, "but whoever drinks of the water that I shall give him (the Holy Spirit) will never thirst. But the water that I shall give him will become in him a fountain of water springing up into everlasting life." Did you realize that Jesus spoke more about hell than any one in God's holy word, even more than He spoke about heaven?! For this very purpose He came to die for us, to save us from this place that we earned by our sins against a holy God. He describes hell as a real place where, "Their worm does not die And the fire is not quenched" (Mark 9:44). And where, "There will be weeping and gnashing of teeth..." (Luke 13:28). Jesus tells us who to fear, "And do not fear those who kill the body but cannot kill the soul. But rather fear Him who is able to destroy both soul and body in hell" (Matthew 10:28). "Now I saw a new heaven and a new earth, for the first heaven and the first earth had passed away. Also there was no more sea. Then I, John, saw the holy city, New Jerusalem, coming down out of heaven from God, prepared as a bride adorned for her husband. And I heard a loud voice from heaven saying, 'Behold, the tabernacle of God is with men, and He will dwell with them, and they shall be His people. God Himself will be with them and be their God. And God will wipe away every tear from their eyes; there shall be no more death, nor sorrow, nor crying. There shall be no more pain, for the former things have passed away.' Then He who sat on the throne said, 'Behold, I make all things new.' And He said to me, 'Write, for these words are true and faithful.' And He said to me, 'It is done! I am the Alpha and the Omega, the Beginning and the End. I will give of the fountain of the water of life freely to him who thirsts. He who overcomes shall inherit all things, and I will be his God and he shall be My son. But the cowardly, unbelieving, abominable, murderers, sexually immoral, sorcerers, idolaters, and all liars shall have their part in the lake which burns with fire and brimstone, which is the second death.'" (Revelation 21:1-8).

1 0