Hi John, Do you have any suggestion about patch 4 and patch 5? 在 2021/12/24 14:07, chenxiang 写道:
From: Xiang Chen <chenxiang66@hisilicon.com>
There are some small fixes related to scsi and libsas: - Use void for sas_discover_event() return code; - Remove duplicatted setting fro task->task_state_flags; - Remove unused parameter for function sas_ata_eh(); - Use spin_lock/unlock instead of spin_lock/unlock_irq or spin_lock_irqsave /spin_unlock_irqrestore for asd_sas_port->dev_list_lock and sas_ha->phy_port_lock; - Remove unused member cmd_pool for structure scsi_host_template; - Remove unnecessary memset for scsilun;
Xiang Chen (7): {topost} scsi: libsas: Use void for sas_discover_event() return code {topost} scsi: libsas: Remove duplicated setting for task->task_state_flags {topost} scsi: libsas: Remove unused parameter for function sas_ata_eh() {topost} scsi: libsas: Use spin_lock/unlock() for asd_sas_port->dev_list_lock {topost} scsi: libsas: Use spin_lock/unlock() for sas_ha->phy_port_lock {topost} scsi: Remove unused member cmd_pool for structure scsi_host_template {topost} scsi: Remove unnecssary memset for scsilun
drivers/scsi/libsas/sas_ata.c | 8 +++----- drivers/scsi/libsas/sas_discover.c | 26 ++++++++++++-------------- drivers/scsi/libsas/sas_expander.c | 12 ++++++------ drivers/scsi/libsas/sas_port.c | 12 +++++------- drivers/scsi/libsas/sas_scsi_host.c | 12 +++++------- drivers/scsi/scsi_common.c | 2 -- include/scsi/libsas.h | 2 +- include/scsi/sas_ata.h | 6 ++---- include/scsi/scsi_host.h | 3 --- 9 files changed, 34 insertions(+), 49 deletions(-)