Re: [PATCH v3] iommu/iova: put free_iova_mem() outside of spinlock iova_rbtree_lock
On Mon, Apr 19, 2021 at 03:13:35PM +0800, chenxiang wrote:
From: Xiang Chen <chenxiang66@hisilicon.com>
It is not necessary to put free_iova_mem() inside of spinlock/unlock iova_rbtree_lock which only leads to more completion for the spinlock. It has a small promote on the performance after the change. And also rename private_free_iova() as remove_iova() because the function will not free iova after that change.
Signed-off-by: Xiang Chen <chenxiang66@hisilicon.com> --- drivers/iommu/iova.c | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-)
Looks good to me, but I'll wait for Robins opinion before applying.
Hi Joerg, 在 2021/5/18 17:08, Joerg Roedel 写道:
On Mon, Apr 19, 2021 at 03:13:35PM +0800, chenxiang wrote:
From: Xiang Chen <chenxiang66@hisilicon.com>
It is not necessary to put free_iova_mem() inside of spinlock/unlock iova_rbtree_lock which only leads to more completion for the spinlock. It has a small promote on the performance after the change. And also rename private_free_iova() as remove_iova() because the function will not free iova after that change.
Signed-off-by: Xiang Chen <chenxiang66@hisilicon.com> --- drivers/iommu/iova.c | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) Looks good to me, but I'll wait for Robins opinion before applying.
I have re-sent v3, and Robin has given his acked-by: https://www.mail-archive.com/iommu@lists.linux-foundation.org/msg50950.html
.
On 2021-05-18 10:08, Joerg Roedel wrote:
On Mon, Apr 19, 2021 at 03:13:35PM +0800, chenxiang wrote:
From: Xiang Chen <chenxiang66@hisilicon.com>
It is not necessary to put free_iova_mem() inside of spinlock/unlock iova_rbtree_lock which only leads to more completion for the spinlock. It has a small promote on the performance after the change. And also rename private_free_iova() as remove_iova() because the function will not free iova after that change.
Signed-off-by: Xiang Chen <chenxiang66@hisilicon.com> --- drivers/iommu/iova.c | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-)
Looks good to me, but I'll wait for Robins opinion before applying.
Go ahead - I acked the resend[1] :) Thanks, Robin. [1] https://lore.kernel.org/linux-iommu/9edc6849-f9ff-f6fc-30a0-8bb2e8d3bd0d@arm...
On Tue, May 18, 2021 at 11:08:47AM +0200, Joerg Roedel wrote:
Looks good to me, but I'll wait for Robins opinion before applying.
Nevermind, just found the new version which Robin already acked.
participants (3)
-
chenxiang (M) -
Joerg Roedel -
Robin Murphy