[PATCH] i2c: mlxbf: Remove the unneeded devm_free_irq
Use devm_request_irq to request interrupts,devm_free_irq is not needed to release interrupts. so just remove it. Signed-off-by: Tian Tao <tiantao6@hisilicon.com> --- drivers/i2c/busses/i2c-mlxbf.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-mlxbf.c b/drivers/i2c/busses/i2c-mlxbf.c index 2fb0532..ea839de 100644 --- a/drivers/i2c/busses/i2c-mlxbf.c +++ b/drivers/i2c/busses/i2c-mlxbf.c @@ -2426,8 +2426,6 @@ static int mlxbf_i2c_remove(struct platform_device *pdev) } mutex_unlock(&mlxbf_i2c_bus_lock); - devm_free_irq(dev, priv->irq, priv); - i2c_del_adapter(&priv->adap); return 0; -- 2.7.4
-----Original Message----- From: tiantao (H) Sent: Friday, March 19, 2021 9:51 PM To: Song Bao Hua (Barry Song) <song.bao.hua@hisilicon.com> Cc: linuxarm@openeuler.org; tiantao (H) <tiantao6@hisilicon.com> Subject: [PATCH] i2c: mlxbf: Remove the unneeded devm_free_irq
Use devm_request_irq to request interrupts,devm_free_irq is not needed to release interrupts. so just remove it.
Signed-off-by: Tian Tao <tiantao6@hisilicon.com> ---
Looks good to me.
drivers/i2c/busses/i2c-mlxbf.c | 2 -- 1 file changed, 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-mlxbf.c b/drivers/i2c/busses/i2c-mlxbf.c index 2fb0532..ea839de 100644 --- a/drivers/i2c/busses/i2c-mlxbf.c +++ b/drivers/i2c/busses/i2c-mlxbf.c @@ -2426,8 +2426,6 @@ static int mlxbf_i2c_remove(struct platform_device *pdev) } mutex_unlock(&mlxbf_i2c_bus_lock);
- devm_free_irq(dev, priv->irq, priv); - i2c_del_adapter(&priv->adap);
return 0; -- 2.7.4
participants (2)
-
Song Bao Hua (Barry Song) -
Tian Tao