Re: [PATCH 1/2] config/arm: fix Hisilicon kunpeng920 SoC build
Message: 4 Date: Wed, 24 Feb 2021 11:24:27 +0100 From: Thomas Monjalon <thomas@monjalon.net> To: oulijun <oulijun@huawei.com> Cc: ferruh.yigit@intel.com, dev@dpdk.org, linuxarm@openeuler.org, juraj.linkes@pantheon.tech, bruce.richardson@intel.com Subject: Re: [dpdk-dev] [PATCH 1/2] config/arm: fix Hisilicon kunpeng920 SoC build Message-ID: <5309744.5Ik2CEZAj8@thomas> Content-Type: text/plain; charset="UTF-8"
24/02/2021 10:17, oulijun:
? 2021/2/24 15:41, Thomas Monjalon ??:
24/02/2021 02:34, oulijun:
? 2021/2/10 17:41, Thomas Monjalon ??:
03/02/2021 13:46, Lijun Ou:
From: Chengchang Tang <tangchengchang@huawei.com>
Because of the '9ca2f16' have merged, the current hns3 pmd driver can not be directly complied on the kunpeng920 server board. Therefore, we need to fix the meson build. Besides, add kunpeng 920 SoC meson cross compile target.
Fixes: 9ca2f16faa7f ("config/arm: isolate generic build")
Why do you think this patch is fixing the one above? It looks just a new config, not a fix. Am I missing something?
I'm sorry to see you so late. In the meantime, we are celebrating the Spring Festival. This patch fixes the problem. If the patch is not added, the latest version cannot be directly compiled on the Kunpeng 930 server board.In addition, the cross compilation configuration file is added.
Please can you explain what was removed which breaks your compilation?
I understand that implementation_id is identified in 9ca2f16. If the configuration file does not contain implementation_id, it will be displayed as unsupported.
The error as follows: config/arm/meson.build:227:2: ERROR: Problem encountered: Unsupported Arm implementer: 0x48. Please add support for it or use the generic (-Dmachine=generic) build.
Besides, we use the -Dmachine=generic, the bug is not resolved. the cmd as: meson build or meson -Dmachine=generic build
What is the result of a generic build?
Hello, Following dpdk commit 91c730fd4e093cd, the generic compilation for Arm is selected with '-Dmachine=default' The comments in config/arm/meson.build should be updated to follow the change in default machine name: https://git.dpdk.org/dpdk/tree/config/arm/meson.build#n241 https://git.dpdk.org/dpdk/tree/config/arm/meson.build#n256 Regards Thierry
-----Original Message----- From: Thierry Herbelot <thierry.herbelot@6wind.com> Sent: Wednesday, February 24, 2021 12:02 PM To: dev@dpdk.org; oulijun <oulijun@huawei.com>; Thomas Monjalon <thomas@monjalon.net> Cc: Juraj Linkeš <juraj.linkes@pantheon.tech>; Bruce Richardson <bruce.richardson@intel.com>; linuxarm@openeuler.org; ferruh.yigit@intel.com Subject: Re: [PATCH 1/2] config/arm: fix Hisilicon kunpeng920 SoC build
Message: 4 Date: Wed, 24 Feb 2021 11:24:27 +0100 From: Thomas Monjalon <thomas@monjalon.net> To: oulijun <oulijun@huawei.com> Cc: ferruh.yigit@intel.com, dev@dpdk.org, linuxarm@openeuler.org, juraj.linkes@pantheon.tech, bruce.richardson@intel.com Subject: Re: [dpdk-dev] [PATCH 1/2] config/arm: fix Hisilicon kunpeng920 SoC build Message-ID: <5309744.5Ik2CEZAj8@thomas> Content-Type: text/plain; charset="UTF-8"
24/02/2021 10:17, oulijun:
? 2021/2/24 15:41, Thomas Monjalon ??:
24/02/2021 02:34, oulijun:
? 2021/2/10 17:41, Thomas Monjalon ??:
03/02/2021 13:46, Lijun Ou: > From: Chengchang Tang <tangchengchang@huawei.com> > > Because of the '9ca2f16' have merged, the current hns3 pmd driver > can not be directly complied on the kunpeng920 server board. > Therefore, we need to fix the meson build. > Besides, add kunpeng 920 SoC meson cross compile target. > > Fixes: 9ca2f16faa7f ("config/arm: isolate generic build")
Why do you think this patch is fixing the one above? It looks just a new config, not a fix. Am I missing something?
I'm sorry to see you so late. In the meantime, we are celebrating the Spring Festival. This patch fixes the problem. If the patch is not added, the latest version cannot be directly compiled on the Kunpeng 930 server board.In addition, the cross compilation configuration
file is added.
Please can you explain what was removed which breaks your compilation?
I understand that implementation_id is identified in 9ca2f16. If the configuration file does not contain implementation_id, it will be displayed as unsupported.
The error as follows: config/arm/meson.build:227:2: ERROR: Problem encountered: Unsupported Arm implementer: 0x48. Please add support for it or use the generic (-Dmachine=generic) build.
Besides, we use the -Dmachine=generic, the bug is not resolved. the cmd as: meson build or meson -Dmachine=generic build
What is the result of a generic build?
Hello,
Following dpdk commit 91c730fd4e093cd, the generic compilation for Arm is selected with '-Dmachine=default'
The comments in config/arm/meson.build should be updated to follow the change in default machine name: https://git.dpdk.org/dpdk/tree/config/arm/meson.build#n241 https://git.dpdk.org/dpdk/tree/config/arm/meson.build#n256
Good catch, this is because http://patches.dpdk.org/project/dpdk/patch/1613657555-17683-1-git-send-email... was part of the same patch series as 9ca2f16faa7f. When the former patch was removed from the series, not everything in the series got properly updated. Lijun, please try "meson -Dmachine=default build". This should result in the same behavior as before 9ca2f16faa7f.
Regards
Thierry
在 2021/2/24 19:44, Juraj Linkeš 写道:
-----Original Message----- From: Thierry Herbelot <thierry.herbelot@6wind.com> Sent: Wednesday, February 24, 2021 12:02 PM To: dev@dpdk.org; oulijun <oulijun@huawei.com>; Thomas Monjalon <thomas@monjalon.net> Cc: Juraj Linkeš <juraj.linkes@pantheon.tech>; Bruce Richardson <bruce.richardson@intel.com>; linuxarm@openeuler.org; ferruh.yigit@intel.com Subject: Re: [PATCH 1/2] config/arm: fix Hisilicon kunpeng920 SoC build
Message: 4 Date: Wed, 24 Feb 2021 11:24:27 +0100 From: Thomas Monjalon <thomas@monjalon.net> To: oulijun <oulijun@huawei.com> Cc: ferruh.yigit@intel.com, dev@dpdk.org, linuxarm@openeuler.org, juraj.linkes@pantheon.tech, bruce.richardson@intel.com Subject: Re: [dpdk-dev] [PATCH 1/2] config/arm: fix Hisilicon kunpeng920 SoC build Message-ID: <5309744.5Ik2CEZAj8@thomas> Content-Type: text/plain; charset="UTF-8"
24/02/2021 10:17, oulijun:
? 2021/2/24 15:41, Thomas Monjalon ??:
24/02/2021 02:34, oulijun:
? 2021/2/10 17:41, Thomas Monjalon ??: > 03/02/2021 13:46, Lijun Ou: >> From: Chengchang Tang <tangchengchang@huawei.com> >> >> Because of the '9ca2f16' have merged, the current hns3 pmd driver >> can not be directly complied on the kunpeng920 server board. >> Therefore, we need to fix the meson build. >> Besides, add kunpeng 920 SoC meson cross compile target. >> >> Fixes: 9ca2f16faa7f ("config/arm: isolate generic build") > > Why do you think this patch is fixing the one above? > It looks just a new config, not a fix. Am I missing something? > I'm sorry to see you so late. In the meantime, we are celebrating the Spring Festival. This patch fixes the problem. If the patch is not added, the latest version cannot be directly compiled on the Kunpeng 930 server board.In addition, the cross compilation configuration
file is added.
Please can you explain what was removed which breaks your compilation?
I understand that implementation_id is identified in 9ca2f16. If the configuration file does not contain implementation_id, it will be displayed as unsupported.
The error as follows: config/arm/meson.build:227:2: ERROR: Problem encountered: Unsupported Arm implementer: 0x48. Please add support for it or use the generic (-Dmachine=generic) build.
Besides, we use the -Dmachine=generic, the bug is not resolved. the cmd as: meson build or meson -Dmachine=generic build
What is the result of a generic build?
Hello,
Following dpdk commit 91c730fd4e093cd, the generic compilation for Arm is selected with '-Dmachine=default'
The comments in config/arm/meson.build should be updated to follow the change in default machine name: https://git.dpdk.org/dpdk/tree/config/arm/meson.build#n241 https://git.dpdk.org/dpdk/tree/config/arm/meson.build#n256
Good catch, this is because http://patches.dpdk.org/project/dpdk/patch/1613657555-17683-1-git-send-email... was part of the same patch series as 9ca2f16faa7f. When the former patch was removed from the series, not everything in the series got properly updated.
Lijun, please try "meson -Dmachine=default build". This should result in the same behavior as before 9ca2f16faa7f.
Regards
Thierry
Yes, I've confirmed.Thank you for your explanation.I think it is necessary to add implementers to identify patches.What do you think?
_______________________________________________ Linuxarm mailing list -- linuxarm@openeuler.org To unsubscribe send an email to linuxarm-leave@openeuler.org
在 2021/2/24 19:02, Thierry Herbelot 写道:
Message: 4 Date: Wed, 24 Feb 2021 11:24:27 +0100 From: Thomas Monjalon <thomas@monjalon.net> To: oulijun <oulijun@huawei.com> Cc: ferruh.yigit@intel.com, dev@dpdk.org, linuxarm@openeuler.org, juraj.linkes@pantheon.tech, bruce.richardson@intel.com Subject: Re: [dpdk-dev] [PATCH 1/2] config/arm: fix Hisilicon kunpeng920 SoC build Message-ID: <5309744.5Ik2CEZAj8@thomas> Content-Type: text/plain; charset="UTF-8"
24/02/2021 10:17, oulijun:
? 2021/2/24 15:41, Thomas Monjalon ??:
24/02/2021 02:34, oulijun:
? 2021/2/10 17:41, Thomas Monjalon ??:
03/02/2021 13:46, Lijun Ou: > From: Chengchang Tang <tangchengchang@huawei.com> > > Because of the '9ca2f16' have merged, the current hns3 > pmd driver can not be directly complied on the kunpeng920 > server board. Therefore, we need to fix the meson build. > Besides, add kunpeng 920 SoC meson cross compile target. > > Fixes: 9ca2f16faa7f ("config/arm: isolate generic build")
Why do you think this patch is fixing the one above? It looks just a new config, not a fix. Am I missing something?
I'm sorry to see you so late. In the meantime, we are celebrating the Spring Festival. This patch fixes the problem. If the patch is not added, the latest version cannot be directly compiled on the Kunpeng 930 server board.In addition, the cross compilation configuration file is added.
Please can you explain what was removed which breaks your compilation?
I understand that implementation_id is identified in 9ca2f16. If the configuration file does not contain implementation_id, it will be displayed as unsupported.
The error as follows: config/arm/meson.build:227:2: ERROR: Problem encountered: Unsupported Arm implementer: 0x48. Please add support for it or use the generic (-Dmachine=generic) build.
Besides, we use the -Dmachine=generic, the bug is not resolved. the cmd as: meson build or meson -Dmachine=generic build
What is the result of a generic build?
Hello,
Following dpdk commit 91c730fd4e093cd, the generic compilation for Arm is selected with '-Dmachine=default'
The comments in config/arm/meson.build should be updated to follow the change in default machine name: https://git.dpdk.org/dpdk/tree/config/arm/meson.build#n241 https://git.dpdk.org/dpdk/tree/config/arm/meson.build#n256
Regards
Thierry
Yes, The message is incorrect. We are going to submit a repair patch.
_______________________________________________ Linuxarm mailing list -- linuxarm@openeuler.org To unsubscribe send an email to linuxarm-leave@openeuler.org
participants (3)
-
Juraj Linkeš -
oulijun -
Thierry Herbelot