-----Original Message----- From: Alex Williamson <alex.williamson@redhat.com> Sent: Tuesday, November 12, 2024 9:51 PM To: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com> Cc: liulongfang <liulongfang@huawei.com>; jgg@nvidia.com; Jonathan Cameron <jonathan.cameron@huawei.com>; kvm@vger.kernel.org; linux- kernel@vger.kernel.org; linuxarm@openeuler.org Subject: Re: [PATCH v15 3/4] hisi_acc_vfio_pci: register debugfs for hisilicon migration driver

On Tue, 12 Nov 2024 08:40:03 +0000 Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com> wrote:

...

...

-----Original Message----- From: liulongfang <liulongfang@huawei.com> Sent: Tuesday, November 12, 2024 7:33 AM To: alex.williamson@redhat.com; jgg@nvidia.com; Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>; Jonathan Cameron <jonathan.cameron@huawei.com> Cc: kvm@vger.kernel.org; linux-kernel@vger.kernel.org; linuxarm@openeuler.org; liulongfang <liulongfang@huawei.com> Subject: [PATCH v15 3/4] hisi_acc_vfio_pci: register debugfs for hisilicon migration driver

+static void hisi_acc_vfio_debug_init(struct hisi_acc_vf_core_device *hisi_acc_vdev) +{ + struct vfio_device *vdev = &hisi_acc_vdev->core_device.vdev; + struct hisi_acc_vf_migration_file *migf = NULL; + struct dentry *vfio_dev_migration = NULL; + struct dentry *vfio_hisi_acc = NULL;

Nit, I think we can get rid of these NULL initializations.

Yup, all three are unnecessary.

...

If you have time, please consider respin (sorry, missed this in earlier reviews.)

If that's the only comment, I can fix that on commit if you want to add an ack/review conditional on that change. Thanks,

Thanks Alex. With the above nits addressed, Reviewed-by: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com> Shameer