[PATCH 0/2] meson build fixes for hns3
This series fix meson build for kunpeng920 and kunpeng930 boards. Chengchang Tang (2): config/arm: fix Hisilicon kunpeng920 SoC build config/arm: fix Hisilicon kunpeng930 Soc build config/arm/arm64_kunpeng920_linux_gcc | 19 +++++++++++++++ config/arm/arm64_kunpeng930_linux_gcc | 19 +++++++++++++++ config/arm/meson.build | 27 ++++++++++++++++++++++ .../linux_gsg/cross_build_dpdk_for_arm64.rst | 5 ++++ 4 files changed, 70 insertions(+) create mode 100644 config/arm/arm64_kunpeng920_linux_gcc create mode 100644 config/arm/arm64_kunpeng930_linux_gcc -- 2.7.4
From: Chengchang Tang <tangchengchang@huawei.com> Because of the '9ca2f16' have merged, the current hns3 pmd driver can not be directly complied on the kunpeng920 server board. Therefore, we need to fix the meson build. Besides, add kunpeng 920 SoC meson cross compile target. Fixes: 9ca2f16faa7f ("config/arm: isolate generic build") Signed-off-by: Chengchang Tang <tangchengchang@huawei.com> Signed-off-by: Lijun Ou <oulijun@huawei.com> --- config/arm/arm64_kunpeng920_linux_gcc | 19 +++++++++++++++++++ config/arm/meson.build | 20 ++++++++++++++++++++ doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst | 4 ++++ 3 files changed, 43 insertions(+) create mode 100644 config/arm/arm64_kunpeng920_linux_gcc diff --git a/config/arm/arm64_kunpeng920_linux_gcc b/config/arm/arm64_kunpeng920_linux_gcc new file mode 100644 index 0000000..3eeb2e9 --- /dev/null +++ b/config/arm/arm64_kunpeng920_linux_gcc @@ -0,0 +1,19 @@ +[binaries] +c = 'aarch64-linux-gnu-gcc' +cpp = 'aarch64-linux-gnu-cpp' +ar = 'aarch64-linux-gnu-gcc-ar' +strip = 'aarch64-linux-gnu-strip' +pkgconfig = 'aarch64-linux-gnu-pkg-config' +pcap-config = '' + +[host_machine] +system = 'linux' +cpu_family = 'aarch64' +cpu = 'armv8-a' +endian = 'little' + +[properties] +implementer_id = '0x48' +part_number = '0xd01' +max_lcores = 128 +max_numa_nodes = 4 diff --git a/config/arm/meson.build b/config/arm/meson.build index f948768..9b87f5a 100644 --- a/config/arm/meson.build +++ b/config/arm/meson.build @@ -133,6 +133,25 @@ implementer_cavium = { } } +implementer_hisilicon = { + 'description': 'Hisilicon', + 'flags': [ + ['RTE_USE_C11_MEM_MODEL', true], + ['RTE_CACHE_LINE_SIZE', 128], + ['RTE_MAX_NUMA_NODES', 4] + ], + 'part_number_config': { + '0xd01': { + 'machine_args': ['-march=armv8.2-a+crypto', + '-mtune=tsv110'], + 'flag': [['RTE_MACHINE', '"kunpeng920"'], + ['RTE_MAX_LCORE', 128], + ['RTE_ARM_FEATURE_ATOMICS', true] + ] + } + } +} + implementer_ampere = { 'description': 'Ampere Computing', 'flags': [ @@ -176,6 +195,7 @@ implementers = { 'generic': implementer_generic, '0x41': implementer_arm, '0x43': implementer_cavium, + '0x48': implementer_hisilicon, '0x50': implementer_ampere, '0x56': implementer_marvell, 'dpaa': implementer_dpaa diff --git a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst index faaf24b..afe4f8e 100644 --- a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst +++ b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst @@ -197,6 +197,7 @@ you may use various combinations of implementer/part number:: 'generic': Generic armv8 '0x41': Arm '0x43': Cavium + '0x48': Hisilicon '0x50': Ampere Computing '0x56': Marvell ARMADA 'dpaa': NXP DPAA @@ -219,6 +220,9 @@ you may use various combinations of implementer/part number:: '0xaf': thunderx2t99 '0xb2': octeontx2 + Supported part_numbers for 0x48: + '0xd01': kunpeng920 + Supported part_numbers for 0x50: '0x0': emag -- 2.7.4
03/02/2021 13:46, Lijun Ou:
From: Chengchang Tang <tangchengchang@huawei.com>
Because of the '9ca2f16' have merged, the current hns3 pmd driver can not be directly complied on the kunpeng920 server board. Therefore, we need to fix the meson build. Besides, add kunpeng 920 SoC meson cross compile target.
Fixes: 9ca2f16faa7f ("config/arm: isolate generic build")
Why do you think this patch is fixing the one above? It looks just a new config, not a fix. Am I missing something?
在 2021/2/10 17:41, Thomas Monjalon 写道:
03/02/2021 13:46, Lijun Ou:
From: Chengchang Tang <tangchengchang@huawei.com>
Because of the '9ca2f16' have merged, the current hns3 pmd driver can not be directly complied on the kunpeng920 server board. Therefore, we need to fix the meson build. Besides, add kunpeng 920 SoC meson cross compile target.
Fixes: 9ca2f16faa7f ("config/arm: isolate generic build")
Why do you think this patch is fixing the one above? It looks just a new config, not a fix. Am I missing something?
I'm sorry to see you so late. In the meantime, we are celebrating the Spring Festival. This patch fixes the problem. If the patch is not added, the latest version cannot be directly compiled on the Kunpeng 930 server board.In addition, the cross compilation configuration file is added.
.
24/02/2021 02:34, oulijun:
在 2021/2/10 17:41, Thomas Monjalon 写道:
03/02/2021 13:46, Lijun Ou:
From: Chengchang Tang <tangchengchang@huawei.com>
Because of the '9ca2f16' have merged, the current hns3 pmd driver can not be directly complied on the kunpeng920 server board. Therefore, we need to fix the meson build. Besides, add kunpeng 920 SoC meson cross compile target.
Fixes: 9ca2f16faa7f ("config/arm: isolate generic build")
Why do you think this patch is fixing the one above? It looks just a new config, not a fix. Am I missing something?
I'm sorry to see you so late. In the meantime, we are celebrating the Spring Festival. This patch fixes the problem. If the patch is not added, the latest version cannot be directly compiled on the Kunpeng 930 server board.In addition, the cross compilation configuration file is added.
Please can you explain what was removed which breaks your compilation?
在 2021/2/24 15:41, Thomas Monjalon 写道:
24/02/2021 02:34, oulijun:
在 2021/2/10 17:41, Thomas Monjalon 写道:
03/02/2021 13:46, Lijun Ou:
From: Chengchang Tang <tangchengchang@huawei.com>
Because of the '9ca2f16' have merged, the current hns3 pmd driver can not be directly complied on the kunpeng920 server board. Therefore, we need to fix the meson build. Besides, add kunpeng 920 SoC meson cross compile target.
Fixes: 9ca2f16faa7f ("config/arm: isolate generic build")
Why do you think this patch is fixing the one above? It looks just a new config, not a fix. Am I missing something?
I'm sorry to see you so late. In the meantime, we are celebrating the Spring Festival. This patch fixes the problem. If the patch is not added, the latest version cannot be directly compiled on the Kunpeng 930 server board.In addition, the cross compilation configuration file is added.
Please can you explain what was removed which breaks your compilation?
I understand that implementation_id is identified in 9ca2f16. If the configuration file does not contain implementation_id, it will be displayed as unsupported. The error as follows: config/arm/meson.build:227:2: ERROR: Problem encountered: Unsupported Arm implementer: 0x48. Please add support for it or use the generic (-Dmachine=generic) build. Besides, we use the -Dmachine=generic, the bug is not resolved. the cmd as: meson build or meson -Dmachine=generic build
.
24/02/2021 10:17, oulijun:
在 2021/2/24 15:41, Thomas Monjalon 写道:
24/02/2021 02:34, oulijun:
在 2021/2/10 17:41, Thomas Monjalon 写道:
03/02/2021 13:46, Lijun Ou:
From: Chengchang Tang <tangchengchang@huawei.com>
Because of the '9ca2f16' have merged, the current hns3 pmd driver can not be directly complied on the kunpeng920 server board. Therefore, we need to fix the meson build. Besides, add kunpeng 920 SoC meson cross compile target.
Fixes: 9ca2f16faa7f ("config/arm: isolate generic build")
Why do you think this patch is fixing the one above? It looks just a new config, not a fix. Am I missing something?
I'm sorry to see you so late. In the meantime, we are celebrating the Spring Festival. This patch fixes the problem. If the patch is not added, the latest version cannot be directly compiled on the Kunpeng 930 server board.In addition, the cross compilation configuration file is added.
Please can you explain what was removed which breaks your compilation?
I understand that implementation_id is identified in 9ca2f16. If the configuration file does not contain implementation_id, it will be displayed as unsupported.
The error as follows: config/arm/meson.build:227:2: ERROR: Problem encountered: Unsupported Arm implementer: 0x48. Please add support for it or use the generic (-Dmachine=generic) build.
Besides, we use the -Dmachine=generic, the bug is not resolved. the cmd as: meson build or meson -Dmachine=generic build
What is the result of a generic build?
-----Original Message----- From: dev <dev-bounces@dpdk.org> On Behalf Of Thomas Monjalon Sent: Wednesday, February 24, 2021 8:42 AM To: oulijun <oulijun@huawei.com> Cc: ferruh.yigit@intel.com; dev@dpdk.org; linuxarm@openeuler.org Subject: Re: [dpdk-dev] [PATCH 1/2] config/arm: fix Hisilicon kunpeng920 SoC build
24/02/2021 02:34, oulijun:
在 2021/2/10 17:41, Thomas Monjalon 写道:
03/02/2021 13:46, Lijun Ou:
From: Chengchang Tang <tangchengchang@huawei.com>
Because of the '9ca2f16' have merged, the current hns3 pmd driver can not be directly complied on the kunpeng920 server board. Therefore, we need to fix the meson build. Besides, add kunpeng 920 SoC meson cross compile target.
Fixes: 9ca2f16faa7f ("config/arm: isolate generic build")
Why do you think this patch is fixing the one above? It looks just a new config, not a fix. Am I missing something?
I'm sorry to see you so late. In the meantime, we are celebrating the Spring Festival. This patch fixes the problem. If the patch is not added, the latest version cannot be directly compiled on the Kunpeng 930 server board.In addition, the cross compilation configuration file is added.
Please can you explain what was removed which breaks your compilation?
I can explain what's changed and why we changed it. The previous behavior was that when an uknown implementer was found (when we're building on an uknown build machine) we fell back to a generic build. The current behavior is we raise an error when building on an unknown build machine and inform the user about the generic build (there's an error in the message, it should be -Dmachine=default instead of -Dmachine=generic). Lijun came across this scenario, so he wants to add an implementer, but it is not a fix, rather an addition that we wanted to encourage when we changed the behavior. The change in behavior also has an additional benefit in that it notifies the user that meson is not doing a tailored build for the build machine and the only permissible build is the generic one.
24/02/2021 12:55, Juraj Linkeš:
From: dev <dev-bounces@dpdk.org> On Behalf Of Thomas Monjalon
24/02/2021 02:34, oulijun:
在 2021/2/10 17:41, Thomas Monjalon 写道:
03/02/2021 13:46, Lijun Ou:
From: Chengchang Tang <tangchengchang@huawei.com>
Because of the '9ca2f16' have merged, the current hns3 pmd driver can not be directly complied on the kunpeng920 server board. Therefore, we need to fix the meson build. Besides, add kunpeng 920 SoC meson cross compile target.
Fixes: 9ca2f16faa7f ("config/arm: isolate generic build")
Why do you think this patch is fixing the one above? It looks just a new config, not a fix. Am I missing something?
I'm sorry to see you so late. In the meantime, we are celebrating the Spring Festival. This patch fixes the problem. If the patch is not added, the latest version cannot be directly compiled on the Kunpeng 930 server board.In addition, the cross compilation configuration file is added.
Please can you explain what was removed which breaks your compilation?
I can explain what's changed and why we changed it.
The previous behavior was that when an uknown implementer was found (when we're building on an uknown build machine) we fell back to a generic build. The current behavior is we raise an error when building on an unknown build machine and inform the user about the generic build (there's an error in the message, it should be -Dmachine=default instead of -Dmachine=generic). Lijun came across this scenario, so he wants to add an implementer, but it is not a fix, rather an addition that we wanted to encourage when we changed the behavior. The change in behavior also has an additional benefit in that it notifies the user that meson is not doing a tailored build for the build machine and the only permissible build is the generic one.
There were already many fixes for that rework. Please check if there are other missing updates.
-----Original Message----- From: Thomas Monjalon <thomas@monjalon.net> Sent: Wednesday, February 24, 2021 1:10 PM To: Juraj Linkeš <juraj.linkes@pantheon.tech> Cc: oulijun <oulijun@huawei.com>; ferruh.yigit@intel.com; dev@dpdk.org; linuxarm@openeuler.org Subject: Re: [dpdk-dev] [PATCH 1/2] config/arm: fix Hisilicon kunpeng920 SoC build
24/02/2021 12:55, Juraj Linkeš:
From: dev <dev-bounces@dpdk.org> On Behalf Of Thomas Monjalon
24/02/2021 02:34, oulijun:
在 2021/2/10 17:41, Thomas Monjalon 写道:
03/02/2021 13:46, Lijun Ou:
From: Chengchang Tang <tangchengchang@huawei.com>
Because of the '9ca2f16' have merged, the current hns3 pmd driver can not be directly complied on the kunpeng920 server board. Therefore, we need to fix the meson build. Besides, add kunpeng 920 SoC meson cross compile target.
Fixes: 9ca2f16faa7f ("config/arm: isolate generic build")
Why do you think this patch is fixing the one above? It looks just a new config, not a fix. Am I missing something?
I'm sorry to see you so late. In the meantime, we are celebrating the Spring Festival. This patch fixes the problem. If the patch is not added, the latest version cannot be directly compiled on the Kunpeng 930 server board.In addition, the cross compilation configuration file is
added.
Please can you explain what was removed which breaks your compilation?
I can explain what's changed and why we changed it.
The previous behavior was that when an uknown implementer was found (when we're building on an uknown build machine) we fell back to a generic build. The current behavior is we raise an error when building on an unknown build machine and inform the user about the generic build (there's an error in the message, it should be -Dmachine=default instead of -Dmachine=generic). Lijun came across this scenario, so he wants to add an implementer, but it is not a fix, rather an addition that we wanted to encourage when we changed the behavior. The change in behavior also has an additional benefit in that it notifies the user that meson is not doing a tailored build for the build machine and the only permissible build is the generic one.
There were already many fixes for that rework. Please check if there are other missing updates.
This is actually the first mistake that my testing missed. I tested that the message is properly emitted, but I didn't test the message after we extracted the default->generic rename patch. As a side note, we could address this issue with http://patches.dpdk.org/project/dpdk/patch/1613657555-17683-1-git-send-email... - then we can leave the message in place as is (with -Dmachine=generic). I went through all of the patches again but I didn't find anything that needs addressing. As far as I'm aware, there were two other fixes for the series. One was a failure of communication (the native margs fix - I implemented what we thought we agreed on) and the other is not really a fix, just the addition of one implementer configuration (I removed the implementer because we didn't have its configuration). The clang cross-compile fixes are related, but those are the problem with that series, not the rework series.
在 2021/3/1 18:46, Juraj Linkeš 写道:
-----Original Message----- From: Thomas Monjalon <thomas@monjalon.net> Sent: Wednesday, February 24, 2021 1:10 PM To: Juraj Linkeš <juraj.linkes@pantheon.tech> Cc: oulijun <oulijun@huawei.com>; ferruh.yigit@intel.com; dev@dpdk.org; linuxarm@openeuler.org Subject: Re: [dpdk-dev] [PATCH 1/2] config/arm: fix Hisilicon kunpeng920 SoC build
24/02/2021 12:55, Juraj Linkeš:
From: dev <dev-bounces@dpdk.org> On Behalf Of Thomas Monjalon
24/02/2021 02:34, oulijun:
在 2021/2/10 17:41, Thomas Monjalon 写道:
03/02/2021 13:46, Lijun Ou: > From: Chengchang Tang <tangchengchang@huawei.com> > > Because of the '9ca2f16' have merged, the current hns3 pmd > driver can not be directly complied on the kunpeng920 server board. > Therefore, we need to fix the meson build. > Besides, add kunpeng 920 SoC meson cross compile target. > > Fixes: 9ca2f16faa7f ("config/arm: isolate generic build")
Why do you think this patch is fixing the one above? It looks just a new config, not a fix. Am I missing something?
I'm sorry to see you so late. In the meantime, we are celebrating the Spring Festival. This patch fixes the problem. If the patch is not added, the latest version cannot be directly compiled on the Kunpeng 930 server board.In addition, the cross compilation configuration file is
added.
Please can you explain what was removed which breaks your compilation?
I can explain what's changed and why we changed it.
The previous behavior was that when an uknown implementer was found (when we're building on an uknown build machine) we fell back to a generic build. The current behavior is we raise an error when building on an unknown build machine and inform the user about the generic build (there's an error in the message, it should be -Dmachine=default instead of -Dmachine=generic). Lijun came across this scenario, so he wants to add an implementer, but it is not a fix, rather an addition that we wanted to encourage when we changed the behavior. The change in behavior also has an additional benefit in that it notifies the user that meson is not doing a tailored build for the build machine and the only permissible build is the generic one.
There were already many fixes for that rework. Please check if there are other missing updates.
This is actually the first mistake that my testing missed. I tested that the message is properly emitted, but I didn't test the message after we extracted the default->generic rename patch. As a side note, we could address this issue with http://patches.dpdk.org/project/dpdk/patch/1613657555-17683-1-git-send-email... - then we can leave the message in place as is (with -Dmachine=generic).
I went through all of the patches again but I didn't find anything that needs addressing.
As far as I'm aware, there were two other fixes for the series. One was a failure of communication (the native margs fix - I implemented what we thought we agreed on) and the other is not really a fix, just the addition of one implementer configuration (I removed the implementer because we didn't have its configuration). The clang cross-compile fixes are related, but those are the problem with that series, not the rework series.
Hi, the patch http://patches.dpdk.org/project/dpdk/patch/1613657555-17683-1-git-send-email... will this patch be incorporated? We have realized this problem and fixed it in the internal version.
Hi, all, any comments for this patch? Hope for your reply. Thanks. 在 2021/3/5 9:36, oulijun 写道:
在 2021/3/1 18:46, Juraj Linkeš 写道:
-----Original Message----- From: Thomas Monjalon <thomas@monjalon.net> Sent: Wednesday, February 24, 2021 1:10 PM To: Juraj Linkeš <juraj.linkes@pantheon.tech> Cc: oulijun <oulijun@huawei.com>; ferruh.yigit@intel.com; dev@dpdk.org; linuxarm@openeuler.org Subject: Re: [dpdk-dev] [PATCH 1/2] config/arm: fix Hisilicon kunpeng920 SoC build
24/02/2021 12:55, Juraj Linkeš:
From: dev <dev-bounces@dpdk.org> On Behalf Of Thomas Monjalon
24/02/2021 02:34, oulijun:
在 2021/2/10 17:41, Thomas Monjalon 写道: > 03/02/2021 13:46, Lijun Ou: >> From: Chengchang Tang <tangchengchang@huawei.com> >> >> Because of the '9ca2f16' have merged, the current hns3 pmd >> driver can not be directly complied on the kunpeng920 server board. >> Therefore, we need to fix the meson build. >> Besides, add kunpeng 920 SoC meson cross compile target. >> >> Fixes: 9ca2f16faa7f ("config/arm: isolate generic build") > > Why do you think this patch is fixing the one above? > It looks just a new config, not a fix. Am I missing something? > I'm sorry to see you so late. In the meantime, we are celebrating the Spring Festival. This patch fixes the problem. If the patch is not added, the latest version cannot be directly compiled on the Kunpeng 930 server board.In addition, the cross compilation configuration file is
added.
Please can you explain what was removed which breaks your compilation?
I can explain what's changed and why we changed it.
The previous behavior was that when an uknown implementer was found (when we're building on an uknown build machine) we fell back to a generic build. The current behavior is we raise an error when building on an unknown build machine and inform the user about the generic build (there's an error in the message, it should be -Dmachine=default instead of -Dmachine=generic). Lijun came across this scenario, so he wants to add an implementer, but it is not a fix, rather an addition that we wanted to encourage when we changed the behavior. The change in behavior also has an additional benefit in that it notifies the user that meson is not doing a tailored build for the build machine and the only permissible build is the generic one.
There were already many fixes for that rework. Please check if there are other missing updates.
This is actually the first mistake that my testing missed. I tested that the message is properly emitted, but I didn't test the message after we extracted the default->generic rename patch. As a side note, we could address this issue with http://patches.dpdk.org/project/dpdk/patch/1613657555-17683-1-git-send-email... - then we can leave the message in place as is (with -Dmachine=generic).
I went through all of the patches again but I didn't find anything that needs addressing.
As far as I'm aware, there were two other fixes for the series. One was a failure of communication (the native margs fix - I implemented what we thought we agreed on) and the other is not really a fix, just the addition of one implementer configuration (I removed the implementer because we didn't have its configuration). The clang cross-compile fixes are related, but those are the problem with that series, not the rework series.
Hi, the patch http://patches.dpdk.org/project/dpdk/patch/1613657555-17683-1-git-send-email...
will this patch be incorporated? We have realized this problem and fixed it in the internal version.
.
From: Chengchang Tang <tangchengchang@huawei.com> Because of the '9ca2f16' have merged, the current hns3 pmd driver can not be directly complied on the kunpeng930 FPGA board. Therefore, we need to fix the meson build. Besides, add kunpeng 930 SoC meson cross compile target. Fixes: 9ca2f16faa7f ("config/arm: isolate generic build") Signed-off-by: Chengchang Tang <tangchengchang@huawei.com> Signed-off-by: Lijun Ou <oulijun@huawei.com> --- config/arm/arm64_kunpeng930_linux_gcc | 19 +++++++++++++++++++ config/arm/meson.build | 7 +++++++ doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst | 1 + 3 files changed, 27 insertions(+) create mode 100644 config/arm/arm64_kunpeng930_linux_gcc diff --git a/config/arm/arm64_kunpeng930_linux_gcc b/config/arm/arm64_kunpeng930_linux_gcc new file mode 100644 index 0000000..464e44a --- /dev/null +++ b/config/arm/arm64_kunpeng930_linux_gcc @@ -0,0 +1,19 @@ +[binaries] +c = 'aarch64-linux-gnu-gcc' +cpp = 'aarch64-linux-gnu-cpp' +ar = 'aarch64-linux-gnu-gcc-ar' +strip = 'aarch64-linux-gnu-strip' +pkgconfig = 'aarch64-linux-gnu-pkg-config' +pcap-config = '' + +[host_machine] +system = 'linux' +cpu_family = 'aarch64' +cpu = 'armv8-a' +endian = 'little' + +[properties] +implementer_id = '0x48' +part_number = '0xd02' +max_lcores = 256 +max_numa_nodes = 4 diff --git a/config/arm/meson.build b/config/arm/meson.build index 9b87f5a..f834adb 100644 --- a/config/arm/meson.build +++ b/config/arm/meson.build @@ -148,6 +148,13 @@ implementer_hisilicon = { ['RTE_MAX_LCORE', 128], ['RTE_ARM_FEATURE_ATOMICS', true] ] + }, + '0xd02': { + 'machine_args': ['-march=armv8.2-a+crypto+sve'], + 'flag': [['RTE_MACHINE', '"kunpeng930"'], + ['RTE_MAX_LCORE', 256], + ['RTE_ARM_FEATURE_ATOMICS', true] + ] } } } diff --git a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst index afe4f8e..1a54436 100644 --- a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst +++ b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst @@ -222,6 +222,7 @@ you may use various combinations of implementer/part number:: Supported part_numbers for 0x48: '0xd01': kunpeng920 + '0xd02': kunpeng930 Supported part_numbers for 0x50: '0x0': emag -- 2.7.4
This series add meson build for Hisilicon kunpeng CPU. Lijun Ou (4): config/arm: add Hisilicon kunpeng920 implementer config/arm: add Hisilicon kunpeng930 implementer config/arm: add kunpeng920 meson cross compile target config/arm: add kunpeng930 meson cross compile target config/arm/arm64_kunpeng920_linux_gcc | 19 +++++++++++++++ config/arm/arm64_kunpeng930_linux_gcc | 19 +++++++++++++++ config/arm/meson.build | 27 ++++++++++++++++++++++ .../linux_gsg/cross_build_dpdk_for_arm64.rst | 5 ++++ 4 files changed, 70 insertions(+) create mode 100644 config/arm/arm64_kunpeng920_linux_gcc create mode 100644 config/arm/arm64_kunpeng930_linux_gcc -- 2.7.4
Here addes Kunpeng920 config back which was deleted. Fixes: 91c730fd4e09 ("config/arm: remove unused or superfluous variables") Signed-off-by: Chengchang Tang <tangchengchang@huawei.com> Signed-off-by: Lijun Ou <oulijun@huawei.com> --- V1->V2: - rewrite patch title. - split the patch into two. --- config/arm/meson.build | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/config/arm/meson.build b/config/arm/meson.build index 00bc461..3826900 100644 --- a/config/arm/meson.build +++ b/config/arm/meson.build @@ -133,6 +133,25 @@ implementer_cavium = { } } +implementer_hisilicon = { + 'description': 'Hisilicon', + 'flags': [ + ['RTE_USE_C11_MEM_MODEL', true], + ['RTE_CACHE_LINE_SIZE', 128], + ['RTE_MAX_NUMA_NODES', 4] + ], + 'part_number_config': { + '0xd01': { + 'machine_args': ['-march=armv8.2-a+crypto', + '-mtune=tsv110'], + 'flag': [['RTE_MACHINE', '"kunpeng920"'], + ['RTE_MAX_LCORE', 128], + ['RTE_ARM_FEATURE_ATOMICS', true] + ] + } + } +} + implementer_ampere = { 'description': 'Ampere Computing', 'flags': [ @@ -190,6 +209,7 @@ implementers = { 'generic': implementer_generic, '0x41': implementer_arm, '0x43': implementer_cavium, + '0x48': implementer_hisilicon, '0x50': implementer_ampere, '0x51': implementer_qualcomm, '0x56': implementer_marvell, -- 2.7.4
-----Original Message----- From: dev <dev-bounces@dpdk.org> On Behalf Of Lijun Ou Sent: Wednesday, March 10, 2021 9:36 AM To: thomas@monjalon.net; ferruh.yigit@intel.com Cc: dev@dpdk.org; linuxarm@openeuler.org Subject: [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon kunpeng920 implementer
Here addes Kunpeng920 config back which was deleted.
Fixes: 91c730fd4e09 ("config/arm: remove unused or superfluous variables")
Signed-off-by: Chengchang Tang <tangchengchang@huawei.com> Signed-off-by: Lijun Ou <oulijun@huawei.com> --- V1->V2: - rewrite patch title. - split the patch into two. --- config/arm/meson.build | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+)
diff --git a/config/arm/meson.build b/config/arm/meson.build index 00bc461..3826900 100644 --- a/config/arm/meson.build +++ b/config/arm/meson.build @@ -133,6 +133,25 @@ implementer_cavium = { } }
+implementer_hisilicon = { + 'description': 'Hisilicon', + 'flags': [ + ['RTE_USE_C11_MEM_MODEL', true], + ['RTE_CACHE_LINE_SIZE', 128],
Just want to double check. One Kunpeng920 box I can access have cache line size 64B. Thanks.
+ ['RTE_MAX_NUMA_NODES', 4] + ], + 'part_number_config': { + '0xd01': { + 'machine_args': ['-march=armv8.2-a+crypto', + '-mtune=tsv110'], + 'flag': [['RTE_MACHINE', '"kunpeng920"'], + ['RTE_MAX_LCORE', 128], + ['RTE_ARM_FEATURE_ATOMICS', true] + ] + } + } +} + implementer_ampere = { 'description': 'Ampere Computing', 'flags': [ @@ -190,6 +209,7 @@ implementers = { 'generic': implementer_generic, '0x41': implementer_arm, '0x43': implementer_cavium, + '0x48': implementer_hisilicon, '0x50': implementer_ampere, '0x51': implementer_qualcomm, '0x56': implementer_marvell, -- 2.7.4
在 2021/3/23 16:07, Ruifeng Wang 写道:
-----Original Message----- From: dev <dev-bounces@dpdk.org> On Behalf Of Lijun Ou Sent: Wednesday, March 10, 2021 9:36 AM To: thomas@monjalon.net; ferruh.yigit@intel.com Cc: dev@dpdk.org; linuxarm@openeuler.org Subject: [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon kunpeng920 implementer
Here addes Kunpeng920 config back which was deleted.
Fixes: 91c730fd4e09 ("config/arm: remove unused or superfluous variables")
Signed-off-by: Chengchang Tang <tangchengchang@huawei.com> Signed-off-by: Lijun Ou <oulijun@huawei.com> --- V1->V2: - rewrite patch title. - split the patch into two. --- config/arm/meson.build | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+)
diff --git a/config/arm/meson.build b/config/arm/meson.build index 00bc461..3826900 100644 --- a/config/arm/meson.build +++ b/config/arm/meson.build @@ -133,6 +133,25 @@ implementer_cavium = { } }
+implementer_hisilicon = { + 'description': 'Hisilicon', + 'flags': [ + ['RTE_USE_C11_MEM_MODEL', true], + ['RTE_CACHE_LINE_SIZE', 128],
Just want to double check. One Kunpeng920 box I can access have cache line size 64B.
I have a question, which level does RTE_CACHE_LINE_SIZE refer to? For kunpeng920, L1/L2 cache size is 64B，L3 is 128B
Thanks.
+ ['RTE_MAX_NUMA_NODES', 4] + ], + 'part_number_config': { + '0xd01': { + 'machine_args': ['-march=armv8.2-a+crypto', + '-mtune=tsv110'], + 'flag': [['RTE_MACHINE', '"kunpeng920"'], + ['RTE_MAX_LCORE', 128], + ['RTE_ARM_FEATURE_ATOMICS', true] + ] + } + } +} + implementer_ampere = { 'description': 'Ampere Computing', 'flags': [ @@ -190,6 +209,7 @@ implementers = { 'generic': implementer_generic, '0x41': implementer_arm, '0x43': implementer_cavium, + '0x48': implementer_hisilicon, '0x50': implementer_ampere, '0x51': implementer_qualcomm, '0x56': implementer_marvell, -- 2.7.4
.
-----Original Message----- From: oulijun <oulijun@huawei.com> Sent: Tuesday, March 23, 2021 9:52 PM To: Ruifeng Wang <Ruifeng.Wang@arm.com>; thomas@monjalon.net; ferruh.yigit@intel.com Cc: dev@dpdk.org; linuxarm@openeuler.org; nd <nd@arm.com> Subject: Re: [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon kunpeng920 implementer
2021/3/23 16:07, Ruifeng Wang д :
-----Original Message----- From: dev <dev-bounces@dpdk.org> On Behalf Of Lijun Ou Sent: Wednesday, March 10, 2021 9:36 AM To: thomas@monjalon.net; ferruh.yigit@intel.com Cc: dev@dpdk.org; linuxarm@openeuler.org Subject: [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon kunpeng920 implementer
Here addes Kunpeng920 config back which was deleted.
Fixes: 91c730fd4e09 ("config/arm: remove unused or superfluous variables")
Signed-off-by: Chengchang Tang <tangchengchang@huawei.com> Signed-off-by: Lijun Ou <oulijun@huawei.com> --- V1->V2: - rewrite patch title. - split the patch into two. --- config/arm/meson.build | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+)
diff --git a/config/arm/meson.build b/config/arm/meson.build index 00bc461..3826900 100644 --- a/config/arm/meson.build +++ b/config/arm/meson.build @@ -133,6 +133,25 @@ implementer_cavium = { } }
+implementer_hisilicon = { + 'description': 'Hisilicon', + 'flags': [ + ['RTE_USE_C11_MEM_MODEL', true], + ['RTE_CACHE_LINE_SIZE', 128],
Just want to double check. One Kunpeng920 box I can access have cache line size 64B.
I have a question, which level does RTE_CACHE_LINE_SIZE refer to? For kunpeng920, L1/L2 cache size is 64B L3 is 128B
Got it. I think RTE_CACHE_LINE_SIZE is not defined for a certain level of cache. Data can be prefetched into any level of cache by using different APIs.
Thanks.
+ ['RTE_MAX_NUMA_NODES', 4] + ], + 'part_number_config': { + '0xd01': { + 'machine_args': ['-march=armv8.2-a+crypto', + '-mtune=tsv110'], + 'flag': [['RTE_MACHINE', '"kunpeng920"'], + ['RTE_MAX_LCORE', 128], + ['RTE_ARM_FEATURE_ATOMICS', true] + ] + } + } +} + implementer_ampere = { 'description': 'Ampere Computing', 'flags': [ @@ -190,6 +209,7 @@ implementers = { 'generic': implementer_generic, '0x41': implementer_arm, '0x43': implementer_cavium, + '0x48': implementer_hisilicon, '0x50': implementer_ampere, '0x51': implementer_qualcomm, '0x56': implementer_marvell, -- 2.7.4
.
在 2021/3/23 23:40, Ruifeng Wang 写道:
-----Original Message----- From: oulijun <oulijun@huawei.com> Sent: Tuesday, March 23, 2021 9:52 PM To: Ruifeng Wang <Ruifeng.Wang@arm.com>; thomas@monjalon.net; ferruh.yigit@intel.com Cc: dev@dpdk.org; linuxarm@openeuler.org; nd <nd@arm.com> Subject: Re: [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon kunpeng920 implementer
2021/3/23 16:07, Ruifeng Wang д :
-----Original Message----- From: dev <dev-bounces@dpdk.org> On Behalf Of Lijun Ou Sent: Wednesday, March 10, 2021 9:36 AM To: thomas@monjalon.net; ferruh.yigit@intel.com Cc: dev@dpdk.org; linuxarm@openeuler.org Subject: [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon kunpeng920 implementer
Here addes Kunpeng920 config back which was deleted.
Fixes: 91c730fd4e09 ("config/arm: remove unused or superfluous variables")
Signed-off-by: Chengchang Tang <tangchengchang@huawei.com> Signed-off-by: Lijun Ou <oulijun@huawei.com> --- V1->V2: - rewrite patch title. - split the patch into two. --- config/arm/meson.build | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+)
diff --git a/config/arm/meson.build b/config/arm/meson.build index 00bc461..3826900 100644 --- a/config/arm/meson.build +++ b/config/arm/meson.build @@ -133,6 +133,25 @@ implementer_cavium = { } }
+implementer_hisilicon = { + 'description': 'Hisilicon', + 'flags': [ + ['RTE_USE_C11_MEM_MODEL', true], + ['RTE_CACHE_LINE_SIZE', 128],
Just want to double check. One Kunpeng920 box I can access have cache line size 64B.
I have a question, which level does RTE_CACHE_LINE_SIZE refer to? For kunpeng920, L1/L2 cache size is 64B L3 is 128B
Got it. I think RTE_CACHE_LINE_SIZE is not defined for a certain level of cache. Data can be prefetched into any level of cache by using different APIs.
So our current configuration should be fine.
Thanks.
+ ['RTE_MAX_NUMA_NODES', 4] + ], + 'part_number_config': { + '0xd01': { + 'machine_args': ['-march=armv8.2-a+crypto', + '-mtune=tsv110'], + 'flag': [['RTE_MACHINE', '"kunpeng920"'], + ['RTE_MAX_LCORE', 128], + ['RTE_ARM_FEATURE_ATOMICS', true] + ] + } + } +} + implementer_ampere = { 'description': 'Ampere Computing', 'flags': [ @@ -190,6 +209,7 @@ implementers = { 'generic': implementer_generic, '0x41': implementer_arm, '0x43': implementer_cavium, + '0x48': implementer_hisilicon, '0x50': implementer_ampere, '0x51': implementer_qualcomm, '0x56': implementer_marvell, -- 2.7.4
.
-----Original Message----- From: oulijun <oulijun@huawei.com> Sent: Thursday, March 25, 2021 3:22 PM To: Ruifeng Wang <Ruifeng.Wang@arm.com>; thomas@monjalon.net; ferruh.yigit@intel.com Cc: dev@dpdk.org; linuxarm@openeuler.org; nd <nd@arm.com> Subject: Re: [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon kunpeng920 implementer
在 2021/3/23 23:40, Ruifeng Wang 写道:
-----Original Message----- From: oulijun <oulijun@huawei.com> Sent: Tuesday, March 23, 2021 9:52 PM To: Ruifeng Wang <Ruifeng.Wang@arm.com>; thomas@monjalon.net; ferruh.yigit@intel.com Cc: dev@dpdk.org; linuxarm@openeuler.org; nd <nd@arm.com> Subject: Re: [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon kunpeng920 implementer
2021/3/23 16:07, Ruifeng Wang д :
-----Original Message----- From: dev <dev-bounces@dpdk.org> On Behalf Of Lijun Ou Sent: Wednesday, March 10, 2021 9:36 AM To: thomas@monjalon.net; ferruh.yigit@intel.com Cc: dev@dpdk.org; linuxarm@openeuler.org Subject: [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon kunpeng920 implementer
Here addes Kunpeng920 config back which was deleted.
There was no Kunpeng920 specific config before change 91c730fd4e09. It would fall back to generic build because the behavior was to do generic build for unknown implementor / part number.
Fixes: 91c730fd4e09 ("config/arm: remove unused or superfluous variables")
Signed-off-by: Chengchang Tang <tangchengchang@huawei.com> Signed-off-by: Lijun Ou <oulijun@huawei.com> --- V1->V2: - rewrite patch title. - split the patch into two. --- config/arm/meson.build | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+)
diff --git a/config/arm/meson.build b/config/arm/meson.build index 00bc461..3826900 100644 --- a/config/arm/meson.build +++ b/config/arm/meson.build @@ -133,6 +133,25 @@ implementer_cavium = { } }
+implementer_hisilicon = { + 'description': 'Hisilicon', + 'flags': [ + ['RTE_USE_C11_MEM_MODEL', true], + ['RTE_CACHE_LINE_SIZE', 128],
Just want to double check. One Kunpeng920 box I can access have cache line size 64B.
I have a question, which level does RTE_CACHE_LINE_SIZE refer to? For kunpeng920, L1/L2 cache size is 64B L3 is 128B
Got it. I think RTE_CACHE_LINE_SIZE is not defined for a certain level of cache. Data can be prefetched into any level of cache by using different APIs.
So our current configuration should be fine.
Agree.
Thanks.
+ ['RTE_MAX_NUMA_NODES', 4] + ], + 'part_number_config': { + '0xd01': { + 'machine_args': ['-march=armv8.2-a+crypto', + '-mtune=tsv110'], + 'flag': [['RTE_MACHINE', '"kunpeng920"'], + ['RTE_MAX_LCORE', 128], + ['RTE_ARM_FEATURE_ATOMICS', true] + ] + } + } +} + implementer_ampere = { 'description': 'Ampere Computing', 'flags': [ @@ -190,6 +209,7 @@ implementers = { 'generic': implementer_generic, '0x41': implementer_arm, '0x43': implementer_cavium, + '0x48': implementer_hisilicon, '0x50': implementer_ampere, '0x51': implementer_qualcomm, '0x56': implementer_marvell, -- 2.7.4
.
在 2021/3/25 15:45, Ruifeng Wang 写道:
-----Original Message----- From: oulijun <oulijun@huawei.com> Sent: Thursday, March 25, 2021 3:22 PM To: Ruifeng Wang <Ruifeng.Wang@arm.com>; thomas@monjalon.net; ferruh.yigit@intel.com Cc: dev@dpdk.org; linuxarm@openeuler.org; nd <nd@arm.com> Subject: Re: [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon kunpeng920 implementer
在 2021/3/23 23:40, Ruifeng Wang 写道:
-----Original Message----- From: oulijun <oulijun@huawei.com> Sent: Tuesday, March 23, 2021 9:52 PM To: Ruifeng Wang <Ruifeng.Wang@arm.com>; thomas@monjalon.net; ferruh.yigit@intel.com Cc: dev@dpdk.org; linuxarm@openeuler.org; nd <nd@arm.com> Subject: Re: [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon kunpeng920 implementer
2021/3/23 16:07, Ruifeng Wang д :
-----Original Message----- From: dev <dev-bounces@dpdk.org> On Behalf Of Lijun Ou Sent: Wednesday, March 10, 2021 9:36 AM To: thomas@monjalon.net; ferruh.yigit@intel.com Cc: dev@dpdk.org; linuxarm@openeuler.org Subject: [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon kunpeng920 implementer
Here addes Kunpeng920 config back which was deleted.
There was no Kunpeng920 specific config before change 91c730fd4e09. It would fall back to generic build because the behavior was to do generic build for unknown implementor / part number.
What should we do with this patch? This is because we cannot compile on the Kunpeng 920 server without adding generic build.
Fixes: 91c730fd4e09 ("config/arm: remove unused or superfluous variables")
Signed-off-by: Chengchang Tang <tangchengchang@huawei.com> Signed-off-by: Lijun Ou <oulijun@huawei.com> --- V1->V2: - rewrite patch title. - split the patch into two. --- config/arm/meson.build | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+)
diff --git a/config/arm/meson.build b/config/arm/meson.build index 00bc461..3826900 100644 --- a/config/arm/meson.build +++ b/config/arm/meson.build @@ -133,6 +133,25 @@ implementer_cavium = { } }
+implementer_hisilicon = { + 'description': 'Hisilicon', + 'flags': [ + ['RTE_USE_C11_MEM_MODEL', true], + ['RTE_CACHE_LINE_SIZE', 128],
Just want to double check. One Kunpeng920 box I can access have cache line size 64B.
I have a question, which level does RTE_CACHE_LINE_SIZE refer to? For kunpeng920, L1/L2 cache size is 64B L3 is 128B
Got it. I think RTE_CACHE_LINE_SIZE is not defined for a certain level of cache. Data can be prefetched into any level of cache by using different APIs.
So our current configuration should be fine.
Agree.
Thanks.
+ ['RTE_MAX_NUMA_NODES', 4] + ], + 'part_number_config': { + '0xd01': { + 'machine_args': ['-march=armv8.2-a+crypto', + '-mtune=tsv110'], + 'flag': [['RTE_MACHINE', '"kunpeng920"'], + ['RTE_MAX_LCORE', 128], + ['RTE_ARM_FEATURE_ATOMICS', true] + ] + } + } +} + implementer_ampere = { 'description': 'Ampere Computing', 'flags': [ @@ -190,6 +209,7 @@ implementers = { 'generic': implementer_generic, '0x41': implementer_arm, '0x43': implementer_cavium, + '0x48': implementer_hisilicon, '0x50': implementer_ampere, '0x51': implementer_qualcomm, '0x56': implementer_marvell, -- 2.7.4
.
-----Original Message----- From: oulijun <oulijun@huawei.com> Sent: Thursday, March 25, 2021 3:56 PM To: Ruifeng Wang <Ruifeng.Wang@arm.com>; thomas@monjalon.net; ferruh.yigit@intel.com Cc: dev@dpdk.org; linuxarm@openeuler.org; nd <nd@arm.com> Subject: Re: [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon kunpeng920 implementer
在 2021/3/25 15:45, Ruifeng Wang 写道:
-----Original Message----- From: oulijun <oulijun@huawei.com> Sent: Thursday, March 25, 2021 3:22 PM To: Ruifeng Wang <Ruifeng.Wang@arm.com>; thomas@monjalon.net; ferruh.yigit@intel.com Cc: dev@dpdk.org; linuxarm@openeuler.org; nd <nd@arm.com> Subject: Re: [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon kunpeng920 implementer
在 2021/3/23 23:40, Ruifeng Wang 写道:
-----Original Message----- From: oulijun <oulijun@huawei.com> Sent: Tuesday, March 23, 2021 9:52 PM To: Ruifeng Wang <Ruifeng.Wang@arm.com>; thomas@monjalon.net; ferruh.yigit@intel.com Cc: dev@dpdk.org; linuxarm@openeuler.org; nd <nd@arm.com> Subject: Re: [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon kunpeng920 implementer
2021/3/23 16:07, Ruifeng Wang д :
> -----Original Message----- > From: dev <dev-bounces@dpdk.org> On Behalf Of Lijun Ou > Sent: Wednesday, March 10, 2021 9:36 AM > To: thomas@monjalon.net; ferruh.yigit@intel.com > Cc: dev@dpdk.org; linuxarm@openeuler.org > Subject: [dpdk-dev] [PATCH V2 1/4] config/arm: add Hisilicon > kunpeng920 implementer > > Here addes Kunpeng920 config back which was deleted.
There was no Kunpeng920 specific config before change 91c730fd4e09. It would fall back to generic build because the behavior was to do generic build for unknown implementor / part number.
What should we do with this patch? This is because we cannot compile on the Kunpeng 920 server without adding generic build.
I see the need to add config for Kunpeng 920. IMO, the commit message can be refined. With commit message update, Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> > Fixes: 91c730fd4e09 ("config/arm: remove unused or superfluous > variables") > > Signed-off-by: Chengchang Tang <tangchengchang@huawei.com> > Signed-off-by: Lijun Ou <oulijun@huawei.com> > --- > V1->V2: > - rewrite patch title. > - split the patch into two. > --- > config/arm/meson.build | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/config/arm/meson.build b/config/arm/meson.build > index > 00bc461..3826900 100644 > --- a/config/arm/meson.build > +++ b/config/arm/meson.build > @@ -133,6 +133,25 @@ implementer_cavium = { > } > } > > +implementer_hisilicon = { > + 'description': 'Hisilicon', > + 'flags': [ > + ['RTE_USE_C11_MEM_MODEL', true], > + ['RTE_CACHE_LINE_SIZE', 128],
Just want to double check. One Kunpeng920 box I can access have cache line size 64B.
I have a question, which level does RTE_CACHE_LINE_SIZE refer to? For kunpeng920, L1/L2 cache size is 64B L3 is 128B
Got it. I think RTE_CACHE_LINE_SIZE is not defined for a certain level of cache. Data can be prefetched into any level of cache by using different APIs.
So our current configuration should be fine.
Agree.
Thanks. > + ['RTE_MAX_NUMA_NODES', 4] > + ], > + 'part_number_config': { > + '0xd01': { > + 'machine_args': ['-march=armv8.2-a+crypto', > + '-mtune=tsv110'], > + 'flag': [['RTE_MACHINE', '"kunpeng920"'], > + ['RTE_MAX_LCORE', 128], > + ['RTE_ARM_FEATURE_ATOMICS', true] > + ] > + } > + } > +} > + > implementer_ampere = { > 'description': 'Ampere Computing', > 'flags': [ > @@ -190,6 +209,7 @@ implementers = { > 'generic': implementer_generic, > '0x41': implementer_arm, > '0x43': implementer_cavium, > + '0x48': implementer_hisilicon, > '0x50': implementer_ampere, > '0x51': implementer_qualcomm, > '0x56': implementer_marvell, > -- > 2.7.4
.
On Wed, Mar 10, 2021 at 7:05 AM Lijun Ou <oulijun@huawei.com> wrote:
Here addes Kunpeng920 config back which was deleted.
Please fix the commit message. With commit message update: Acked-by: Jerin Jacob <jerinj@marvell.com>
Fixes: 91c730fd4e09 ("config/arm: remove unused or superfluous variables")
Signed-off-by: Chengchang Tang <tangchengchang@huawei.com> Signed-off-by: Lijun Ou <oulijun@huawei.com> --- V1->V2: - rewrite patch title. - split the patch into two. --- config/arm/meson.build | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+)
diff --git a/config/arm/meson.build b/config/arm/meson.build index 00bc461..3826900 100644 --- a/config/arm/meson.build +++ b/config/arm/meson.build @@ -133,6 +133,25 @@ implementer_cavium = { } }
+implementer_hisilicon = { + 'description': 'Hisilicon', + 'flags': [ + ['RTE_USE_C11_MEM_MODEL', true], + ['RTE_CACHE_LINE_SIZE', 128], + ['RTE_MAX_NUMA_NODES', 4] + ], + 'part_number_config': { + '0xd01': { + 'machine_args': ['-march=armv8.2-a+crypto', + '-mtune=tsv110'], + 'flag': [['RTE_MACHINE', '"kunpeng920"'], + ['RTE_MAX_LCORE', 128], + ['RTE_ARM_FEATURE_ATOMICS', true] + ] + } + } +} + implementer_ampere = { 'description': 'Ampere Computing', 'flags': [ @@ -190,6 +209,7 @@ implementers = { 'generic': implementer_generic, '0x41': implementer_arm, '0x43': implementer_cavium, + '0x48': implementer_hisilicon, '0x50': implementer_ampere, '0x51': implementer_qualcomm, '0x56': implementer_marvell, -- 2.7.4
Here add Hisilicon kunpeng930 config back which was deleted. Fixes: 91c730fd4e09 ("config/arm: remove unused or superfluous variables") Signed-off-by: Chengchang Tang <tangchengchang@huawei.com> Signed-off-by: Lijun Ou <oulijun@huawei.com> --- -rewrite the patch title. -split the patch into two. --- config/arm/meson.build | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/config/arm/meson.build b/config/arm/meson.build index 3826900..a3f42c3 100644 --- a/config/arm/meson.build +++ b/config/arm/meson.build @@ -148,6 +148,13 @@ implementer_hisilicon = { ['RTE_MAX_LCORE', 128], ['RTE_ARM_FEATURE_ATOMICS', true] ] + }, + '0xd02': { + 'machine_args': ['-march=armv8.2-a+crypto+sve'], + 'flag': [['RTE_MACHINE', '"kunpeng930"'], + ['RTE_MAX_LCORE', 256], + ['RTE_ARM_FEATURE_ATOMICS', true] + ] } } } -- 2.7.4
On Wed, Mar 10, 2021 at 7:05 AM Lijun Ou <oulijun@huawei.com> wrote:
Here add Hisilicon kunpeng930 config back which was deleted.
Please fix the commit message. I think, 1/4 and 2/4 cab squashed. With above change: Acked-by: Jerin Jacob <jerinj@marvell.com>
Fixes: 91c730fd4e09 ("config/arm: remove unused or superfluous variables")
Signed-off-by: Chengchang Tang <tangchengchang@huawei.com> Signed-off-by: Lijun Ou <oulijun@huawei.com> --- -rewrite the patch title. -split the patch into two. --- config/arm/meson.build | 7 +++++++ 1 file changed, 7 insertions(+)
diff --git a/config/arm/meson.build b/config/arm/meson.build index 3826900..a3f42c3 100644 --- a/config/arm/meson.build +++ b/config/arm/meson.build @@ -148,6 +148,13 @@ implementer_hisilicon = { ['RTE_MAX_LCORE', 128], ['RTE_ARM_FEATURE_ATOMICS', true] ] + }, + '0xd02': { + 'machine_args': ['-march=armv8.2-a+crypto+sve'], + 'flag': [['RTE_MACHINE', '"kunpeng930"'], + ['RTE_MAX_LCORE', 256], + ['RTE_ARM_FEATURE_ATOMICS', true] + ] } } } -- 2.7.4
Here add arm64 cross compile support for Hisilicon kunpeng920. Signed-off-by: Chengchang Tang <tangchengchang@huawei.com> Signed-off-by: Lijun Ou <oulijun@huawei.com> --- config/arm/arm64_kunpeng920_linux_gcc | 19 +++++++++++++++++++ doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst | 4 ++++ 2 files changed, 23 insertions(+) create mode 100644 config/arm/arm64_kunpeng920_linux_gcc diff --git a/config/arm/arm64_kunpeng920_linux_gcc b/config/arm/arm64_kunpeng920_linux_gcc new file mode 100644 index 0000000..3eeb2e9 --- /dev/null +++ b/config/arm/arm64_kunpeng920_linux_gcc @@ -0,0 +1,19 @@ +[binaries] +c = 'aarch64-linux-gnu-gcc' +cpp = 'aarch64-linux-gnu-cpp' +ar = 'aarch64-linux-gnu-gcc-ar' +strip = 'aarch64-linux-gnu-strip' +pkgconfig = 'aarch64-linux-gnu-pkg-config' +pcap-config = '' + +[host_machine] +system = 'linux' +cpu_family = 'aarch64' +cpu = 'armv8-a' +endian = 'little' + +[properties] +implementer_id = '0x48' +part_number = '0xd01' +max_lcores = 128 +max_numa_nodes = 4 diff --git a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst index faaf24b..afe4f8e 100644 --- a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst +++ b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst @@ -197,6 +197,7 @@ you may use various combinations of implementer/part number:: 'generic': Generic armv8 '0x41': Arm '0x43': Cavium + '0x48': Hisilicon '0x50': Ampere Computing '0x56': Marvell ARMADA 'dpaa': NXP DPAA @@ -219,6 +220,9 @@ you may use various combinations of implementer/part number:: '0xaf': thunderx2t99 '0xb2': octeontx2 + Supported part_numbers for 0x48: + '0xd01': kunpeng920 + Supported part_numbers for 0x50: '0x0': emag -- 2.7.4
-----Original Message----- From: dev <dev-bounces@dpdk.org> On Behalf Of Lijun Ou Sent: Wednesday, March 10, 2021 9:36 AM To: thomas@monjalon.net; ferruh.yigit@intel.com Cc: dev@dpdk.org; linuxarm@openeuler.org Subject: [dpdk-dev] [PATCH V2 3/4] config/arm: add kunpeng920 meson cross compile target
Here add arm64 cross compile support for Hisilicon kunpeng920.
Signed-off-by: Chengchang Tang <tangchengchang@huawei.com> Signed-off-by: Lijun Ou <oulijun@huawei.com> --- config/arm/arm64_kunpeng920_linux_gcc | 19 +++++++++++++++++++ doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst | 4 ++++ 2 files changed, 23 insertions(+) create mode 100644 config/arm/arm64_kunpeng920_linux_gcc
diff --git a/config/arm/arm64_kunpeng920_linux_gcc b/config/arm/arm64_kunpeng920_linux_gcc new file mode 100644 index 0000000..3eeb2e9 --- /dev/null +++ b/config/arm/arm64_kunpeng920_linux_gcc @@ -0,0 +1,19 @@ +[binaries] +c = 'aarch64-linux-gnu-gcc' +cpp = 'aarch64-linux-gnu-cpp' +ar = 'aarch64-linux-gnu-gcc-ar' +strip = 'aarch64-linux-gnu-strip' +pkgconfig = 'aarch64-linux-gnu-pkg-config' +pcap-config = '' + +[host_machine] +system = 'linux' +cpu_family = 'aarch64' +cpu = 'armv8-a' +endian = 'little' + +[properties] +implementer_id = '0x48' +part_number = '0xd01' +max_lcores = 128 +max_numa_nodes = 4 diff --git a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst index faaf24b..afe4f8e 100644 --- a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst +++ b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst @@ -197,6 +197,7 @@ you may use various combinations of implementer/part number:: 'generic': Generic armv8 '0x41': Arm '0x43': Cavium + '0x48': Hisilicon '0x50': Ampere Computing '0x56': Marvell ARMADA 'dpaa': NXP DPAA @@ -219,6 +220,9 @@ you may use various combinations of implementer/part number:: '0xaf': thunderx2t99 '0xb2': octeontx2
+ Supported part_numbers for 0x48: + '0xd01': kunpeng920 + Supported part_numbers for 0x50: '0x0': emag
-- 2.7.4
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
On Thu, Mar 25, 2021 at 1:18 PM Ruifeng Wang <Ruifeng.Wang@arm.com> wrote:
-----Original Message----- From: dev <dev-bounces@dpdk.org> On Behalf Of Lijun Ou Sent: Wednesday, March 10, 2021 9:36 AM To: thomas@monjalon.net; ferruh.yigit@intel.com Cc: dev@dpdk.org; linuxarm@openeuler.org Subject: [dpdk-dev] [PATCH V2 3/4] config/arm: add kunpeng920 meson cross compile target
Suggested title: config/arm: add kunpeng920 cross target
Here add arm64 cross compile support for Hisilicon kunpeng920.
Suggested change: Add support for Hisilicon kunpeng920 cross target. With the above change: Acked-by: Jerin Jacob <jerinj@marvell.com>
Signed-off-by: Chengchang Tang <tangchengchang@huawei.com> Signed-off-by: Lijun Ou <oulijun@huawei.com> --- config/arm/arm64_kunpeng920_linux_gcc | 19 +++++++++++++++++++ doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst | 4 ++++ 2 files changed, 23 insertions(+) create mode 100644 config/arm/arm64_kunpeng920_linux_gcc
diff --git a/config/arm/arm64_kunpeng920_linux_gcc b/config/arm/arm64_kunpeng920_linux_gcc new file mode 100644 index 0000000..3eeb2e9 --- /dev/null +++ b/config/arm/arm64_kunpeng920_linux_gcc @@ -0,0 +1,19 @@ +[binaries] +c = 'aarch64-linux-gnu-gcc' +cpp = 'aarch64-linux-gnu-cpp' +ar = 'aarch64-linux-gnu-gcc-ar' +strip = 'aarch64-linux-gnu-strip' +pkgconfig = 'aarch64-linux-gnu-pkg-config' +pcap-config = '' + +[host_machine] +system = 'linux' +cpu_family = 'aarch64' +cpu = 'armv8-a' +endian = 'little' + +[properties] +implementer_id = '0x48' +part_number = '0xd01' +max_lcores = 128 +max_numa_nodes = 4 diff --git a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst index faaf24b..afe4f8e 100644 --- a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst +++ b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst @@ -197,6 +197,7 @@ you may use various combinations of implementer/part number:: 'generic': Generic armv8 '0x41': Arm '0x43': Cavium + '0x48': Hisilicon '0x50': Ampere Computing '0x56': Marvell ARMADA 'dpaa': NXP DPAA @@ -219,6 +220,9 @@ you may use various combinations of implementer/part number:: '0xaf': thunderx2t99 '0xb2': octeontx2
+ Supported part_numbers for 0x48: + '0xd01': kunpeng920 + Supported part_numbers for 0x50: '0x0': emag
-- 2.7.4
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
Here add arm64 cross compile support for Hisilicon kunpeng930. Signed-off-by: Chengchang Tang <tangchengchang@huawei.com> Signed-off-by: Lijun Ou <oulijun@huawei.com> --- config/arm/arm64_kunpeng930_linux_gcc | 19 +++++++++++++++++++ doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst | 1 + 2 files changed, 20 insertions(+) create mode 100644 config/arm/arm64_kunpeng930_linux_gcc diff --git a/config/arm/arm64_kunpeng930_linux_gcc b/config/arm/arm64_kunpeng930_linux_gcc new file mode 100644 index 0000000..464e44a --- /dev/null +++ b/config/arm/arm64_kunpeng930_linux_gcc @@ -0,0 +1,19 @@ +[binaries] +c = 'aarch64-linux-gnu-gcc' +cpp = 'aarch64-linux-gnu-cpp' +ar = 'aarch64-linux-gnu-gcc-ar' +strip = 'aarch64-linux-gnu-strip' +pkgconfig = 'aarch64-linux-gnu-pkg-config' +pcap-config = '' + +[host_machine] +system = 'linux' +cpu_family = 'aarch64' +cpu = 'armv8-a' +endian = 'little' + +[properties] +implementer_id = '0x48' +part_number = '0xd02' +max_lcores = 256 +max_numa_nodes = 4 diff --git a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst index afe4f8e..1a54436 100644 --- a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst +++ b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst @@ -222,6 +222,7 @@ you may use various combinations of implementer/part number:: Supported part_numbers for 0x48: '0xd01': kunpeng920 + '0xd02': kunpeng930 Supported part_numbers for 0x50: '0x0': emag -- 2.7.4
-----Original Message----- From: dev <dev-bounces@dpdk.org> On Behalf Of Lijun Ou Sent: Wednesday, March 10, 2021 9:36 AM To: thomas@monjalon.net; ferruh.yigit@intel.com Cc: dev@dpdk.org; linuxarm@openeuler.org Subject: [dpdk-dev] [PATCH V2 4/4] config/arm: add kunpeng930 meson cross compile target
Here add arm64 cross compile support for Hisilicon kunpeng930.
Signed-off-by: Chengchang Tang <tangchengchang@huawei.com> Signed-off-by: Lijun Ou <oulijun@huawei.com> --- config/arm/arm64_kunpeng930_linux_gcc | 19 +++++++++++++++++++ doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst | 1 + 2 files changed, 20 insertions(+) create mode 100644 config/arm/arm64_kunpeng930_linux_gcc
diff --git a/config/arm/arm64_kunpeng930_linux_gcc b/config/arm/arm64_kunpeng930_linux_gcc new file mode 100644 index 0000000..464e44a --- /dev/null +++ b/config/arm/arm64_kunpeng930_linux_gcc @@ -0,0 +1,19 @@ +[binaries] +c = 'aarch64-linux-gnu-gcc' +cpp = 'aarch64-linux-gnu-cpp' +ar = 'aarch64-linux-gnu-gcc-ar' +strip = 'aarch64-linux-gnu-strip' +pkgconfig = 'aarch64-linux-gnu-pkg-config' +pcap-config = '' + +[host_machine] +system = 'linux' +cpu_family = 'aarch64' +cpu = 'armv8-a' +endian = 'little' + +[properties] +implementer_id = '0x48' +part_number = '0xd02' +max_lcores = 256 +max_numa_nodes = 4 diff --git a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst index afe4f8e..1a54436 100644 --- a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst +++ b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst @@ -222,6 +222,7 @@ you may use various combinations of implementer/part number::
Supported part_numbers for 0x48: '0xd01': kunpeng920 + '0xd02': kunpeng930
Supported part_numbers for 0x50: '0x0': emag -- 2.7.4
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
On Wed, Mar 10, 2021 at 7:05 AM Lijun Ou <oulijun@huawei.com> wrote:
Here add arm64 cross compile support for Hisilicon kunpeng930.
Signed-off-by: Chengchang Tang <tangchengchang@huawei.com> Signed-off-by: Lijun Ou <oulijun@huawei.com>
Similar comments to 3/4 patch. With change: Acked-by: Jerin Jacob <jerinj@marvell.com>
--- config/arm/arm64_kunpeng930_linux_gcc | 19 +++++++++++++++++++ doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst | 1 + 2 files changed, 20 insertions(+) create mode 100644 config/arm/arm64_kunpeng930_linux_gcc
diff --git a/config/arm/arm64_kunpeng930_linux_gcc b/config/arm/arm64_kunpeng930_linux_gcc new file mode 100644 index 0000000..464e44a --- /dev/null +++ b/config/arm/arm64_kunpeng930_linux_gcc @@ -0,0 +1,19 @@ +[binaries] +c = 'aarch64-linux-gnu-gcc' +cpp = 'aarch64-linux-gnu-cpp' +ar = 'aarch64-linux-gnu-gcc-ar' +strip = 'aarch64-linux-gnu-strip' +pkgconfig = 'aarch64-linux-gnu-pkg-config' +pcap-config = '' + +[host_machine] +system = 'linux' +cpu_family = 'aarch64' +cpu = 'armv8-a' +endian = 'little' + +[properties] +implementer_id = '0x48' +part_number = '0xd02' +max_lcores = 256 +max_numa_nodes = 4 diff --git a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst index afe4f8e..1a54436 100644 --- a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst +++ b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst @@ -222,6 +222,7 @@ you may use various combinations of implementer/part number::
Supported part_numbers for 0x48: '0xd01': kunpeng920 + '0xd02': kunpeng930
Supported part_numbers for 0x50: '0x0': emag -- 2.7.4
Hi, Thomas&&Ferruh Do I need to send a patchset? 在 2021/3/10 9:35, Lijun Ou 写道:
This series add meson build for Hisilicon kunpeng CPU.
Lijun Ou (4): config/arm: add Hisilicon kunpeng920 implementer config/arm: add Hisilicon kunpeng930 implementer config/arm: add kunpeng920 meson cross compile target config/arm: add kunpeng930 meson cross compile target
config/arm/arm64_kunpeng920_linux_gcc | 19 +++++++++++++++ config/arm/arm64_kunpeng930_linux_gcc | 19 +++++++++++++++ config/arm/meson.build | 27 ++++++++++++++++++++++ .../linux_gsg/cross_build_dpdk_for_arm64.rst | 5 ++++ 4 files changed, 70 insertions(+) create mode 100644 config/arm/arm64_kunpeng920_linux_gcc create mode 100644 config/arm/arm64_kunpeng930_linux_gcc
25/03/2021 09:54, oulijun:
Hi, Thomas&&Ferruh
Do I need to send a patchset?
??? What do you mean?
在 2021/3/10 9:35, Lijun Ou 写道:
This series add meson build for Hisilicon kunpeng CPU.
Lijun Ou (4): config/arm: add Hisilicon kunpeng920 implementer config/arm: add Hisilicon kunpeng930 implementer config/arm: add kunpeng920 meson cross compile target config/arm: add kunpeng930 meson cross compile target
Ruifeng has reviewed-by. Does anyone else have any comments? Is it necessary to send the V2? 在 2021/3/25 17:07, Thomas Monjalon 写道:
25/03/2021 09:54, oulijun:
Hi, Thomas&&Ferruh
Do I need to send a patchset?
??? What do you mean?
在 2021/3/10 9:35, Lijun Ou 写道:
This series add meson build for Hisilicon kunpeng CPU.
Lijun Ou (4): config/arm: add Hisilicon kunpeng920 implementer config/arm: add Hisilicon kunpeng930 implementer config/arm: add kunpeng920 meson cross compile target config/arm: add kunpeng930 meson cross compile target
.
25/03/2021 12:17, oulijun:
Ruifeng has reviewed-by. Does anyone else have any comments? Is it necessary to send the V2?
v2 for what? There is a change?
在 2021/3/25 17:07, Thomas Monjalon 写道:
25/03/2021 09:54, oulijun:
Hi, Thomas&&Ferruh
Do I need to send a patchset?
??? What do you mean?
在 2021/3/10 9:35, Lijun Ou 写道:
This series add meson build for Hisilicon kunpeng CPU.
Lijun Ou (4): config/arm: add Hisilicon kunpeng920 implementer config/arm: add Hisilicon kunpeng930 implementer config/arm: add kunpeng920 meson cross compile target config/arm: add kunpeng930 meson cross compile target
.
在 2021/3/25 20:19, Thomas Monjalon 写道:
25/03/2021 12:17, oulijun:
Ruifeng has reviewed-by. Does anyone else have any comments? Is it necessary to send the V2?
v2 for what? There is a change?
No. no change.
在 2021/3/25 17:07, Thomas Monjalon 写道:
25/03/2021 09:54, oulijun:
Hi, Thomas&&Ferruh
Do I need to send a patchset?
??? What do you mean?
在 2021/3/10 9:35, Lijun Ou 写道:
This series add meson build for Hisilicon kunpeng CPU.
Lijun Ou (4): config/arm: add Hisilicon kunpeng920 implementer config/arm: add Hisilicon kunpeng930 implementer config/arm: add kunpeng920 meson cross compile target config/arm: add kunpeng930 meson cross compile target
.
.
25/03/2021 14:26, oulijun:
在 2021/3/25 20:19, Thomas Monjalon 写道:
25/03/2021 12:17, oulijun:
Ruifeng has reviewed-by. Does anyone else have any comments? Is it necessary to send the V2?
v2 for what? There is a change?
No. no change.
So why are you asking to send a v2?
在 2021/3/25 17:07, Thomas Monjalon 写道:
25/03/2021 09:54, oulijun:
Hi, Thomas&&Ferruh
Do I need to send a patchset?
??? What do you mean?
在 2021/3/10 9:35, Lijun Ou 写道:
This series add meson build for Hisilicon kunpeng CPU.
Lijun Ou (4): config/arm: add Hisilicon kunpeng920 implementer config/arm: add Hisilicon kunpeng930 implementer config/arm: add kunpeng920 meson cross compile target config/arm: add kunpeng930 meson cross compile target
在 2021/3/25 22:40, Thomas Monjalon 写道:
25/03/2021 14:26, oulijun:
在 2021/3/25 20:19, Thomas Monjalon 写道:
25/03/2021 12:17, oulijun:
Ruifeng has reviewed-by. Does anyone else have any comments? Is it necessary to send the V2?
v2 for what? There is a change?
No. no change.
So why are you asking to send a v2?
Sorry. My suggestion is to ask if you need to reset the patch based on the latest date. If not, wait for other's reviews and to incorporate the patch.
在 2021/3/25 17:07, Thomas Monjalon 写道:
25/03/2021 09:54, oulijun:
Hi, Thomas&&Ferruh
Do I need to send a patchset?
??? What do you mean?
在 2021/3/10 9:35, Lijun Ou 写道: > This series add meson build for Hisilicon kunpeng CPU. > > Lijun Ou (4): > config/arm: add Hisilicon kunpeng920 implementer > config/arm: add Hisilicon kunpeng930 implementer > config/arm: add kunpeng920 meson cross compile target > config/arm: add kunpeng930 meson cross compile target
.
<snip>
在 2021/3/25 22:40, Thomas Monjalon 写道:
25/03/2021 14:26, oulijun:
在 2021/3/25 20:19, Thomas Monjalon 写道:
25/03/2021 12:17, oulijun:
Ruifeng has reviewed-by. Does anyone else have any comments? Is it necessary to send the V2?
v2 for what? There is a change?
No. no change.
So why are you asking to send a v2?
Sorry. My suggestion is to ask if you need to reset the patch based on the latest date. If not, wait for other's reviews and to incorporate the patch.
I suggest to rework this patch once [1] is merged. [1] http://patches.dpdk.org/project/dpdk/cover/1617186371-18699-1-git-send-email...
在 2021/3/25 17:07, Thomas Monjalon 写道:
25/03/2021 09:54, oulijun: > Hi, Thomas&&Ferruh > > Do I need to send a patchset?
??? What do you mean?
> 在 2021/3/10 9:35, Lijun Ou 写道: >> This series add meson build for Hisilicon kunpeng CPU. >> >> Lijun Ou (4): >> config/arm: add Hisilicon kunpeng920 implementer >> config/arm: add Hisilicon kunpeng930 implementer >> config/arm: add kunpeng920 meson cross compile target >> config/arm: add kunpeng930 meson cross compile target
.
在 2021/4/6 3:50, Honnappa Nagarahalli 写道:
<snip>
在 2021/3/25 22:40, Thomas Monjalon 写道:
25/03/2021 14:26, oulijun:
在 2021/3/25 20:19, Thomas Monjalon 写道:
25/03/2021 12:17, oulijun:
Ruifeng has reviewed-by. Does anyone else have any comments? Is it necessary to send the V2?
v2 for what? There is a change?
No. no change.
So why are you asking to send a v2?
Sorry. My suggestion is to ask if you need to reset the patch based on the latest date. If not, wait for other's reviews and to incorporate the patch.
I suggest to rework this patch once [1] is merged.
[1] http://patches.dpdk.org/project/dpdk/cover/1617186371-18699-1-git-send-email...
I checked it out, and this series has not been received, and I don't think it can be reworked based on it.
在 2021/3/25 17:07, Thomas Monjalon 写道: > 25/03/2021 09:54, oulijun: >> Hi, Thomas&&Ferruh >> >> Do I need to send a patchset? > > ??? > What do you mean? > >> 在 2021/3/10 9:35, Lijun Ou 写道: >>> This series add meson build for Hisilicon kunpeng CPU. >>> >>> Lijun Ou (4): >>> config/arm: add Hisilicon kunpeng920 implementer >>> config/arm: add Hisilicon kunpeng930 implementer >>> config/arm: add kunpeng920 meson cross compile target >>> config/arm: add kunpeng930 meson cross compile target
.
<snip>
在 2021/3/25 22:40, Thomas Monjalon 写道:
25/03/2021 14:26, oulijun:
在 2021/3/25 20:19, Thomas Monjalon 写道:
25/03/2021 12:17, oulijun: > Ruifeng has reviewed-by. Does anyone else have any comments? Is > it necessary to send the V2?
v2 for what? There is a change?
No. no change.
So why are you asking to send a v2?
Sorry. My suggestion is to ask if you need to reset the patch based on the latest date. If not, wait for other's reviews and to incorporate the
patch.
I suggest to rework this patch once [1] is merged.
[1] http://patches.dpdk.org/project/dpdk/cover/1617186371-18699-1-git-send -email-juraj.linkes@pantheon.tech/
I checked it out, and this series has not been received, and I don't think it can be reworked based on it. It would be good to review the series, test it on your platform and provide any comments you might have. It will help make progress on the series.
> 在 2021/3/25 17:07, Thomas Monjalon 写道: >> 25/03/2021 09:54, oulijun: >>> Hi, Thomas&&Ferruh >>> >>> Do I need to send a patchset? >> >> ??? >> What do you mean? >> >>> 在 2021/3/10 9:35, Lijun Ou 写道: >>>> This series add meson build for Hisilicon kunpeng CPU. >>>> >>>> Lijun Ou (4): >>>> config/arm: add Hisilicon kunpeng920 implementer >>>> config/arm: add Hisilicon kunpeng930 implementer >>>> config/arm: add kunpeng920 meson cross compile target >>>> config/arm: add kunpeng930 meson cross compile target
.
在 2021/4/7 10:19, Honnappa Nagarahalli 写道:
<snip>
在 2021/3/25 22:40, Thomas Monjalon 写道:
25/03/2021 14:26, oulijun:
在 2021/3/25 20:19, Thomas Monjalon 写道: > 25/03/2021 12:17, oulijun: >> Ruifeng has reviewed-by. Does anyone else have any comments? Is >> it necessary to send the V2? > > v2 for what? There is a change? > No. no change.
So why are you asking to send a v2?
Sorry. My suggestion is to ask if you need to reset the patch based on the latest date. If not, wait for other's reviews and to incorporate the
patch.
I suggest to rework this patch once [1] is merged.
[1] http://patches.dpdk.org/project/dpdk/cover/1617186371-18699-1-git-send -email-juraj.linkes@pantheon.tech/
I checked it out, and this series has not been received, and I don't think it can be reworked based on it. It would be good to review the series, test it on your platform and provide any comments you might have. It will help make progress on the series.
Hi, Thomas && Ferruh Yigit What's your opinion? Thanks
>> 在 2021/3/25 17:07, Thomas Monjalon 写道: >>> 25/03/2021 09:54, oulijun: >>>> Hi, Thomas&&Ferruh >>>> >>>> Do I need to send a patchset? >>> >>> ??? >>> What do you mean? >>> >>>> 在 2021/3/10 9:35, Lijun Ou 写道: >>>>> This series add meson build for Hisilicon kunpeng CPU. >>>>> >>>>> Lijun Ou (4): >>>>> config/arm: add Hisilicon kunpeng920 implementer >>>>> config/arm: add Hisilicon kunpeng930 implementer >>>>> config/arm: add kunpeng920 meson cross compile target >>>>> config/arm: add kunpeng930 meson cross compile target
.
08/04/2021 05:30, oulijun:
在 2021/4/7 10:19, Honnappa Nagarahalli 写道:
在 2021/3/25 22:40, Thomas Monjalon 写道:
25/03/2021 14:26, oulijun: > 在 2021/3/25 20:19, Thomas Monjalon 写道: >> 25/03/2021 12:17, oulijun: >>> Ruifeng has reviewed-by. Does anyone else have any comments? Is >>> it necessary to send the V2? >> >> v2 for what? There is a change? >> > No. no change.
So why are you asking to send a v2?
Sorry. My suggestion is to ask if you need to reset the patch based on the latest date. If not, wait for other's reviews and to incorporate the patch.
I suggest to rework this patch once [1] is merged.
[1] http://patches.dpdk.org/project/dpdk/cover/1617186371-18699-1-git-send -email-juraj.linkes@pantheon.tech/
I checked it out, and this series has not been received, and I don't think it can be reworked based on it. It would be good to review the series, test it on your platform and provide any comments you might have. It will help make progress on the series.
Hi, Thomas && Ferruh Yigit What's your opinion?
Help in review is always good. Please review what you can.
This series add meson build for Hisilicon kunpeng CPU. v2->v3: 1. merge [1/4] and [2/4] patch into one 2. rewrite some titles 3. rewrite commit logs for [2/3] [3/3] 4. add Acked-by and Reviewed-by v1->v2: 1. split [1/2] into two. Lijun Ou (3): config/arm: add Hisilicon kunpeng implementer config/arm: add kunpeng920 cross target config/arm: add kunpeng930 cross target config/arm/arm64_kunpeng920_linux_gcc | 19 +++++++++++++++ config/arm/arm64_kunpeng930_linux_gcc | 19 +++++++++++++++ config/arm/meson.build | 27 ++++++++++++++++++++++ .../linux_gsg/cross_build_dpdk_for_arm64.rst | 5 ++++ 4 files changed, 70 insertions(+) create mode 100644 config/arm/arm64_kunpeng920_linux_gcc create mode 100644 config/arm/arm64_kunpeng930_linux_gcc -- 2.7.4
Here adds configs for Kunpeng server. Fixes: 91c730fd4e09 ("config/arm: remove unused or superfluous variables") Signed-off-by: Chengchang Tang <tangchengchang@huawei.com> Signed-off-by: Lijun Ou <oulijun@huawei.com> Acked-by: Jerin Jacob <jerinj@marvell.com> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com> --- V2->V3: - refined the commit - merge [1/4] and [2/4] into one. V1->V2: - rewrite patch title. - split the patch into two. --- config/arm/meson.build | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/config/arm/meson.build b/config/arm/meson.build index 00bc461..a3f42c3 100644 --- a/config/arm/meson.build +++ b/config/arm/meson.build @@ -133,6 +133,32 @@ implementer_cavium = { } } +implementer_hisilicon = { + 'description': 'Hisilicon', + 'flags': [ + ['RTE_USE_C11_MEM_MODEL', true], + ['RTE_CACHE_LINE_SIZE', 128], + ['RTE_MAX_NUMA_NODES', 4] + ], + 'part_number_config': { + '0xd01': { + 'machine_args': ['-march=armv8.2-a+crypto', + '-mtune=tsv110'], + 'flag': [['RTE_MACHINE', '"kunpeng920"'], + ['RTE_MAX_LCORE', 128], + ['RTE_ARM_FEATURE_ATOMICS', true] + ] + }, + '0xd02': { + 'machine_args': ['-march=armv8.2-a+crypto+sve'], + 'flag': [['RTE_MACHINE', '"kunpeng930"'], + ['RTE_MAX_LCORE', 256], + ['RTE_ARM_FEATURE_ATOMICS', true] + ] + } + } +} + implementer_ampere = { 'description': 'Ampere Computing', 'flags': [ @@ -190,6 +216,7 @@ implementers = { 'generic': implementer_generic, '0x41': implementer_arm, '0x43': implementer_cavium, + '0x48': implementer_hisilicon, '0x50': implementer_ampere, '0x51': implementer_qualcomm, '0x56': implementer_marvell, -- 2.7.4
Add support for Hisilicon kunpeng920 cross target. Signed-off-by: Chengchang Tang <tangchengchang@huawei.com> Signed-off-by: Lijun Ou <oulijun@huawei.com> Acked-by: Jerin Jacob <jerinj@marvell.com> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com> --- V2->V3: - rewrite title - rewrite commit log - add Acked-by and Reviewed-by --- config/arm/arm64_kunpeng920_linux_gcc | 19 +++++++++++++++++++ doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst | 4 ++++ 2 files changed, 23 insertions(+) create mode 100644 config/arm/arm64_kunpeng920_linux_gcc diff --git a/config/arm/arm64_kunpeng920_linux_gcc b/config/arm/arm64_kunpeng920_linux_gcc new file mode 100644 index 0000000..3eeb2e9 --- /dev/null +++ b/config/arm/arm64_kunpeng920_linux_gcc @@ -0,0 +1,19 @@ +[binaries] +c = 'aarch64-linux-gnu-gcc' +cpp = 'aarch64-linux-gnu-cpp' +ar = 'aarch64-linux-gnu-gcc-ar' +strip = 'aarch64-linux-gnu-strip' +pkgconfig = 'aarch64-linux-gnu-pkg-config' +pcap-config = '' + +[host_machine] +system = 'linux' +cpu_family = 'aarch64' +cpu = 'armv8-a' +endian = 'little' + +[properties] +implementer_id = '0x48' +part_number = '0xd01' +max_lcores = 128 +max_numa_nodes = 4 diff --git a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst index faaf24b..afe4f8e 100644 --- a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst +++ b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst @@ -197,6 +197,7 @@ you may use various combinations of implementer/part number:: 'generic': Generic armv8 '0x41': Arm '0x43': Cavium + '0x48': Hisilicon '0x50': Ampere Computing '0x56': Marvell ARMADA 'dpaa': NXP DPAA @@ -219,6 +220,9 @@ you may use various combinations of implementer/part number:: '0xaf': thunderx2t99 '0xb2': octeontx2 + Supported part_numbers for 0x48: + '0xd01': kunpeng920 + Supported part_numbers for 0x50: '0x0': emag -- 2.7.4
Add support for Hisilicon kunpeng930 cross target. Signed-off-by: Chengchang Tang <tangchengchang@huawei.com> Signed-off-by: Lijun Ou <oulijun@huawei.com> Acked-by: Jerin Jacob <jerinj@marvell.com> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com> --- V2->V3: - rewrite title - rewrite commit log - add Acked-by and Reviewed-by --- config/arm/arm64_kunpeng930_linux_gcc | 19 +++++++++++++++++++ doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst | 1 + 2 files changed, 20 insertions(+) create mode 100644 config/arm/arm64_kunpeng930_linux_gcc diff --git a/config/arm/arm64_kunpeng930_linux_gcc b/config/arm/arm64_kunpeng930_linux_gcc new file mode 100644 index 0000000..464e44a --- /dev/null +++ b/config/arm/arm64_kunpeng930_linux_gcc @@ -0,0 +1,19 @@ +[binaries] +c = 'aarch64-linux-gnu-gcc' +cpp = 'aarch64-linux-gnu-cpp' +ar = 'aarch64-linux-gnu-gcc-ar' +strip = 'aarch64-linux-gnu-strip' +pkgconfig = 'aarch64-linux-gnu-pkg-config' +pcap-config = '' + +[host_machine] +system = 'linux' +cpu_family = 'aarch64' +cpu = 'armv8-a' +endian = 'little' + +[properties] +implementer_id = '0x48' +part_number = '0xd02' +max_lcores = 256 +max_numa_nodes = 4 diff --git a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst index afe4f8e..1a54436 100644 --- a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst +++ b/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst @@ -222,6 +222,7 @@ you may use various combinations of implementer/part number:: Supported part_numbers for 0x48: '0xd01': kunpeng920 + '0xd02': kunpeng930 Supported part_numbers for 0x50: '0x0': emag -- 2.7.4
participants (8)
-
Honnappa Nagarahalli -
Jerin Jacob -
Juraj Linkeš -
Lijun Ou -
Min Hu (Connor) -
oulijun
-
Ruifeng Wang -
Thomas Monjalon