Re: [PATCH] acpi: Fix hed module initialization order when it is built-in

On Tue, 12 Nov 2024 19:22:27 +0800 Xiaofei Tan <tanxiaofei@huawei.com> wrote:
When the module hed is built-in, the init order is determined by Makefile order. That order violates expectations. Because the module hed init is behind evged. RAS records can't be handled in the special time window that evged has initialized while hed not. If the number of such RAS records is more than the APEI HEST error source number, the HEST resources could be occupied all, and then could affect subsequent RAS error reporting. Looks good but I'd like a comment in the makefile to cut down on risk of this breaking again.
Signed-off-by: Xiaofei Tan <tanxiaofei@huawei.com> --- drivers/acpi/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/acpi/Makefile b/drivers/acpi/Makefile index 61ca4afe83dc..73a6b490d6a0 100644 --- a/drivers/acpi/Makefile +++ b/drivers/acpi/Makefile @@ -14,6 +14,7 @@ tables.o: $(src)/../../include/$(CONFIG_ACPI_CUSTOM_DSDT_FILE) ; endif
obj-$(CONFIG_ACPI) += tables.o +obj-$(CONFIG_ACPI_HED) += hed.o
Add a comment on why it is up here.
# # ACPI Core Subsystem (Interpreter) @@ -95,7 +96,6 @@ obj-$(CONFIG_ACPI_HOTPLUG_IOAPIC) += ioapic.o obj-$(CONFIG_ACPI_BATTERY) += battery.o obj-$(CONFIG_ACPI_SBS) += sbshc.o obj-$(CONFIG_ACPI_SBS) += sbs.o -obj-$(CONFIG_ACPI_HED) += hed.o obj-$(CONFIG_ACPI_EC_DEBUGFS) += ec_sys.o obj-$(CONFIG_ACPI_BGRT) += bgrt.o obj-$(CONFIG_ACPI_CPPC_LIB) += cppc_acpi.o
participants (1)
-
Jonathan Cameron