- Acc - mailweb.openeuler.org

[PATCH] uadk: parse epoll flag from environment variable
by Zhiqi Song 16 Mar '22

16 Mar '22

From: Wenkai Lin <linwenkai6(a)hisilicon.com> wd_parse_epoll_en is used to parse epoll enable flag from environment variable, it's return value is stored in global variable of each process. When uadk works in synchronize mode, it will check the global variable and decide whether to use wd_ctx_wait. HPRE algorithm(ecc, rsa, dh) is also support epoll wait now. Signed-off-by: Wenkai Lin <linwenkai6(a)hisilicon.com> --- docs/wd_environment_variable | 5 +++ drv/hisi_comp.c | 5 +-- drv/hisi_hpre.c | 3 ++ drv/hisi_qm_udrv.c | 21 ++----------- drv/hisi_sec.c | 15 ++------- include/drv/wd_aead_drv.h | 2 -- include/drv/wd_cipher_drv.h | 2 -- include/drv/wd_comp_drv.h | 2 -- include/drv/wd_digest_drv.h | 2 -- include/hisi_qm_udrv.h | 4 +-- include/wd_alg_common.h | 2 ++ include/wd_util.h | 9 ++++++ wd_aead.c | 24 ++++++--------- wd_cipher.c | 24 ++++++--------- wd_comp.c | 27 ++++++++-------- wd_dh.c | 24 +++++++++------ wd_digest.c | 25 +++++++-------- wd_ecc.c | 24 +++++++++------ wd_rsa.c | 24 +++++++++------ wd_sched.c | 2 +- wd_util.c | 60 ++++++++++++++++++++++++++++-------- 21 files changed, 165 insertions(+), 141 deletions(-) diff --git a/docs/wd_environment_variable b/docs/wd_environment_variable index 3ada5fb..8ac2da7 100644 --- a/docs/wd_environment_variable +++ b/docs/wd_environment_variable @@ -47,6 +47,11 @@ WD_<alg>_ASYNC_POLL_NUM WD_<alg>_ASYNC_POLL_NUM=2@0,4@2 means to configure 2 async polling threads in node0, and 4 polling threads in node2. +WD_<alg>_EPOLL_EN + Define if wd_do_<alg>_sync enable wd_ctx_wait in WD. WD_<alg>_EPOLL_EN=1 + means enable wd_ctx_wait in WD, driver will wait to receive the package until + hardware is done with package, otherwise driver will try to receive the package + directly after the package is sent. 2. User model ============= diff --git a/drv/hisi_comp.c b/drv/hisi_comp.c index 841ae03..43c8688 100644 --- a/drv/hisi_comp.c +++ b/drv/hisi_comp.c @@ -779,6 +779,9 @@ static int hisi_zip_init(struct wd_ctx_config_internal *config, void *priv) qm_priv.sqe_size = sizeof(struct hisi_zip_sqe); qm_priv.op_type = config->ctxs[i].op_type; qm_priv.qp_mode = config->ctxs[i].ctx_mode; + /* Setting the epoll en to 0 for ASYNC ctx */ + qm_priv.epoll_en = (qm_priv.qp_mode == CTX_MODE_SYNC) ? + config->epoll_en : 0; qm_priv.idx = i; h_qp = hisi_qm_alloc_qp(&qm_priv, h_ctx); if (unlikely(!h_qp)) @@ -882,8 +885,6 @@ static int hisi_zip_comp_send(handle_t ctx, struct wd_comp_msg *msg, void *priv) return ret; } - hisi_qm_enable_interrupt(ctx, msg->is_polled); - return 0; } diff --git a/drv/hisi_hpre.c b/drv/hisi_hpre.c index 018fe5b..f0ec540 100644 --- a/drv/hisi_hpre.c +++ b/drv/hisi_hpre.c @@ -465,6 +465,9 @@ static int hpre_init(struct wd_ctx_config_internal *config, void *priv, const ch for (i = 0; i < config->ctx_num; i++) { h_ctx = config->ctxs[i].ctx; qm_priv.qp_mode = config->ctxs[i].ctx_mode; + /* Setting the epoll en to 0 for ASYNC ctx */ + qm_priv.epoll_en = (qm_priv.qp_mode == CTX_MODE_SYNC) ? + config->epoll_en : 0; qm_priv.idx = i; h_qp = hisi_qm_alloc_qp(&qm_priv, h_ctx); if (!h_qp) { diff --git a/drv/hisi_qm_udrv.c b/drv/hisi_qm_udrv.c index be06570..2c0d87c 100644 --- a/drv/hisi_qm_udrv.c +++ b/drv/hisi_qm_udrv.c @@ -309,6 +309,7 @@ static int hisi_qm_setup_info(struct hisi_qp *qp, struct hisi_qm_priv *config) } q_info->qp_mode = config->qp_mode; + q_info->epoll_en = config->epoll_en; q_info->idx = config->idx; q_info->sqe_size = config->sqe_size; q_info->cqc_phase = 1; @@ -479,7 +480,7 @@ static int hisi_qm_recv_single(struct hisi_qm_queue_info *q_info, void *resp) i++; } - q_info->db(q_info, QM_DBELL_CMD_CQ, i, 0); + q_info->db(q_info, QM_DBELL_CMD_CQ, i, q_info->epoll_en); /* only support one thread poll one queue, so no need protect */ q_info->cq_head_index = i; @@ -919,21 +920,3 @@ __u32 hisi_qm_get_list_size(struct wd_datalist *start_node, return lits_size; } - -void hisi_qm_enable_interrupt(handle_t ctx, __u8 enable) -{ - struct hisi_qm_queue_info *q_info; - struct hisi_qp *qp; - handle_t h_qp; - - if (!enable) - return; - - h_qp = (handle_t)wd_ctx_get_priv(ctx); - qp = (struct hisi_qp *)h_qp; - q_info = &qp->q_info; - - pthread_spin_lock(&q_info->lock); - q_info->db(q_info, QM_DBELL_CMD_CQ, q_info->cq_head_index, 1); - pthread_spin_unlock(&q_info->lock); -} diff --git a/drv/hisi_sec.c b/drv/hisi_sec.c index aa86a6b..0732cdc 100644 --- a/drv/hisi_sec.c +++ b/drv/hisi_sec.c @@ -959,8 +959,6 @@ int hisi_sec_cipher_send(handle_t ctx, struct wd_cipher_msg *msg) return ret; } - hisi_qm_enable_interrupt(ctx, msg->is_polled); - return 0; } @@ -1162,8 +1160,6 @@ int hisi_sec_cipher_send_v3(handle_t ctx, struct wd_cipher_msg *msg) return ret; } - hisi_qm_enable_interrupt(ctx, msg->is_polled); - return 0; } @@ -1403,8 +1399,6 @@ int hisi_sec_digest_send(handle_t ctx, struct wd_digest_msg *msg) goto put_sgl; } - hisi_qm_enable_interrupt(ctx, msg->is_polled); - return 0; put_sgl: @@ -1560,8 +1554,6 @@ int hisi_sec_digest_send_v3(handle_t ctx, struct wd_digest_msg *msg) goto put_sgl; } - hisi_qm_enable_interrupt(ctx, msg->is_polled); - return 0; put_sgl: @@ -1913,8 +1905,6 @@ int hisi_sec_aead_send(handle_t ctx, struct wd_aead_msg *msg) return ret; } - hisi_qm_enable_interrupt(ctx, msg->is_polled); - return 0; } @@ -2181,8 +2171,6 @@ int hisi_sec_aead_send_v3(handle_t ctx, struct wd_aead_msg *msg) return ret; } - hisi_qm_enable_interrupt(ctx, msg->is_polled); - return 0; } @@ -2285,6 +2273,9 @@ int hisi_sec_init(struct wd_ctx_config_internal *config, void *priv) /* setting the type is 0 for sqc_type */ qm_priv.op_type = 0; qm_priv.qp_mode = config->ctxs[i].ctx_mode; + /* Setting the epoll en to 0 for ASYNC ctx */ + qm_priv.epoll_en = (qm_priv.qp_mode == CTX_MODE_SYNC) ? + config->epoll_en : 0; qm_priv.idx = i; h_qp = hisi_qm_alloc_qp(&qm_priv, h_ctx); if (!h_qp) diff --git a/include/drv/wd_aead_drv.h b/include/drv/wd_aead_drv.h index 78a5673..137e70a 100644 --- a/include/drv/wd_aead_drv.h +++ b/include/drv/wd_aead_drv.h @@ -31,8 +31,6 @@ struct wd_aead_msg { __u8 data_fmt; /* Operation result, denoted by WD error code */ __u8 result; - /* epoll flag */ - __u8 is_polled; /* in bytes */ __u32 in_bytes; diff --git a/include/drv/wd_cipher_drv.h b/include/drv/wd_cipher_drv.h index e649869..87b77d3 100644 --- a/include/drv/wd_cipher_drv.h +++ b/include/drv/wd_cipher_drv.h @@ -28,8 +28,6 @@ struct wd_cipher_msg { __u8 data_fmt; /* Operation result, denoted by WD error code */ __u8 result; - /* epoll flag */ - __u8 is_polled; /* Key bytes */ __u16 key_bytes; diff --git a/include/drv/wd_comp_drv.h b/include/drv/wd_comp_drv.h index 8146a50..73403b5 100644 --- a/include/drv/wd_comp_drv.h +++ b/include/drv/wd_comp_drv.h @@ -50,8 +50,6 @@ struct wd_comp_msg { __u32 checksum; /* Request identifier */ __u32 tag; - /* Epoll flag */ - __u8 is_polled; }; struct wd_comp_driver { diff --git a/include/drv/wd_digest_drv.h b/include/drv/wd_digest_drv.h index fdde772..6907bc5 100644 --- a/include/drv/wd_digest_drv.h +++ b/include/drv/wd_digest_drv.h @@ -27,8 +27,6 @@ struct wd_digest_msg { __u8 data_fmt; /* Operation result, denoted by WD error code */ __u8 result; - /* epoll flag */ - __u8 is_polled; /* user identifier: struct wcrypto_cb_tag */ __u64 usr_data; diff --git a/include/hisi_qm_udrv.h b/include/hisi_qm_udrv.h index 707d0e3..43f42d9 100644 --- a/include/hisi_qm_udrv.h +++ b/include/hisi_qm_udrv.h @@ -47,6 +47,7 @@ struct hisi_qm_priv { __u16 op_type; /* index of ctxs */ __u32 idx; + int epoll_en; }; struct hisi_qm_queue_info { @@ -71,6 +72,7 @@ struct hisi_qm_queue_info { bool cqc_phase; pthread_spinlock_t lock; unsigned long region_size[UACCE_QFRT_MAX]; + int epoll_en; }; struct hisi_qp { @@ -182,8 +184,6 @@ int hisi_qm_get_free_sqe_num(handle_t h_qp); __u32 hisi_qm_get_list_size(struct wd_datalist *start_node, struct wd_datalist *end_node); -void hisi_qm_enable_interrupt(handle_t ctx, __u8 enable); - #ifdef __cplusplus } #endif diff --git a/include/wd_alg_common.h b/include/wd_alg_common.h index 94336f0..0affa96 100644 --- a/include/wd_alg_common.h +++ b/include/wd_alg_common.h @@ -27,6 +27,7 @@ extern "C" { #define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0])) #define MAX_STR_LEN 256 #define CTX_TYPE_INVALID 9999 +#define POLL_TIME 1000 enum wd_ctx_mode { CTX_MODE_SYNC = 0, @@ -74,6 +75,7 @@ struct wd_ctx_config_internal { struct wd_ctx_internal *ctxs; void *priv; int pid; + int epoll_en; }; /** diff --git a/include/wd_util.h b/include/wd_util.h index 2d3c1e4..73ba96a 100644 --- a/include/wd_util.h +++ b/include/wd_util.h @@ -314,6 +314,15 @@ int wd_set_ctx_attr(struct wd_ctx_attr *ctx_attr, */ int wd_check_ctx(struct wd_ctx_config_internal *config, __u8 mode, __u32 idx); +/** + * wd_get_epoll_en() - Get epoll enable value from environment variable. + * @var_name: Environment variable name string. + * + * Return environment variable value, if the value is not 0 or 1, + * return -WD_EINVAL instead. + */ +int wd_get_epoll_en(const char *var_name); + #ifdef __cplusplus } #endif diff --git a/wd_aead.c b/wd_aead.c index 74047b5..f1bde0a 100644 --- a/wd_aead.c +++ b/wd_aead.c @@ -21,8 +21,6 @@ #define WD_POOL_MAX_ENTRIES 1024 #define MAX_RETRY_COUNTS 200000000 -#define POLL_SIZE 70000 -#define POLL_TIME 1000 static int g_aead_mac_len[WD_DIGEST_TYPE_MAX] = { WD_DIGEST_SM3_LEN, WD_DIGEST_MD5_LEN, WD_DIGEST_SHA1_LEN, @@ -414,17 +412,19 @@ int wd_aead_init(struct wd_ctx_config *config, struct wd_sched *sched) if (ret) return ret; + ret = wd_get_epoll_en("WD_AEAD_EPOLL_EN"); + if (ret < 0) + return ret; + + wd_aead_setting.config.epoll_en = ret; + ret = wd_init_ctx_config(&wd_aead_setting.config, config); - if (ret) { - WD_ERR("failed to set config, ret = %d\n", ret); + if (ret) return ret; - } ret = wd_init_sched(&wd_aead_setting.sched, sched); - if (ret < 0) { - WD_ERR("failed to set sched, ret = %d\n", ret); + if (ret < 0) goto out; - } /* set driver */ #ifdef WD_STATIC_DRV @@ -435,10 +435,8 @@ int wd_aead_init(struct wd_ctx_config *config, struct wd_sched *sched) ret = wd_init_async_request_pool(&wd_aead_setting.pool, config->ctx_num, WD_POOL_MAX_ENTRIES, sizeof(struct wd_aead_msg)); - if (ret < 0) { - WD_ERR("failed to init aead aysnc request pool.\n"); + if (ret < 0) goto out_sched; - } /* init ctx related resources in specific driver */ priv = calloc(1, wd_aead_setting.driver->drv_ctx_size); @@ -525,7 +523,7 @@ static int send_recv_sync(struct wd_ctx_internal *ctx, } do { - if (msg->is_polled) { + if (wd_aead_setting.config.epoll_en) { ret = wd_ctx_wait(ctx->ctx, POLL_TIME); if (unlikely(ret < 0)) WD_ERR("wd aead ctx wait timeout(%d)!\n", ret); @@ -563,7 +561,6 @@ int wd_do_aead_sync(handle_t h_sess, struct wd_aead_req *req) memset(&msg, 0, sizeof(struct wd_aead_msg)); fill_request_msg(&msg, req, sess); - msg.is_polled = (req->in_bytes >= POLL_SIZE); req->state = 0; idx = wd_aead_setting.sched.pick_next_ctx( @@ -616,7 +613,6 @@ int wd_do_aead_async(handle_t h_sess, struct wd_aead_req *req) fill_request_msg(msg, req, sess); msg->tag = msg_id; - msg->is_polled = 0; ret = wd_aead_setting.driver->aead_send(ctx->ctx, msg); if (unlikely(ret < 0)) { diff --git a/wd_cipher.c b/wd_cipher.c index 563eece..9b7b150 100644 --- a/wd_cipher.c +++ b/wd_cipher.c @@ -22,8 +22,6 @@ #define DES_WEAK_KEY_NUM 16 #define MAX_RETRY_COUNTS 200000000 -#define POLL_SIZE 100000 -#define POLL_TIME 1000 static const unsigned char des_weak_keys[DES_WEAK_KEY_NUM][DES_KEY_SIZE] = { /* weak keys */ @@ -255,17 +253,19 @@ int wd_cipher_init(struct wd_ctx_config *config, struct wd_sched *sched) if (ret) return ret; + ret = wd_get_epoll_en("WD_CIPHER_EPOLL_EN"); + if (ret < 0) + return ret; + + wd_cipher_setting.config.epoll_en = ret; + ret = wd_init_ctx_config(&wd_cipher_setting.config, config); - if (ret < 0) { - WD_ERR("failed to set config, ret = %d!\n", ret); + if (ret < 0) return ret; - } ret = wd_init_sched(&wd_cipher_setting.sched, sched); - if (ret < 0) { - WD_ERR("failed to set sched, ret = %d!\n", ret); + if (ret < 0) goto out; - } #ifdef WD_STATIC_DRV /* set driver */ @@ -276,10 +276,8 @@ int wd_cipher_init(struct wd_ctx_config *config, struct wd_sched *sched) ret = wd_init_async_request_pool(&wd_cipher_setting.pool, config->ctx_num, WD_POOL_MAX_ENTRIES, sizeof(struct wd_cipher_msg)); - if (ret < 0) { - WD_ERR("failed to init req pool, ret = %d!\n", ret); + if (ret < 0) goto out_sched; - } /* init ctx related resources in specific driver */ priv = calloc(1, wd_cipher_setting.driver->drv_ctx_size); @@ -436,7 +434,7 @@ static int send_recv_sync(struct wd_ctx_internal *ctx, } do { - if (msg->is_polled) { + if (wd_cipher_setting.config.epoll_en) { ret = wd_ctx_wait(ctx->ctx, POLL_TIME); if (unlikely(ret < 0)) WD_ERR("wd cipher ctx wait timeout(%d)!\n", ret); @@ -476,7 +474,6 @@ int wd_do_cipher_sync(handle_t h_sess, struct wd_cipher_req *req) memset(&msg, 0, sizeof(struct wd_cipher_msg)); fill_request_msg(&msg, req, sess); - msg.is_polled = (req->in_bytes >= POLL_SIZE); req->state = 0; idx = wd_cipher_setting.sched.pick_next_ctx( @@ -526,7 +523,6 @@ int wd_do_cipher_async(handle_t h_sess, struct wd_cipher_req *req) fill_request_msg(msg, req, sess); msg->tag = msg_id; - msg->is_polled = 0; ret = wd_cipher_setting.driver->cipher_send(ctx->ctx, msg); if (unlikely(ret < 0)) { diff --git a/wd_comp.c b/wd_comp.c index 9a71dfc..1f6324c 100644 --- a/wd_comp.c +++ b/wd_comp.c @@ -22,8 +22,6 @@ #define HW_CTX_SIZE (64 * 1024) #define STREAM_CHUNK (128 * 1024) -#define POLL_SIZE 250000 -#define POLL_TIME 1000 #define swap_byte(x) \ ((((x) & 0x000000ff) << 24) | \ @@ -97,16 +95,19 @@ int wd_comp_init(struct wd_ctx_config *config, struct wd_sched *sched) return -WD_EINVAL; } + ret = wd_get_epoll_en("WD_COMP_EPOLL_EN"); + if (ret < 0) + return ret; + + wd_comp_setting.config.epoll_en = ret; + ret = wd_init_ctx_config(&wd_comp_setting.config, config); - if (ret < 0) { - WD_ERR("failed to set config, ret = %d!\n", ret); + if (ret < 0) return ret; - } + ret = wd_init_sched(&wd_comp_setting.sched, sched); - if (ret < 0) { - WD_ERR("failed to set sched, ret = %d!\n", ret); + if (ret < 0) goto out; - } /* * Fix me: ctx could be passed into wd_comp_set_static_drv to help to * choose static compiled vendor driver. For dynamic vendor driver, @@ -125,10 +126,9 @@ int wd_comp_init(struct wd_ctx_config *config, struct wd_sched *sched) ret = wd_init_async_request_pool(&wd_comp_setting.pool, config->ctx_num, WD_POOL_MAX_ENTRIES, sizeof(struct wd_comp_msg)); - if (ret < 0) { - WD_ERR("failed to init req pool, ret = %d!\n", ret); + if (ret < 0) goto out_sched; - } + /* init ctx related resources in specific driver */ priv = calloc(1, wd_comp_setting.driver->drv_ctx_size); if (!priv) { @@ -429,7 +429,7 @@ static int wd_comp_sync_job(struct wd_comp_sess *sess, } do { - if (msg->is_polled) { + if (config->epoll_en) { ret = wd_ctx_wait(ctx->ctx, POLL_TIME); if (unlikely(ret < 0)) WD_ERR("wd ctx wait timeout, ret = %d!\n", ret); @@ -472,7 +472,6 @@ int wd_do_comp_sync(handle_t h_sess, struct wd_comp_req *req) fill_comp_msg(sess, &msg, req); msg.ctx_buf = sess->ctx_buf; - msg.is_polled = (req->src_len >= POLL_SIZE); msg.stream_mode = WD_COMP_STATELESS; ret = wd_comp_sync_job(sess, req, &msg); @@ -643,7 +642,6 @@ int wd_do_comp_strm(handle_t h_sess, struct wd_comp_req *req) /* fill true flag */ msg.req.last = req->last; msg.stream_mode = WD_COMP_STATEFUL; - msg.is_polled = (req->src_len >= POLL_SIZE); src_len = req->src_len; @@ -701,7 +699,6 @@ int wd_do_comp_async(handle_t h_sess, struct wd_comp_req *req) fill_comp_msg(sess, msg, req); msg->tag = tag; msg->stream_mode = WD_COMP_STATELESS; - msg->is_polled = 0; pthread_spin_lock(&ctx->lock); diff --git a/wd_dh.c b/wd_dh.c index c0d3e00..b9dd075 100644 --- a/wd_dh.c +++ b/wd_dh.c @@ -101,17 +101,19 @@ int wd_dh_init(struct wd_ctx_config *config, struct wd_sched *sched) if (param_check(config, sched)) return -WD_EINVAL; + ret = wd_get_epoll_en("WD_DH_EPOLL_EN"); + if (ret < 0) + return ret; + + wd_dh_setting.config.epoll_en = ret; + ret = wd_init_ctx_config(&wd_dh_setting.config, config); - if (ret) { - WD_ERR("failed to initialize ctx config, ret = %d!\n", ret); + if (ret) return ret; - } ret = wd_init_sched(&wd_dh_setting.sched, sched); - if (ret) { - WD_ERR("failed to initialize sched, ret = %d!\n", ret); + if (ret) goto out; - } #ifdef WD_STATIC_DRV wd_dh_set_static_drv(); @@ -121,10 +123,8 @@ int wd_dh_init(struct wd_ctx_config *config, struct wd_sched *sched) ret = wd_init_async_request_pool(&wd_dh_setting.pool, config->ctx_num, WD_POOL_MAX_ENTRIES, sizeof(struct wd_dh_msg)); - if (ret) { - WD_ERR("failed to initialize async req pool, ret = %d!\n", ret); + if (ret) goto out_sched; - } /* initialize ctx related resources in specific driver */ priv = calloc(1, wd_dh_setting.driver->drv_ctx_size); @@ -236,6 +236,12 @@ static int dh_recv_sync(handle_t ctx, struct wd_dh_msg *msg) int ret; do { + if (wd_dh_setting.config.epoll_en) { + ret = wd_ctx_wait(ctx, POLL_TIME); + if (ret < 0) + WD_ERR("wd ctx wait timeout(%d)!\n", ret); + } + ret = wd_dh_setting.driver->recv(ctx, msg); if (ret == -WD_EAGAIN) { if (rx_cnt++ >= DH_RECV_MAX_CNT) { diff --git a/wd_digest.c b/wd_digest.c index 0ddc074..44b86c4 100644 --- a/wd_digest.c +++ b/wd_digest.c @@ -19,8 +19,6 @@ #define DES_WEAK_KEY_NUM 4 #define MAX_RETRY_COUNTS 200000000 -#define POLL_SIZE 100000 -#define POLL_TIME 1000 static int g_digest_mac_len[WD_DIGEST_TYPE_MAX] = { WD_DIGEST_SM3_LEN, WD_DIGEST_MD5_LEN, WD_DIGEST_SHA1_LEN, @@ -28,6 +26,7 @@ static int g_digest_mac_len[WD_DIGEST_TYPE_MAX] = { WD_DIGEST_SHA384_LEN, WD_DIGEST_SHA512_LEN, WD_DIGEST_SHA512_224_LEN, WD_DIGEST_SHA512_256_LEN }; + struct wd_digest_setting { struct wd_ctx_config_internal config; struct wd_sched sched; @@ -175,17 +174,19 @@ int wd_digest_init(struct wd_ctx_config *config, struct wd_sched *sched) if (ret) return ret; + ret = wd_get_epoll_en("WD_DIGEST_EPOLL_EN"); + if (ret < 0) + return ret; + + wd_digest_setting.config.epoll_en = ret; + ret = wd_init_ctx_config(&wd_digest_setting.config, config); - if (ret < 0) { - WD_ERR("failed to set config, ret = %d!\n", ret); + if (ret < 0) return ret; - } ret = wd_init_sched(&wd_digest_setting.sched, sched); - if (ret < 0) { - WD_ERR("failed to set sched, ret = %d!\n", ret); + if (ret < 0) goto out; - } /* set driver */ #ifdef WD_STATIC_DRV @@ -196,10 +197,8 @@ int wd_digest_init(struct wd_ctx_config *config, struct wd_sched *sched) ret = wd_init_async_request_pool(&wd_digest_setting.pool, config->ctx_num, WD_POOL_MAX_ENTRIES, sizeof(struct wd_digest_msg)); - if (ret < 0) { - WD_ERR("failed to init req pool, ret = %d!\n", ret); + if (ret < 0) goto out_sched; - } /* init ctx related resources in specific driver */ priv = calloc(1, wd_digest_setting.driver->drv_ctx_size); @@ -322,7 +321,7 @@ static int send_recv_sync(struct wd_ctx_internal *ctx, struct wd_digest_sess *ds } do { - if (msg->is_polled) { + if (wd_digest_setting.config.epoll_en) { ret = wd_ctx_wait(ctx->ctx, POLL_TIME); if (unlikely(ret < 0)) WD_ERR("wd digest ctx wait timeout(%d)!\n", ret); @@ -367,7 +366,6 @@ int wd_do_digest_sync(handle_t h_sess, struct wd_digest_req *req) memset(&msg, 0, sizeof(struct wd_digest_msg)); fill_request_msg(&msg, req, dsess); - msg.is_polled = (req->in_bytes >= POLL_SIZE); req->state = 0; idx = wd_digest_setting.sched.pick_next_ctx( @@ -420,7 +418,6 @@ int wd_do_digest_async(handle_t h_sess, struct wd_digest_req *req) fill_request_msg(msg, req, dsess); msg->tag = msg_id; - msg->is_polled = 0; ret = wd_digest_setting.driver->digest_send(ctx->ctx, msg); if (unlikely(ret < 0)) { diff --git a/wd_ecc.c b/wd_ecc.c index af62b9a..bebe2e5 100644 --- a/wd_ecc.c +++ b/wd_ecc.c @@ -155,17 +155,19 @@ int wd_ecc_init(struct wd_ctx_config *config, struct wd_sched *sched) if (init_param_check(config, sched)) return -WD_EINVAL; + ret = wd_get_epoll_en("WD_ECC_EPOLL_EN"); + if (ret < 0) + return ret; + + wd_ecc_setting.config.epoll_en = ret; + ret = wd_init_ctx_config(&wd_ecc_setting.config, config); - if (ret < 0) { - WD_ERR("failed to set config, ret = %d!\n", ret); + if (ret < 0) return ret; - } ret = wd_init_sched(&wd_ecc_setting.sched, sched); - if (ret < 0) { - WD_ERR("failed to set sched, ret = %d!\n", ret); + if (ret < 0) goto out; - } #ifdef WD_STATIC_DRV wd_ecc_set_static_drv(); @@ -175,10 +177,8 @@ int wd_ecc_init(struct wd_ctx_config *config, struct wd_sched *sched) ret = wd_init_async_request_pool(&wd_ecc_setting.pool, config->ctx_num, WD_POOL_MAX_ENTRIES, sizeof(struct wd_ecc_msg)); - if (ret < 0) { - WD_ERR("failed to initialize async req pool, ret = %d!\n", ret); + if (ret < 0) goto out_sched; - } /* initialize ctx related resources in specific driver */ priv = calloc(1, wd_ecc_setting.driver->drv_ctx_size); @@ -1413,6 +1413,12 @@ static int ecc_send(handle_t ctx, struct wd_ecc_msg *msg) int ret; do { + if (wd_ecc_setting.config.epoll_en) { + ret = wd_ctx_wait(ctx, POLL_TIME); + if (ret < 0) + WD_ERR("wd ctx wait timeout(%d)!\n", ret); + } + ret = wd_ecc_setting.driver->send(ctx, msg); if (ret == -WD_EBUSY) { if (tx_cnt++ >= ECC_RESEND_CNT) { diff --git a/wd_rsa.c b/wd_rsa.c index 8371475..1eec345 100644 --- a/wd_rsa.c +++ b/wd_rsa.c @@ -141,17 +141,19 @@ int wd_rsa_init(struct wd_ctx_config *config, struct wd_sched *sched) if (param_check(config, sched)) return -WD_EINVAL; + ret = wd_get_epoll_en("WD_RSA_EPOLL_EN"); + if (ret < 0) + return ret; + + wd_rsa_setting.config.epoll_en = ret; + ret = wd_init_ctx_config(&wd_rsa_setting.config, config); - if (ret < 0) { - WD_ERR("failed to set config, ret = %d!\n", ret); + if (ret < 0) return ret; - } ret = wd_init_sched(&wd_rsa_setting.sched, sched); - if (ret < 0) { - WD_ERR("failed to set sched, ret = %d!\n", ret); + if (ret < 0) goto out; - } #ifdef WD_STATIC_DRV wd_rsa_set_static_drv(); @@ -161,10 +163,8 @@ int wd_rsa_init(struct wd_ctx_config *config, struct wd_sched *sched) ret = wd_init_async_request_pool(&wd_rsa_setting.pool, config->ctx_num, WD_POOL_MAX_ENTRIES, sizeof(struct wd_rsa_msg)); - if (ret < 0) { - WD_ERR("failed to initialize async req pool, ret = %d!\n", ret); + if (ret < 0) goto out_sched; - } /* initialize ctx related resources in specific driver */ priv = calloc(1, wd_rsa_setting.driver->drv_ctx_size); @@ -296,6 +296,12 @@ static int rsa_recv_sync(handle_t ctx, struct wd_rsa_msg *msg) int ret; do { + if (wd_rsa_setting.config.epoll_en) { + ret = wd_ctx_wait(ctx, POLL_TIME); + if (ret < 0) + WD_ERR("wd ctx wait timeout(%d)!\n", ret); + } + ret = wd_rsa_setting.driver->recv(ctx, msg); if (ret == -WD_EAGAIN) { if (rx_cnt++ >= RSA_RECV_MAX_CNT) { diff --git a/wd_sched.c b/wd_sched.c index 9b1998c..dfd390b 100644 --- a/wd_sched.c +++ b/wd_sched.c @@ -213,7 +213,7 @@ static int session_sched_poll_policy(handle_t sched_ctx, } if (ctx->numa_num > NUMA_NUM_NODES) { - WD_ERR("invalid: ctx's numa number is %d!\n", ctx->numa_num); + WD_ERR("invalid: ctx's numa number is %u!\n", ctx->numa_num); return -WD_EINVAL; } diff --git a/wd_util.c b/wd_util.c index 0638893..11d436d 100644 --- a/wd_util.c +++ b/wd_util.c @@ -85,8 +85,10 @@ int wd_init_ctx_config(struct wd_ctx_config_internal *in, } ctxs = calloc(1, cfg->ctx_num * sizeof(struct wd_ctx_internal)); - if (!ctxs) + if (!ctxs) { + WD_ERR("failed to alloc memory for internal ctxs!\n"); return -WD_ENOMEM; + } for (i = 0; i < cfg->ctx_num; i++) { if (!cfg->ctxs[i].ctx) { @@ -115,8 +117,10 @@ int wd_init_ctx_config(struct wd_ctx_config_internal *in, int wd_init_sched(struct wd_sched *in, struct wd_sched *from) { if (!from->name || !from->sched_init || - !from->pick_next_ctx || !from->poll_policy) + !from->pick_next_ctx || !from->poll_policy) { + WD_ERR("invalid: member of wd_sched is NULL!\n"); return -WD_EINVAL; + } in->h_sched_ctx = from->h_sched_ctx; in->name = strdup(from->name); @@ -170,13 +174,16 @@ void wd_memset_zero(void *data, __u32 size) static int init_msg_pool(struct msg_pool *pool, __u32 msg_num, __u32 msg_size) { pool->msgs = calloc(1, msg_num * msg_size); - if (!pool->msgs) + if (!pool->msgs) { + WD_ERR("failed to alloc memory for msgs arrary of msg pool!\n"); return -WD_ENOMEM; + } pool->used = calloc(1, msg_num * sizeof(int)); if (!pool->used) { free(pool->msgs); pool->msgs = NULL; + WD_ERR("failed to alloc memory for used arrary of msg pool!\n"); return -WD_ENOMEM; } @@ -204,8 +211,10 @@ int wd_init_async_request_pool(struct wd_async_msg_pool *pool, __u32 pool_num, pool->pool_num = pool_num; pool->pools = calloc(1, pool->pool_num * sizeof(struct msg_pool)); - if (!pool->pools) + if (!pool->pools) { + WD_ERR("failed to alloc memory for async msg pools!\n"); return -WD_ENOMEM; + } for (i = 0; i < pool->pool_num; i++) { ret = init_msg_pool(&pool->pools[i], msg_num, msg_size); @@ -510,27 +519,33 @@ static int is_number(const char *str) return 1; } -/* 1 enable, 0 disable, others error */ -int wd_parse_async_poll_en(struct wd_env_config *config, const char *s) +static int str_to_bool(const char *s, bool *target) { int tmp; - if (!is_number(s)) { - WD_ERR("invalid: async poll en flag is %s!\n", s); + if (!is_number(s)) return -WD_EINVAL; - } tmp = strtol(s, NULL, 10); - if (tmp != 0 && tmp != 1) { - WD_ERR("invalid: async poll en flag is not 0 or 1!\n"); + if (tmp != 0 && tmp != 1) return -WD_EINVAL; - } - config->enable_internal_poll = tmp; + *target = tmp; return 0; } +int wd_parse_async_poll_en(struct wd_env_config *config, const char *s) +{ + int ret; + + ret = str_to_bool(s, &config->enable_internal_poll); + if (ret) + WD_ERR("parse async poll enable flag(%s) failed!\n", s); + + return ret; +} + static int parse_num_on_numa(const char *s, int *num, int *node) { char *sep, *start, *left; @@ -1588,3 +1603,22 @@ int wd_check_ctx(struct wd_ctx_config_internal *config, __u8 mode, __u32 idx) return 0; } + +int wd_get_epoll_en(const char *var_name) +{ + bool epoll_en = false; + const char *s; + int ret; + + s = secure_getenv(var_name); + if (!s || !strlen(s)) + return 0; + + ret = str_to_bool(s, &epoll_en); + if (ret) { + WD_ERR("failed to parse %s environment variable!\n", var_name); + return ret; + } + + return epoll_en; +} -- 2.24.0

1 0

Fwd: [PATCH v4 00/32] KVM: s390: enable zPCI for interpretive execution
by zhangfei.gao＠foxmail.com 16 Mar '22

16 Mar '22

-------- Forwarded Message -------- Subject: [PATCH v4 00/32] KVM: s390: enable zPCI for interpretive execution Date: Mon, 14 Mar 2022 15:44:19 -0400 From: Matthew Rosato <mjrosato(a)linux.ibm.com> To: linux-s390(a)vger.kernel.org CC: kvm(a)vger.kernel.org, david(a)redhat.com, thuth(a)redhat.com, linux-kernel(a)vger.kernel.org, vneethv(a)linux.ibm.com, agordeev(a)linux.ibm.com, imbrenda(a)linux.ibm.com, will(a)kernel.org, frankja(a)linux.ibm.com, corbet(a)lwn.net, linux-doc(a)vger.kernel.org, pasic(a)linux.ibm.com, jgg(a)nvidia.com, gerald.schaefer(a)linux.ibm.com, borntraeger(a)linux.ibm.com, farman(a)linux.ibm.com, gor(a)linux.ibm.com, schnelle(a)linux.ibm.com, hca(a)linux.ibm.com, alex.williamson(a)redhat.com, freude(a)linux.ibm.com, pmorel(a)linux.ibm.com, cohuck(a)redhat.com, oberpar(a)linux.ibm.com, iommu(a)lists.linux-foundation.org, svens(a)linux.ibm.com, pbonzini(a)redhat.com Note: A few patches in this series are dependent on Baolu's IOMMU domain ops split, which is currently in the next branch of linux-iommu. This series applies on top: https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git Enable interpretive execution of zPCI instructions + adapter interruption forwarding for s390x KVM vfio-pci. This is done by introducing a new IOMMU domain for s390x (KVM-managed), indicating via vfio that this IOMMU domain should be used instead of the default, with subsequent management of the hardware assists being handled via a new KVM ioctl for zPCI management. By allowing intepretation of zPCI instructions and firmware delivery of interrupts to guests, we can significantly reduce the frequency of guest SIE exits for zPCI. We then see additional gains by handling a hot-path instruction that can still intercept to the hypervisor (RPCIT) directly in kvm via the new IOMMU domain, whose map operations update the host DMA table with pinned guest entries over the specified range. From the perspective of guest configuration, you passthrough zPCI devices in the same manner as before, with intepretation support being used by default if available in kernel+qemu. Will reply with a link to the associated QEMU series. Changelog v3->v4: v3: https://lore.kernel.org/kvm/20220204211536.321475-1-mjrosato@linux.ibm.com/ - Significant overhaul of the userspace API. Remove all vfio device feature ioctls. Remove CONFIG_VFIO_PCI_ZDEV, this is once again always built with vfio-pci for s390; IS_ENABLED checks can instead look at CONFIG_VFIO_PCI. Most earlier patches in the series could maintain their reviews, but some needed to be removed due to required code changes. - Instead use a KVM ioctl for zPCI management. The API is very similar to the feature ioctls used in the prior series, with an additional step to create an association between an iommu domain + KVM + zPCI device. - Introduce a new iommu domain ops type for s390-iommu, to be used when KVM manages the IOMMU instead of in response to VFIO mapping ioctls - Add a iommu method for specifying the type of domain to allocate - Add a new type to vfio_iommu_type1 (KVM-owned) to trigger the allocation of the KVM-owned IOMMU domain when zPCI interpretation is requested. In this case, the KVM-owned type is specified on VFIO_SET_IOMMU. - Wire the RPCIT intercepts into the new IOMMU domain via the kernel IOMMU API - Remove a bunch of unnecessary symbol externs, make the associated functions static - Now that we keep a list of zPCI associated with a given KVM, we can do fh lookup on this list vs the list of all zPCI on the host. We only need to do a host-wide fh lookup during the initial device<->KVM association. Matthew Rosato (32): s390/sclp: detect the zPCI load/store interpretation facility s390/sclp: detect the AISII facility s390/sclp: detect the AENI facility s390/sclp: detect the AISI facility s390/airq: pass more TPI info to airq handlers s390/airq: allow for airq structure that uses an input vector s390/pci: externalize the SIC operation controls and routine s390/pci: stash associated GISA designation s390/pci: export some routines related to RPCIT processing s390/pci: stash dtsm and maxstbl s390/pci: add helper function to find device by handle s390/pci: get SHM information from list pci s390/pci: return status from zpci_refresh_trans iommu: introduce iommu_domain_alloc_type and the KVM type vfio: introduce KVM-owned IOMMU type vfio-pci/zdev: add function handle to clp base capability KVM: s390: pci: add basic kvm_zdev structure iommu/s390: add support for IOMMU_DOMAIN_KVM KVM: s390: pci: do initial setup for AEN interpretation KVM: s390: pci: enable host forwarding of Adapter Event Notifications KVM: s390: mechanism to enable guest zPCI Interpretation KVM: s390: pci: routines for (dis)associating zPCI devices with a KVM KVM: s390: pci: provide routines for enabling/disabling interpretation KVM: s390: pci: provide routines for enabling/disabling interrupt forwarding KVM: s390: pci: provide routines for enabling/disabling IOAT assist KVM: s390: pci: handle refresh of PCI translations KVM: s390: intercept the rpcit instruction KVM: s390: add KVM_S390_ZPCI_OP to manage guest zPCI devices vfio-pci/zdev: add DTSM to clp group capability KVM: s390: introduce CPU feature for zPCI Interpretation MAINTAINERS: additional files related kvm s390 pci passthrough MAINTAINERS: update s390 IOMMU entry Documentation/virt/kvm/api.rst | 60 +++ MAINTAINERS | 4 +- arch/s390/include/asm/airq.h | 7 +- arch/s390/include/asm/kvm_host.h | 7 + arch/s390/include/asm/kvm_pci.h | 40 ++ arch/s390/include/asm/pci.h | 12 + arch/s390/include/asm/pci_clp.h | 11 +- arch/s390/include/asm/pci_dma.h | 3 + arch/s390/include/asm/pci_insn.h | 31 +- arch/s390/include/asm/sclp.h | 4 + arch/s390/include/asm/tpi.h | 13 + arch/s390/include/uapi/asm/kvm.h | 1 + arch/s390/kvm/Makefile | 1 + arch/s390/kvm/interrupt.c | 95 +++- arch/s390/kvm/kvm-s390.c | 90 +++- arch/s390/kvm/kvm-s390.h | 10 + arch/s390/kvm/pci.c | 833 +++++++++++++++++++++++++++++++ arch/s390/kvm/pci.h | 63 +++ arch/s390/kvm/priv.c | 46 ++ arch/s390/pci/pci.c | 31 ++ arch/s390/pci/pci_clp.c | 28 +- arch/s390/pci/pci_dma.c | 7 +- arch/s390/pci/pci_insn.c | 15 +- arch/s390/pci/pci_irq.c | 48 +- drivers/iommu/Kconfig | 8 + drivers/iommu/Makefile | 1 + drivers/iommu/iommu.c | 7 + drivers/iommu/s390-iommu.c | 53 +- drivers/iommu/s390-iommu.h | 53 ++ drivers/iommu/s390-kvm-iommu.c | 469 +++++++++++++++++ drivers/s390/char/sclp_early.c | 4 + drivers/s390/cio/airq.c | 12 +- drivers/s390/cio/qdio_thinint.c | 6 +- drivers/s390/crypto/ap_bus.c | 9 +- drivers/s390/virtio/virtio_ccw.c | 6 +- drivers/vfio/pci/vfio_pci_zdev.c | 17 +- drivers/vfio/vfio_iommu_type1.c | 12 +- include/linux/iommu.h | 12 + include/uapi/linux/kvm.h | 43 ++ include/uapi/linux/vfio.h | 6 + include/uapi/linux/vfio_zdev.h | 6 + 41 files changed, 2090 insertions(+), 94 deletions(-) create mode 100644 arch/s390/include/asm/kvm_pci.h create mode 100644 arch/s390/kvm/pci.c create mode 100644 arch/s390/kvm/pci.h create mode 100644 drivers/iommu/s390-iommu.h create mode 100644 drivers/iommu/s390-kvm-iommu.c -- 2.27.0 _______________________________________________ iommu mailing list iommu(a)lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu

1 0

[PATCH] hisi-hpre: modify the return value of function
by Zhiqi Song 12 Mar '22

12 Mar '22

From: Weili Qian <qianweili(a)huawei.com> When the function executes successfully, the returned size is not used, so "WD_SUCCESS" is returned directly. Signed-off-by: Weili Qian <qianweili(a)huawei.com> --- drv/hisi_hpre.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drv/hisi_hpre.c b/drv/hisi_hpre.c index b6c80203..d0a579e6 100644 --- a/drv/hisi_hpre.c +++ b/drv/hisi_hpre.c @@ -221,8 +221,7 @@ static int fill_rsa_crt_prikey2(struct wd_rsa_prikey *prikey, *data = wd_dq->data; - return (int)(wd_dq->bsize + wd_qinv->bsize + wd_p->bsize + - wd_q->bsize + wd_dp->bsize); + return WD_SUCCESS; } static int fill_rsa_prikey1(struct wd_rsa_prikey *prikey, void **data) @@ -243,7 +242,7 @@ static int fill_rsa_prikey1(struct wd_rsa_prikey *prikey, void **data) *data = wd_d->data; - return (int)(wd_n->bsize + wd_d->bsize); + return WD_SUCCESS; } static int fill_rsa_pubkey(struct wd_rsa_pubkey *pubkey, void **data) @@ -264,7 +263,7 @@ static int fill_rsa_pubkey(struct wd_rsa_pubkey *pubkey, void **data) return ret; *data = wd_e->data; - return (int)(wd_n->bsize + wd_e->bsize); + return WD_SUCCESS; } static int fill_rsa_genkey_in(struct wd_rsa_kg_in *genkey) @@ -383,17 +382,17 @@ static int rsa_prepare_key(struct wd_rsa_msg *msg, if (req->op_type == WD_RSA_SIGN) { if (hw_msg->alg == HPRE_ALG_NC_CRT) { ret = fill_rsa_crt_prikey2((void *)msg->key, &data); - if (ret <= 0) + if (ret) return ret; } else { ret = fill_rsa_prikey1((void *)msg->key, &data); - if (ret < 0) + if (ret) return ret; hw_msg->alg = HPRE_ALG_NC_NCRT; } } else if (req->op_type == WD_RSA_VERIFY) { ret = fill_rsa_pubkey((void *)msg->key, &data); - if (ret < 0) + if (ret) return ret; hw_msg->alg = HPRE_ALG_NC_NCRT; } else if (req->op_type == WD_RSA_GENKEY) { -- 2.33.0

1 0

[PATCH 1/9] sec: unify print format
by Yang Shen 10 Mar '22

10 Mar '22

From: Kai Ye <yekai13(a)huawei.com> Unify print format with following rules: 1. failed to do sth. 2. invalid: sth is NULL. Signed-off-by: Kai Ye <yekai13(a)huawei.com> --- drv/hisi_sec.c | 20 ++++++++++---------- wd_aead.c | 12 ++++++------ wd_cipher.c | 20 ++++++++++---------- wd_digest.c | 10 +++++----- 4 files changed, 31 insertions(+), 31 deletions(-) diff --git a/drv/hisi_sec.c b/drv/hisi_sec.c index 16fcb5f..aa86a6b 100644 --- a/drv/hisi_sec.c +++ b/drv/hisi_sec.c @@ -703,7 +703,7 @@ static void parse_cipher_bd2(struct hisi_sec_sqe *sqe, done = sqe->type2.done_flag & SEC_DONE_MASK; if (done != SEC_HW_TASK_DONE || sqe->type2.error_type) { - WD_ERR("SEC BD %s fail! done=0x%x, etype=0x%x\n", "cipher", + WD_ERR("failed to parse cipher BD2! done=0x%x, etype=0x%x\n", done, sqe->type2.error_type); recv_msg->result = WD_IN_EPARA; } else { @@ -927,7 +927,7 @@ int hisi_sec_cipher_send(handle_t ctx, struct wd_cipher_msg *msg) int ret; if (!msg) { - WD_ERR("input cipher msg is NULL!\n"); + WD_ERR("invalid: input cipher msg is NULL!\n"); return -WD_EINVAL; } @@ -1130,7 +1130,7 @@ int hisi_sec_cipher_send_v3(handle_t ctx, struct wd_cipher_msg *msg) int ret; if (!msg) { - WD_ERR("input cipher msg is NULL!\n"); + WD_ERR("invalid: input cipher msg is NULL!\n"); return -WD_EINVAL; } @@ -1175,7 +1175,7 @@ static void parse_cipher_bd3(struct hisi_sec_sqe3 *sqe, done = sqe->done_flag & SEC_DONE_MASK; if (done != SEC_HW_TASK_DONE || sqe->error_type) { - WD_ERR("SEC BD3 %s fail! done=0x%x, etype=0x%x\n", "cipher", + WD_ERR("failed to parse cipher BD3! done=0x%x, etype=0x%x\n", done, sqe->error_type); recv_msg->result = WD_IN_EPARA; } else { @@ -1278,7 +1278,7 @@ static void parse_digest_bd2(struct hisi_sec_sqe *sqe, done = sqe->type2.done_flag & SEC_DONE_MASK; if (done != SEC_HW_TASK_DONE || sqe->type2.error_type) { - WD_ERR("SEC BD %s fail! done=0x%x, etype=0x%x\n", "digest", + WD_ERR("failed to parse digest BD2! done=0x%x, etype=0x%x\n", done, sqe->type2.error_type); recv_msg->result = WD_IN_EPARA; } else { @@ -1354,7 +1354,7 @@ int hisi_sec_digest_send(handle_t ctx, struct wd_digest_msg *msg) int ret; if (!msg) { - WD_ERR("input digest msg is NULL!\n"); + WD_ERR("invalid: input digest msg is NULL!\n"); return -WD_EINVAL; } @@ -1510,7 +1510,7 @@ int hisi_sec_digest_send_v3(handle_t ctx, struct wd_digest_msg *msg) int ret; if (!msg) { - WD_ERR("input digest msg is NULL!\n"); + WD_ERR("invalid: input digest msg is NULL!\n"); return -WD_EINVAL; } @@ -1578,7 +1578,7 @@ static void parse_digest_bd3(struct hisi_sec_sqe3 *sqe, done = sqe->done_flag & SEC_DONE_MASK; if (done != SEC_HW_TASK_DONE || sqe->error_type) { - WD_ERR("SEC BD3 %s fail! done=0x%x, etype=0x%x\n", "digest", + WD_ERR("failed to parse digest BD3! done=0x%x, etype=0x%x\n", done, sqe->error_type); recv_msg->result = WD_IN_EPARA; } else { @@ -1927,7 +1927,7 @@ static void parse_aead_bd2(struct hisi_sec_sqe *sqe, icv = (sqe->type2.done_flag & SEC_ICV_MASK) >> 1; if (done != SEC_HW_TASK_DONE || sqe->type2.error_type || icv == SEC_HW_ICV_ERR) { - WD_ERR("SEC BD aead fail! done=0x%x, etype=0x%x, icv=0x%x\n", + WD_ERR("failed to parse aead BD2! done=0x%x, etype=0x%x, icv=0x%x\n", done, sqe->type2.error_type, icv); recv_msg->result = WD_IN_EPARA; } else { @@ -2195,7 +2195,7 @@ static void parse_aead_bd3(struct hisi_sec_sqe3 *sqe, icv = (sqe->done_flag & SEC_ICV_MASK) >> 1; if (done != SEC_HW_TASK_DONE || sqe->error_type || icv == SEC_HW_ICV_ERR) { - WD_ERR("SEC BD3 aead fail! done=0x%x, etype=0x%x, icv=0x%x\n", + WD_ERR("failed to parse aead BD3! done=0x%x, etype=0x%x, icv=0x%x\n", done, sqe->error_type, icv); recv_msg->result = WD_IN_EPARA; } else { diff --git a/wd_aead.c b/wd_aead.c index 7df8e80..74047b5 100644 --- a/wd_aead.c +++ b/wd_aead.c @@ -63,14 +63,14 @@ static void wd_aead_set_static_drv(void) { wd_aead_setting.driver = wd_aead_get_driver(); if (!wd_aead_setting.driver) - WD_ERR("fail to get driver\n"); + WD_ERR("failed to get driver!\n"); } #else static void __attribute__((constructor)) wd_aead_open_driver(void) { wd_aead_setting.dlhandle = dlopen("libhisi_sec.so", RTLD_NOW); if (!wd_aead_setting.dlhandle) - WD_ERR("failed to open libhisi_sec.so\n"); + WD_ERR("failed to open libhisi_sec.so!\n"); } static void __attribute__((destructor)) wd_aead_close_driver(void) @@ -344,7 +344,7 @@ static int aead_param_check(struct wd_aead_sess *sess, int ret; if (unlikely(!sess || !req)) { - WD_ERR("aead input sess or req is NULL.\n"); + WD_ERR("invalid: aead input sess or req is NULL!\n"); return -WD_EINVAL; } @@ -393,7 +393,7 @@ static int aead_param_check(struct wd_aead_sess *sess, static int aead_init_check(struct wd_ctx_config *config, struct wd_sched *sched) { if (!config || !config->ctxs || !config->ctxs[0].ctx || !sched) { - WD_ERR("wd aead config or sched is NULL!\n"); + WD_ERR("invalid: wd aead config or sched is NULL!\n"); return -WD_EINVAL; } @@ -594,7 +594,7 @@ int wd_do_aead_async(handle_t h_sess, struct wd_aead_req *req) return -WD_EINVAL; if (unlikely(!req->cb)) { - WD_ERR("aead input req cb is NULL.\n"); + WD_ERR("invalid: aead input req cb is NULL!\n"); return -WD_EINVAL; } @@ -647,7 +647,7 @@ int wd_aead_poll_ctx(__u32 idx, __u32 expt, __u32 *count) int ret; if (!count) { - WD_ERR("aead poll ctx input param is NULL!\n"); + WD_ERR("invalid: aead poll ctx input param is NULL!\n"); return -WD_EINVAL; } diff --git a/wd_cipher.c b/wd_cipher.c index afd8c4d..3a9b323 100644 --- a/wd_cipher.c +++ b/wd_cipher.c @@ -75,14 +75,14 @@ static void wd_cipher_set_static_drv(void) { wd_cipher_setting.driver = wd_cipher_get_driver(); if (!wd_cipher_setting.driver) - WD_ERR("fail to get driver\n"); + WD_ERR("failed to get driver!\n"); } #else static void __attribute__((constructor)) wd_cipher_open_driver(void) { wd_cipher_setting.dlhandle = dlopen("libhisi_sec.so", RTLD_NOW); if (!wd_cipher_setting.dlhandle) - WD_ERR("fail to open libhisi_sec.so\n"); + WD_ERR("failed to open libhisi_sec.so!\n"); } static void __attribute__((destructor)) wd_cipher_close_driver(void) @@ -158,7 +158,7 @@ static int cipher_init_check(struct wd_ctx_config *config, struct wd_sched *sched) { if (!config || !config->ctxs || !config->ctxs[0].ctx || !sched) { - WD_ERR("wd cipher config or sched is NULL!\n"); + WD_ERR("invalid: wd cipher config or sched is NULL!\n"); return -WD_EINVAL; } @@ -177,7 +177,7 @@ int wd_cipher_set_key(handle_t h_sess, const __u8 *key, __u32 key_len) int ret; if (!key || !sess) { - WD_ERR("cipher set key input param err!\n"); + WD_ERR("invalid: cipher set key input param err!\n"); return -WD_EINVAL; } @@ -205,13 +205,13 @@ handle_t wd_cipher_alloc_sess(struct wd_cipher_sess_setup *setup) struct wd_cipher_sess *sess = NULL; if (unlikely(!setup)) { - WD_ERR("cipher input setup is NULL!\n"); + WD_ERR("invalid: cipher input setup is NULL!\n"); return (handle_t)0; } sess = malloc(sizeof(struct wd_cipher_sess)); if (!sess) { - WD_ERR("fail to alloc session memory!\n"); + WD_ERR("failed to alloc session memory!\n"); return (handle_t)0; } memset(sess, 0, sizeof(struct wd_cipher_sess)); @@ -235,7 +235,7 @@ void wd_cipher_free_sess(handle_t h_sess) struct wd_cipher_sess *sess = (struct wd_cipher_sess *)h_sess; if (unlikely(!sess)) { - WD_ERR("cipher input h_sess is NULL!\n"); + WD_ERR("invalid: cipher input h_sess is NULL!\n"); return; } @@ -387,12 +387,12 @@ static int wd_cipher_check_params(handle_t h_sess, int ret = 0; if (unlikely(!h_sess || !req)) { - WD_ERR("cipher input sess or req is NULL!\n"); + WD_ERR("invalid: cipher input sess or req is NULL!\n"); return -WD_EINVAL; } if (unlikely(mode == CTX_MODE_ASYNC && !req->cb)) { - WD_ERR("cipher req cb is NULL!\n"); + WD_ERR("invalid: cipher req cb is NULL!\n"); return -WD_EINVAL; } @@ -561,7 +561,7 @@ int wd_cipher_poll_ctx(__u32 idx, __u32 expt, __u32 *count) int ret; if (unlikely(!count)) { - WD_ERR("wd cipher poll ctx input param is NULL!\n"); + WD_ERR("invalid: cipher poll ctx input param is NULL!\n"); return -WD_EINVAL; } diff --git a/wd_digest.c b/wd_digest.c index fb29746..0ddc074 100644 --- a/wd_digest.c +++ b/wd_digest.c @@ -62,7 +62,7 @@ static void wd_digest_set_static_drv(void) { wd_digest_setting.driver = wd_digest_get_driver(); if (!wd_digest_setting.driver) - WD_ERR("fail to get driver\n"); + WD_ERR("failed to get driver!\n"); } #else static void __attribute__((constructor)) wd_digest_open_driver(void) @@ -70,7 +70,7 @@ static void __attribute__((constructor)) wd_digest_open_driver(void) /* Fix me: vendor driver should be put in /usr/lib/wd/ */ wd_digest_setting.dlhandle = dlopen("libhisi_sec.so", RTLD_NOW); if (!wd_digest_setting.dlhandle) - WD_ERR("fail to open libhisi_sec.so\n"); + WD_ERR("failed to open libhisi_sec.so!\n"); } static void __attribute__((destructor)) wd_digest_close_driver(void) @@ -252,7 +252,7 @@ static int digest_param_check(struct wd_digest_sess *sess, int ret; if (unlikely(!sess || !req)) { - WD_ERR("digest input sess or req is NULL.\n"); + WD_ERR("invalid: digest input sess or req is NULL!\n"); return -WD_EINVAL; } @@ -398,7 +398,7 @@ int wd_do_digest_async(handle_t h_sess, struct wd_digest_req *req) return -WD_EINVAL; if (unlikely(!req->cb)) { - WD_ERR("digest input req cb is NULL.\n"); + WD_ERR("invalid: digest input req cb is NULL!\n"); return -WD_EINVAL; } @@ -451,7 +451,7 @@ int wd_digest_poll_ctx(__u32 idx, __u32 expt, __u32 *count) int ret; if (unlikely(!count)) { - WD_ERR("digest count is NULL.\n"); + WD_ERR("invalid: digest poll ctx input param is NULL!\n"); return -WD_EINVAL; } -- 2.24.0

1 8

[PATCH] uadk: bugfix segment fault when uninitializing
by Zhiqi Song 08 Mar '22

08 Mar '22

When the initialization of each alg driver failed, the wd_<alg>_setting.priv should be set to NULL. Otherwise there will be segment fault when uninitializing the alg driver. Signed-off-by: Zhiqi Song <songzhiqi1(a)huawei.com> --- wd_aead.c | 1 + wd_cipher.c | 1 + wd_comp.c | 1 + wd_dh.c | 1 + wd_digest.c | 1 + wd_ecc.c | 1 + wd_rsa.c | 1 + 7 files changed, 7 insertions(+) diff --git a/wd_aead.c b/wd_aead.c index 7a33d4e7..74047b56 100644 --- a/wd_aead.c +++ b/wd_aead.c @@ -458,6 +458,7 @@ int wd_aead_init(struct wd_ctx_config *config, struct wd_sched *sched) out_init: free(priv); + wd_aead_setting.priv = NULL; out_priv: wd_uninit_async_request_pool(&wd_aead_setting.pool); out_sched: diff --git a/wd_cipher.c b/wd_cipher.c index 374b05e3..3a9b3234 100644 --- a/wd_cipher.c +++ b/wd_cipher.c @@ -299,6 +299,7 @@ int wd_cipher_init(struct wd_ctx_config *config, struct wd_sched *sched) out_init: free(priv); + wd_cipher_setting.priv = NULL; out_priv: wd_uninit_async_request_pool(&wd_cipher_setting.pool); out_sched: diff --git a/wd_comp.c b/wd_comp.c index eb4fa8e5..9a71dfcd 100644 --- a/wd_comp.c +++ b/wd_comp.c @@ -145,6 +145,7 @@ int wd_comp_init(struct wd_ctx_config *config, struct wd_sched *sched) out_init: free(priv); + wd_comp_setting.priv = NULL; out_priv: wd_uninit_async_request_pool(&wd_comp_setting.pool); out_sched: diff --git a/wd_dh.c b/wd_dh.c index 193a3f1b..c0d3e007 100644 --- a/wd_dh.c +++ b/wd_dh.c @@ -145,6 +145,7 @@ int wd_dh_init(struct wd_ctx_config *config, struct wd_sched *sched) out_init: free(priv); + wd_dh_setting.priv = NULL; out_priv: wd_uninit_async_request_pool(&wd_dh_setting.pool); out_sched: diff --git a/wd_digest.c b/wd_digest.c index 008ab301..17b2923e 100644 --- a/wd_digest.c +++ b/wd_digest.c @@ -216,6 +216,7 @@ int wd_digest_init(struct wd_ctx_config *config, struct wd_sched *sched) out_init: free(priv); + wd_digest_setting.priv = NULL; out_priv: wd_uninit_async_request_pool(&wd_digest_setting.pool); out_sched: diff --git a/wd_ecc.c b/wd_ecc.c index 335e953b..af62b9a9 100644 --- a/wd_ecc.c +++ b/wd_ecc.c @@ -199,6 +199,7 @@ int wd_ecc_init(struct wd_ctx_config *config, struct wd_sched *sched) out_init: free(priv); + wd_ecc_setting.priv = NULL; out_priv: wd_uninit_async_request_pool(&wd_ecc_setting.pool); out_sched: diff --git a/wd_rsa.c b/wd_rsa.c index 44de4998..83714757 100644 --- a/wd_rsa.c +++ b/wd_rsa.c @@ -185,6 +185,7 @@ int wd_rsa_init(struct wd_ctx_config *config, struct wd_sched *sched) out_init: free(priv); + wd_rsa_setting.priv = NULL; out_priv: wd_uninit_async_request_pool(&wd_rsa_setting.pool); out_sched: -- 2.33.0

1 0

[PATCH] digest: simplify the process of represent BD state
by Kai Ye 08 Mar '22

08 Mar '22

The value of 'out_bytes' can descripe the BD state. So not need to use the marco variable. The BD state is non-zero value when the msg recived successfully. Otherwise the BD state is zero. Signed-off-by: Kai Ye <yekai13(a)huawei.com> --- wd_digest.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/wd_digest.c b/wd_digest.c index 0d79817..2a65540 100644 --- a/wd_digest.c +++ b/wd_digest.c @@ -21,7 +21,6 @@ #define POLL_SIZE 100000 #define POLL_TIME 1000 -#define STREAM_MODE_STATE 1 static int g_digest_mac_len[WD_DIGEST_TYPE_MAX] = { WD_DIGEST_SM3_LEN, WD_DIGEST_MD5_LEN, WD_DIGEST_SHA1_LEN, @@ -47,11 +46,8 @@ struct wd_digest_sess { unsigned char key[MAX_HMAC_KEY_SIZE]; __u32 key_bytes; void *sched_key; - /* - * Notify the BD state, 1 is final BD or middle BD, - * 0 is normal mode or first BD, one session only supports one stream. - */ - int state; + /* Notify the BD state */ + int state; /* Total of data for stream mode */ __u64 long_data_len; }; @@ -338,8 +334,8 @@ static int send_recv_sync(struct wd_ctx_internal *ctx, struct wd_digest_sess *ds goto out; } } - if (msg->has_next && msg->result == WD_SUCCESS) - dsess->state = STREAM_MODE_STATE; + if (msg->has_next) + dsess->state = msg->out_bytes; } while (ret < 0); out: -- 2.33.0

1 0

UADK周例会
by openEuler conference 04 Mar '22

04 Mar '22

您好！ sig-AccLib SIG 邀请您参加 2022-03-09 11:00 召开的ZOOM会议(自动录制) 会议主题：UADK周例会会议内容：每周三上午11点-12点，会议链接https://linaro-org.zoom.us/j/91879279131 1、社区计划 2、进展问题讨论 3、其他议题讨论会议链接：https://us06web.zoom.us/j/85336432385?pwd=Rm1TRlYrOWJKd3hiVXRRcFNpRjg1QT09 温馨提醒：建议接入会议后修改参会人的姓名，也可以使用您在gitee.com的ID 更多资讯尽在：https://openeuler.org/zh/ Hello! openEuler sig-AccLib SIG invites you to attend the ZOOM conference(auto recording) will be held at 2022-03-09 11:00, The subject of the conference is UADK周例会, Summary: 每周三上午11点-12点，会议链接https://linaro-org.zoom.us/j/91879279131 1、社区计划 2、进展问题讨论 3、其他议题讨论 You can join the meeting at https://us06web.zoom.us/j/85336432385?pwd=Rm1TRlYrOWJKd3hiVXRRcFNpRjg1QT09. Note: You are advised to change the participant name after joining the conference or use your ID at gitee.com. More information: https://openeuler.org/en/

1 0

subscribe
by shenyang (M) 24 Feb '22

24 Feb '22

subscribe

1 0

2024

2023

2022

Acc