[Why]
matrix => {
iperf.xxx => [100, 80, 0],
...
}
like above, if a stat_metric fill 0, the avg and stddev will be incorrect
Signed-off-by: Lu Weitao <luweitaobe(a)163.com>
---
lib/compare_matrixes.rb | 13 +++++++++----
lib/matrix2.rb | 13 +------------
2 files changed, 10 insertions(+), 16 deletions(-)
diff --git a/lib/compare_matrixes.rb b/lib/compare_matrixes.rb
index fef5714a..da2c2b92 100644
--- a/lib/compare_matrixes.rb
+++ b/lib/compare_matrixes.rb
@@ -129,10 +129,15 @@ def get_values_by_field(matrixes_list, field, matrixes_size, success, options)
#
values = {}
matrixes_list.length.times do |index|
- value_list = fill_missing_with_zeros(
- matrixes_list[index][field],
- matrixes_size[index]
- )
+ value_list = matrixes_list[index][field]
+ unless value_list
+ if success
+ value_list = [0] unless value_list
+ else
+ value_list = [1] unless value_list
+ end
+ end
+
values[index] = get_values(value_list, success)
next if index.zero?
diff --git a/lib/matrix2.rb b/lib/matrix2.rb
index 2fd63243..82ed9a7a 100644
--- a/lib/matrix2.rb
+++ b/lib/matrix2.rb
@@ -62,16 +62,6 @@ def create_stats(result_root)
# stats
end
-def samples_fill_missing_zeros(value, size)
- value.concat([0] * (size - value.size))
-end
-
-def matrix_fill_miss_zeros(matrix, col_size)
- matrix.each_value do |value|
- samples_fill_missing_zeros(value, col_size)
- end
-end
-
# input: job_list
# return: matrix of Hash(String, Array(Number))
# Eg: matrix: {
@@ -94,8 +84,7 @@ def create_matrix(job_list)
matrix[key] << value
end
end
- col_size = job_list.size
- matrix_fill_miss_zeros(matrix, col_size)
+
return matrix, suites
end
--
2.23.0