[Compass-ci] Re: [PATCH compass-ci] add a comment, make it easier to understand

On Fri, Jan 22, 2021 at 09:16:18AM +0800, Liu Shaofei wrote:

On Thu, Jan 21, 2021 at 09:35:12PM +0800, Zhang Dewan wrote:

...

Signed-off-by: Zhang Dewan 513619464@qq.com

providers/qemu/kvm.sh | 1 + 1 file changed, 1 insertion(+)

diff --git a/providers/qemu/kvm.sh b/providers/qemu/kvm.sh index b4e87fc..9034ccf 100755 --- a/providers/qemu/kvm.sh +++ b/providers/qemu/kvm.sh @@ -89,6 +89,7 @@ set_initrd() set_bios() { bios=/usr/share/qemu-efi-aarch64/QEMU_EFI.fd

•   # when arch='x86_64', use the follwing file:
   [ -f "$bios" ] || bios=/usr/share/ovmf/OVMF.fd
  

    Enn... it's seem to be unrelated between the comment and OVMF.fd.
    right? i feel like this:

    [ $arch == "x86_64" ] && ....

em... at least for now, it works. if someone want to modify this code, my comment also useful. isn't it?

Thanks, Dewan

    Thanks,
    Liushaofei

...

}

-- 2.23.0