[Compass-ci] Re: [PATCH lkp-tests] lib/bootstrap.sh: 'run-ipconfig' step should be before the check step

On Thu, Dec 31, 2020 at 07:05:33PM +0800, Wu Fengguang wrote:

The changelog should show the problem and explain why.

Ok.

-------- Thanks Yu Chuan

Thanks, Fengguang

On Thu, Dec 31, 2020 at 03:11:29PM +0800, Yu Chuan wrote:

...

[Before] test job: result/borrow/2020-12-31/vm-2p8g/debian-sid-aarch64/3600/z9.275666 key log:

• [ /sys/class/net/enp0s1/ != /sys/class/net/enp0s1/ ]
• cat /sys/class/net/enp0s1//operstate
• [ down = up ]

[After] test job: result/borrow/2020-12-31/vm-2p8g/debian-sid-aarch64/3600/z9.275673 key log:

• [ /sys/class/net/enp0s1/ != /sys/class/net/enp0s1/ ]
• cat /sys/class/net/enp0s1//operstate
• [ up = up ]

Signed-off-by: Yu Chuan 13186087857@163.com

lib/bootstrap.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/bootstrap.sh b/lib/bootstrap.sh index 7d15bb370fa9..770d550724f1 100755 --- a/lib/bootstrap.sh +++ b/lib/bootstrap.sh @@ -160,6 +160,9 @@ setup_network() return }

• $LKP_DEBUG_PREFIX $LKP_SRC/bin/run-ipconfig
• network_ok && return
• local net_devices=$(get_net_devices) if [ -z "$net_devices" ]; then

@@ -181,9 +184,6 @@ setup_network() fi fi

• $LKP_DEBUG_PREFIX $LKP_SRC/bin/run-ipconfig
• network_ok && return
• local err_msg='IP-Config: Auto-configuration of network failed' dmesg | grep -q -F "$err_msg" || { # Include $err_msg in the error message so that it matches

-- 2.23.0