[Compass-ci] Re: [PATCH v2 compass-ci] providers/qemu: encapsulated into functions

...

• -serial file:${log_file}
  

• -monitor null
  

• )

}

-[ -n "$initrds" ] || {

• exit

+run_qemu() +{

• "${kvm[@]}" --append "${append}"

}

Can the two methods of run_qemu and qemu_options be merged?

good

Thanks, Yinsi

Thanks, Yale

...

-initrd=initrd -cat $initrds > $initrd +check_logfile +write_logfile

-echo $SCHED_PORT -echo kernel: $kernel -echo initrds: $initrds -echo append: $append -echo less $log_file +qemu_command +option_value +check_option_value

-sleep 5 +print_message

-kvm=(

• $qemu
• -machine virt-4.0,accel=kvm,gic-version=3
• -kernel $kernel
• -initrd $initrd
• -smp $nr_cpu
• -m $memory
• -cpu Kunpeng-920
• -bios /usr/share/qemu-efi-aarch64/QEMU_EFI.fd
• -nic tap,model=virtio-net-pci,helper=/usr/libexec/qemu-bridge-helper,br=br0,mac=${mac}
• -k en-us
• -no-reboot
• -nographic
• -serial file:${log_file}
• -monitor null

-) +qemu_options

-"${kvm[@]}" --append "${append}"

+run_qemu

2.23.0