[Compass-ci] Re: [PATCH compass-ci] sparrow/4-docker: fix logical error

On Tue, Jan 05, 2021 at 09:18:29AM +0800, Liu Yinsi wrote:

only when images not exist or execute ./buildall without parameters "reboot", need to execute ./build and ./install, otherwise just execute ./first-run and ./start

Signed-off-by: Liu Yinsi liuyinsi@163.com

sparrow/4-docker/buildall | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sparrow/4-docker/buildall b/sparrow/4-docker/buildall index ca4406b..59a0770 100755 --- a/sparrow/4-docker/buildall +++ b/sparrow/4-docker/buildall @@ -33,7 +33,7 @@ do_one() cd $container [ "$container_name" == 'ssh-r' ] && exit docker images | grep -wq "$container_name"

• if [ "$?" == 0 ] && [ "$action" != "reboot" ]; then
  

• if [ "$?" != 0 ] || [ "$action" != "reboot" ]; then
  

better use -ne -lt -gt -lt -le for num compare

Thanks, Luan Shengde

	[ -x build ] && ./build
	[ -x install ] && ./install
fi

-- 2.23.0