[Compass-ci] Re: [PATCH compass-ci 2/3] qemu/kvm.sh: optimize the prompt when the error occurs

On Mon, Jan 18, 2021 at 02:53:10PM +0800, Ren Wen wrote:

...

...

...

• echo "[ERROR] Can not find kernel file or kernel file is empty: $kernel."
  

no job is normal, why define it error?

if we do this, when i read this message, i feel an error occurred in the program

Good! I'll modify here as follow: no job => INFO have job, but cannot wget kernel file or kernel file is empty => ERROR

一个日志函数会不会好一些. 用一个日志模板去输出信息, 以后想修改的话直接修改模板就行.

Good, lkp-tests has log.sh and log.rb in lib/ dir, I have been wondering why there is no such a file in compass-ci.

-------- Thanks Yu Chuan

Thanks, RenWen

...

---

Thanks Yu Chuan

...

Thanks, Shenwei

...

• exit 1
  

  }

  # debian has both qemu-system-x86_64 and qemu-system-riscv64 command [[ $kernel =~ 'riscv64' ]] && qemu=qemu-system-riscv64

• [ -n "$initrds" ] || exit

• [ -n "$initrds" ] || {

• echo "[ERROR] Can not find any initrd for current vm."
  

• exit 1
  

• }

}

set_initrd()

2.23.0