[Compass-ci] Re: [PATCH v2 compass-ci] lib/job.cr: enable the account check function

private def check_account_info error_msg = "Failed to verify the account.\n" error_msg += "Please refer to https://gitee.com/wu_fengguang/compass-ci/blob/master/doc/manual/apply-accou..."

• account_info = @es.get_account(self["my_email"])

• # raise account_info unless account_info.is_a?(JSON::Any)

• raise error_msg unless account_info.is_a?(JSON::Any)

• # @account_info = account_info.as_h
• @account_info = account_info.as_h if account_info.is_a?(JSON::Any)

• @account_info = account_info.as_h

• # raise error_msg if @account_info["found"]? == false
• # raise error_msg unless self["my_name"] == @account_info["my_name"].to_s
• # raise error_msg unless self["my_token"] == @account_info["my_token"]

• raise error_msg if @account_info["found"]? == false

don't need to use '==' to do the test if its value is false/true directly test the expression itself

• raise error_msg if self["my_name"] != @account_info["my_name"].to_s
• raise error_msg if self["my_token"] != @account_info["my_token"]

use unless if better than if for the three lines above =>

raise error_msg unless @account_info["found"]? == false raise error_msg unless self["my_name"] == @account_info["my_name"].to_s raise error_msg unless self["my_token"] == @account_info["my_token"]

Thanks, Luan Shengde