[Compass-ci] Re: [PATCH lkp-tests 03/11] feat: step 3 of iso2rootfs: copy out rootfs in second boot stage

...

+++ b/jobs/install-iso-release.yaml @@ -0,0 +1,26 @@ +suite: install-iso-release +category: benchmark +install-iso-release:

• #################
• # iso info
• #################
• iso_os:
• iso_arch:
• iso_version:
• NFS_SERVER_HOST:
• NFS_ROOT_DIR:

maybe these five fields can be combined, and add a comment: ${NFS_SERVER_HOST}:${NFS_ROOT_DIR}/${iso_os}/${iso_arch}/${iso_version}

good

...

+check_params() +{

• log_info "start check params"
• local required_vars=(

• "iso_os"
  

• "iso_arch"
  

• "iso_version"
  

delete this blank line.

ok

...

+release_rootfs() +{

• :

+}

+main() +{

• check_params
• release_rootfs

The following function name maybe more clearly: sync_rootfs_to_nfsserver

good

-------- Thanks Yu Chuan

---

Thanks, Xijian

...

• lvchange --permission r /dev/mapper/${VG_NAME}-${iso_os}_${iso_arch}_${iso_version}_${ROOTFS_SUFFIX} ||

• die "change logical volume permission to readonly failed:/dev/mapper/${VG_NAME}-${iso_os}_${iso_arch}_${iso_version}_${ROOTFS_SUFFIX}"
  

+}

+main

2.23.0