[Compass-ci] Re: [PATCH compass-ci] lib/job.cr: fix repeated setting job

• # Each key must exist after the job is initialized
• # Otherwise "initialized"? will return false

1) "initialized"? -> "initialized?" 2) "initialized?" is used in "initialize", not after. Your comments for me mean "job.new -> initialized?".

Thanks, RenWen

METHOD_KEYS = %w( id os @@ -91,7 +93,6 @@ class Job kernel_append_root kernel_params docker_image

• kernel_version linux_vmlinuz_path linux_modules_initrd linux_headers_initrd

@@ -312,7 +313,7 @@ class Job

private def set_kernel_version boot_dir = "#{SRV_OS}/#{os_dir}/boot"

• suffix = "-#{kernel_version}" if self["kernel_version"]?

• suffix = "-#{self["kernel_version"]}" if self["kernel_version"]? self["linux_vmlinuz_path"] = File.real_path("#{boot_dir}/vmlinuz#{suffix}") if "#{os_mount}" == "initramfs" self["linux_modules_initrd"] = File.real_path("#{boot_dir}/modules#{suffix}.cgz")

-- 2.23.0