[Compass-ci] Re: [PATCH v2 compass-ci 1/4] container/send-mail: mail-post.rb

On Fri, Oct 16, 2020 at 02:06:55PM +0800, Luan Shengde wrote:

add setup smpt for intranet/internet smtp

smpt looks like spell error

enable send mail to both curystal.ci and WAN email

curystal? WAN?

• 'from' => data['from'] || (ENV['DEFAULT_EMAIL']).to_s,

DEFAULT_EMAIL is what?

+def check_smtp(mail_info, mail_server)

• if [nil, 'crystal.ci'].include? mail_info['to'].split('@')[1]
• intranet_smtp(mail_server)
• else
• internet_smtp
• mail_info['from'] = (ENV['EMAIL_ADDR']).to_s

EMAIL_ADDR is what?

Looks DEFAULT_EMAIL/EMAIL_ADDR naming should be improved.

Thanks, Fengguang