[Compass-ci] Re: [PATCH v3 compass-ci 2/2] replace log.sh

On Fri, Jan 29, 2021 at 10:10:59AM +0800, Li Yuanchao wrote:

On Thu, Jan 28, 2021 at 06:31:46PM +0800, Liu Yinsi wrote:

...

Signed-off-by: Liu Yinsi liuyinsi@163.com

+. $CCI_SRC/lib/log.sh

lsmod | grep -q "^cifs\s" || {

• log_error "[ERROR] kernel module cifs is missing (try: sudo modprobe cifs)"

• log_error "kernel module cifs is missing (try: sudo modprobe cifs)"

You delete '[ERROR]', why delete it? Do you want to say "it's a warning"? Then you change change '[ERROR]' to '[WARNING]'.

$CCI_SRC/lib/log.sh: log_error() { date +"[ERROR] ..." }

log_error have "[ERROR]", so no need to write again when call log_error().

Thanks, Yinsi

Thanks, Yuanchao