[Compass-ci] Re: [PATCH v2 lkp-tests] distro/archlinux: add archlinux distro file

On Tue, Nov 17, 2020 at 10:57:04AM +0800, Sun Yukui wrote:

On Mon, Nov 16, 2020 at 08:24:05PM +0800, Wang Yong wrote:

...

• 	pacman -Qqs ----noconfirm $pkg || pacman -Sy --noconfirm $pkg
  

                                ^Is this the correct grammar?

nice catch

...

• distro_install_depends $BM_NAME-dev || continue
  

           Line changes

it's aligned

...

• chown .lkp $pack_to/${BM_NAME}_$date.cgz $pack_to/${BM_NAME}.cgz || return

   echo package installed to $pack_to/${BM_NAME}.cgz
   echo packages installed to $pack_to/${BM_NAME}.cgz

all of this is package, so i think it's necessary to change it.

...

• cleanup_downloaded_pkgs
  

   ^One more line

Ok.

...

• 	echo "failed to pack-deps $BM_NAME" >&2
  

           echo $?
           echo "exit $?"
           Thanks
           sunyukui

It's only test, already delete in newer patch

Thanks, Wang Yong