1. Fix warning string literal in condition 2. Display the first error message in email subject
Signed-off-by: Cao Xueliang caoxl78320@163.com --- lib/mail_bisect_result.rb | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/lib/mail_bisect_result.rb b/lib/mail_bisect_result.rb index c0a2731..090855e 100644 --- a/lib/mail_bisect_result.rb +++ b/lib/mail_bisect_result.rb @@ -19,8 +19,8 @@ class MailBisectResult end
def compose_mail - subject = "[Compass-CI][#{@repo.split('/')[1]}]: #{@error_messages[0]}" - job_url = "job url: #{ENV['SRV_HTTP_HOST']}:#{ENV['SRV_HTTP_PORT']}/#{ENV['result_root']}\n" ? ENV['result_root'] : '' + subject = "[Compass-CI][#{@repo.split('/')[1]}]: #{@error_messages[0].split("\n")[0]}" + job_url = ENV['result_root'] ? "job url: http://#%7BENV%5B%27SRV_HTTP_HOST%27%5D%7D:#%7BENV%5B%27SRV_HTTP_PORT%27%5D%..." : '' body = <<~BODY Hi #{@git_commit.author_name},
@@ -28,6 +28,7 @@ class MailBisectResult git commit: #{@commit_id[0..11]} ("#{@git_commit.subject}")
gcc version: 7.3.0 + error_messages: #{@error_messages.join("\n")}