[Compass-ci] Re: [PATCH lkp-tests] lib/job.rb: delete matrix args

On Fri, Dec 04, 2020 at 04:37:18PM +0800, Wei Jihui wrote:

if user add matrix args by overrides args, like: submit xxx.yaml 'matrix_key=matrix_value' ... it should delete matrix args from overrides, or it will keep matrix args in job.yaml all the time.

Signed-off-by: Wei Jihui weijihuiall@163.com

lib/job.rb | 1 + 1 file changed, 1 insertion(+)

diff --git a/lib/job.rb b/lib/job.rb index 2869dcb3..32329e10 100755 --- a/lib/job.rb +++ b/lib/job.rb @@ -302,6 +302,7 @@ class Job hash_job[key_array[i]] = v_array[i] end hash_job.delete(key)

•    @overrides.delete(key) unless @overrides[key].nil?
  

There is no need add unless ... you need @overrides[key].nil?, just @overrides.delete(key) is enough. unless ... is redundant

Thanks, Luan Shengde

    jobs_array << hash_job
  end
}

-- 2.23.0