[Compass-ci] Re: [PATCH v3 compass-ci] providers/qemu: refactor kvm script

On Wed, Dec 30, 2020 at 11:55:28AM +0800, Xiao Shenwei wrote:

...

+option_value()

this function is parse ipxe_script, then load kernel and initrd

so, the name should more detailed dessription

ok, how about parse_ipxe_script()

...

+{

• append=
• initrds=
• while read a b c
• do

• case "$a" in
  

• 	'#')
  

• 		;;
  

• 	initrd)
  

• 		file=$(basename "$b")
  

• 		wget --timestamping -a ${log_file} --progress=bar:force $b
  

• 		initrds+="$file "
  

• 		;;
  

• 	kernel)
  

• 		kernel=$(basename "$b")
  

• 		wget --timestamping -a ${log_file} --progress=bar:force $b
  

• 		append=$(echo "$c" | sed -r "s/ initrd=[^ ]+//g")
  

• 		;;
  

• 	*)
  

• 		;;
  

• esac
  

• done < $ipxe_script

+}

-[ -s "$kernel" ] || {

• echo "can't get kernel or kernel size is 0"
• exit

+check_option_value() +{

• [ -s "$kernel" ] || {

• echo "can't get kernel or kernel size is 0"
  

• exit
  

• }
• [ -n "$initrds" ] || exit
• initrd=initrd
• cat $initrds > $initrd

this step is generate initrd not check_option_value

ok

Thanks, Yinsi

Thanks, Shenwei

...

}

-[ -n "$initrds" ] || {

• exit

+print_message() +{

• echo $SCHED_PORT
• echo kernel: $kernel
• echo initrds: $initrds
• echo append: $append
• echo less $log_file
• sleep 5

}

-initrd=initrd -cat $initrds > $initrd +run_qemu() +{

• kvm=(

• $qemu
  

• -machine virt-4.0,accel=kvm,gic-version=3
  

• -kernel $kernel
  

• -initrd $initrd
  

• -smp $nr_cpu
  

• -m $memory
  

• -cpu Kunpeng-920
  

• -bios /usr/share/qemu-efi-aarch64/QEMU_EFI.fd
  

• -nic tap,model=virtio-net-pci,helper=/usr/libexec/qemu-bridge-helper,br=br0,mac=${mac}
  

• -k en-us
  

• -no-reboot
  

• -nographic
  

• -serial file:${log_file}
  

• -monitor null
  

• )
• "${kvm[@]}" --append "${append}"

+}

-echo $SCHED_PORT -echo kernel: $kernel -echo initrds: $initrds -echo append: $append -echo less $log_file +check_logfile +write_logfile

-sleep 5 +qemu_command +option_value +check_option_value

-kvm=(

• $qemu
• -machine virt-4.0,accel=kvm,gic-version=3
• -kernel $kernel
• -initrd $initrd
• -smp $nr_cpu
• -m $memory
• -cpu Kunpeng-920
• -bios /usr/share/qemu-efi-aarch64/QEMU_EFI.fd
• -nic tap,model=virtio-net-pci,helper=/usr/libexec/qemu-bridge-helper,br=br0,mac=${mac}
• -k en-us
• -no-reboot
• -nographic
• -serial file:${log_file}
• -monitor null

-) +print_message

-"${kvm[@]}" --append "${append}"

+run_qemu

2.23.0