[Compass-ci] Re: [PATCH v2 compass-ci] monitoring/filter.cr: query value support regularity

•  next if value.includes?(nil)
  

•  next if value.includes?(msg[key]?)
  

Why not use: next if value.includes?(nil) || value.includes?(msg[key]?)

As an array name, "value" may be confused.

Thanks, RenWen

•  return false unless regular_match(value, msg[key]?.to_s)
  

  end return true end
• private def regular_match(rules, string)
• rules.each do |rule|

•  return true if string =~ /#{rule}/
  

• end
• return false
• end

end

2.23.0