[Compass-ci] Re: [PATCH lkp-tests 1/3] iso2rootfs: support not submit test job

On Wed, Nov 11, 2020 at 03:54:13PM +0800, Yu Chuan wrote:

...

...

@@ -443,6 +437,20 @@ submit_test_job_yaml()

[ -d "${LKP_SRC}" ] || die "cannot find value of var: LKP_SRC."

• local test_yaml_vars=(

• "test_os"
  

• "test_os_arch"
  

• "test_os_version"
  

• "test_os_mount"
  

• "test_testbox"
  

• )
• local yaml_t
• for yaml_t in "${test_yaml_vars[@]}"

there is no need to define "local yaml_t" for "for yaml_t in xxxx"

Good, but why? You mean we have no need to use 'local' to avoid change the value of possible glbal var 'yaml_t'?

yes

I tested it later and found that the variable works outside the function with its last value.

if the script has variable with same name, add loacl to avoid value override

Thanks, Luan Shengde

---

Thanks Yu Chuan

...

Thanks, Luan Shengde

...

• do

• [ -n "$(eval echo "\$${yaml_t}")" ] || die "cannot fine value of var: ${yaml_t}."
  

• done
• cd "${LKP_SRC}" && { chmod +x ./sbin/install-dependencies.sh ./sbin/install-dependencies.sh

@@ -492,7 +500,7 @@ main() run_qcow2rootfs

test_rootfs

• submit_test_job_yaml

• [ -z ${test_yaml} ] || submit_test_job_yaml

  post_works

}

2.23.0