[Compass-ci] Re: [PATCH v3 compass-ci 3/3] compare_error_messages.rb/error_messages.rb: optimize string catenate

style: extra space.

Confused subject.

Thanks, RenWen

Reply-To: In-Reply-To: 20210118114239.3343422-3-ljx.joe@qq.com

On Mon, Jan 18, 2021 at 07:42:39PM +0800, Lin Jiaxin wrote:

Signed-off-by: Lin Jiaxin ljx.joe@qq.com

lib/compare_error_messages.rb | 2 +- lib/error_messages.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/compare_error_messages.rb b/lib/compare_error_messages.rb index d9171bf..237b2c9 100644 --- a/lib/compare_error_messages.rb +++ b/lib/compare_error_messages.rb @@ -73,7 +73,7 @@ def format_error_messages(error_messages, new_error_ids) new_error_number = 0

error_messages.each do |k, v|

• if new_error_ids.include?('build-pkg.' + build_pkg_error_id(k))

• if new_error_ids.include?("build-pkg.#{build_pkg_error_id(k)}") new_error_number += 1 formatted_error_messages = add_sign(formatted_error_messages, '>>', v) else

diff --git a/lib/error_messages.rb b/lib/error_messages.rb index d83d890..50f9637 100644 --- a/lib/error_messages.rb +++ b/lib/error_messages.rb @@ -44,7 +44,7 @@ class ErrorMessages error_messages_by_error_id = [] error_messages = obtain_error_messages error_messages.each do |k, v|

•  if ('build-pkg.' + build_pkg_error_id(k)) == error_id
  

•  if "build-pkg.#{build_pkg_error_id(k)}" == error_id
    error_messages_by_error_id += return_error_line ? [k] : v.to_a
  end
  

  end

-- 2.23.0