On Thu, Nov 12, 2020 at 02:46:27PM +0800, Xiao Shenwei wrote:
[why] our os-cifs container will mount three dir, /srv/os /srv/initrd /srv/result it's may cause: 1. our cifs service becomes slow 2. if the container exit, none of the three folders can be accessed. in order to reduce the coupling, need split them
The space at the beginning of the line is unnecessary.
[how] one folder mount by one container
ditto.
usage: mount /srv/initrd client: mount -t cifs -o guest,port=446 //ip/initrd /tmp/initrd client: mount -t cifs -o guest,port=446 //ip/osimage /tmp/osimage
how about:
[Usage] Two ways for the client to mount initrd: 1. initrd. mount -t cifs -o guest,port=446 //ip/initrd /tmp/initrd 2. osimage. mount -t cifs -o guest,port=446 //ip/osimage /tmp/osimage
Btw, maybe you should add the comment about why we need osimage and initrd to share the same folder. you can find the reason in os-nfs/start
Signed-off-by: Xiao Shenwei xiaoshenwei96@163.com
container/initrd-cifs/Dockerfile | 24 +++++++++++++++++++++ container/initrd-cifs/build | 5 +++++ container/initrd-cifs/smb.conf | 36 ++++++++++++++++++++++++++++++++ container/initrd-cifs/start | 24 +++++++++++++++++++++
This patch looks only contain the 'add initrd-cifs step': desc: add the container/initrd-cifs to share /srv/initrd.
Is it better to also add the 'delete initrd-cifs step' in this patch? desc: delete the /srv/initrd in container/os-cifs.
+[initrd]
- path = /srv/initrd/
- comment = initrd
- browseable = yes
- writable = yes
- public = yes
- force user = lkp
- force group = lkp
+[osimage]
You can also add the reason why we need osimage and initrd here.
- path = /srv/initrd/
- comment = initrd
^-- osimage
-------- Thanks Yu Chuan
- browseable = yes
- writable = yes
- public = yes
- force user = lkp
- force group = lkp
diff --git a/container/initrd-cifs/start b/container/initrd-cifs/start new file mode 100755 index 0000000..a9dbc48 --- /dev/null +++ b/container/initrd-cifs/start @@ -0,0 +1,24 @@ +#!/bin/bash +# SPDX-License-Identifier: MulanPSL-2.0+ +# Copyright (c) 2020 Huawei Technologies Co., Ltd. All rights reserved.
+. $CCI_SRC/container/defconfig.sh
+lsmod | grep -q "^cifs\s" || {
- sudo modprobe cifs
+}
+docker_rm initrd-cifs
+cmd=(
- docker run
- -dt
- -p 446:445
- -v /etc/localtime:/etc/localtime:ro
- -v /srv/initrd:/srv/initrd
- --name initrd-cifs
- --restart=always
- alpine/initrd-cifs
+)
+"${cmd[@]}"
2.23.0