[Compass-ci] Re: [PATCH lkp-tests] tests/iozone: refactor format optimization

On Wed, Nov 25, 2020 at 03:00:51PM +0800, Lu Kaiyi wrote:

Signed-off-by: Lu Kaiyi 2392863668@qq.com

tests/iozone | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tests/iozone b/tests/iozone index 5186766f..923d8331 100755 --- a/tests/iozone +++ b/tests/iozone @@ -47,8 +47,7 @@ if [ -n "$block_size" ]; then ;; "preadv") args+=" -i 12" ;;

• 	*) echo "invalid test option, please check again!"
  

• 		exit 1
  

• 	*)           echo "invalid test option, please check again!" && exit 1
  	;;
  

this style looks strange command after ")", and ";;" in a stardand separate line.

xxxx) command;;

looks better

Thanks, Luan Shengde

esac

done

2.23.0