[Compass-ci] Re: [PATCH v2 compass-ci 1/5] container/send-internet-mail: mail-post.rb

On Fri, Oct 16, 2020 at 11:07:05AM +0800, Luan Shengde wrote:

On Tue, Oct 13, 2020 at 03:31:36PM +0800, Cao Xueliang wrote:

...

What's the different with send-mail container? You can add the code to the lib and use it in any container.

I will merge both send intranet mail(crystal.ci) and internet mail in to one.

It's reasonable in code reuse POV, however may better stay split in security and permission control POV.

Thanks, Fengguang