[Compass-ci] Re: [PATCH v2 compass-ci] service/scheduler: initialize a Sched for each API

On Mon, Nov 30, 2020 at 10:25:41AM +0800, Wu Zhende wrote:

So can use Sched's instance variable in Sched's any interface

Signed-off-by: Wu Zhende wuzhende666@163.com

src/lib/sched.cr | 7 +++--- src/scheduler/find_job_boot.cr | 6 ++--- src/scheduler/find_next_job_boot.cr | 6 ++--- src/scheduler/request_cluster_state.cr | 14 ++++++------ src/scheduler/scheduler.cr | 31 +++++++++++++++----------- src/scheduler/submit_job.cr | 4 ++-- src/scheduler/update_job_parameter.cr | 6 ++--- 7 files changed, 40 insertions(+), 34 deletions(-)

diff --git a/src/lib/sched.cr b/src/lib/sched.cr index 2be7d41..26ddd92 100644 --- a/src/lib/sched.cr +++ b/src/lib/sched.cr @@ -25,12 +25,13 @@ class Sched property redis property block_helper

• def initialize

• def initialize(env : HTTP::Server::Context) @es = Elasticsearch::Client.new @redis = Redis::Client.new @task_queue = TaskQueueAPI.new @block_helper = BlockHelper.new @rgc = RemoteGitClient.new

• @env = env end

  def normalize_mac(mac : String)

@@ -67,7 +68,7 @@ class Sched extra_job_fields) if Dir.glob(full_path_patterns).size > 0 end

• def update_tbox_wtmp(env : HTTP::Server::Context)

• def update_tbox_wtmp testbox = "" hash = Hash(String, String).new

@@ -75,7 +76,7 @@ class Sched hash["time"] = time

%w(mac ip job_id tbox_name tbox_state).each do |parameter|

•  if (value = env.params.query[parameter]?)
  

•  if (value = @env.params.query[parameter]?)
    case parameter
    when "tbox_name"
      testbox = value
  

diff --git a/src/scheduler/find_job_boot.cr b/src/scheduler/find_job_boot.cr index b5a23c5..9805464 100644 --- a/src/scheduler/find_job_boot.cr +++ b/src/scheduler/find_job_boot.cr @@ -2,9 +2,9 @@ # Copyright (c) 2020 Huawei Technologies Co., Ltd. All rights reserved.

class Sched

• def find_job_boot(env : HTTP::Server::Context)
• value = env.params.url["value"]
• boot_type = env.params.url["boot_type"]

• def find_job_boot
• value = @env.params.url["value"]
• boot_type = @env.params.url["boot_type"]

How about: value = @env.params.url["value"] boot_type = @env.params.url["boot_type"] Since "@env.params.url" looks aligned.

case boot_type
when "ipxe"

diff --git a/src/scheduler/find_next_job_boot.cr b/src/scheduler/find_next_job_boot.cr index 807a9ae..09abbd5 100644 --- a/src/scheduler/find_next_job_boot.cr +++ b/src/scheduler/find_next_job_boot.cr @@ -2,9 +2,9 @@ # Copyright (c) 2020 Huawei Technologies Co., Ltd. All rights reserved.

class Sched

• def find_next_job_boot(env)
• hostname = env.params.query["hostname"]?
• mac = env.params.query["mac"]?

• def find_next_job_boot
• hostname = @env.params.query["hostname"]?
• mac = @env.params.query["mac"]?

ditto.

if !hostname && mac
  hostname = @redis.hash_get("sched/mac2host", normalize_mac(mac))
end

diff --git a/src/scheduler/request_cluster_state.cr b/src/scheduler/request_cluster_state.cr index 72e3810..79a13cc 100644 --- a/src/scheduler/request_cluster_state.cr +++ b/src/scheduler/request_cluster_state.cr @@ -6,9 +6,9 @@ class Sched # all request states: # wait_ready | abort | failed | finished | wait_finish | # write_state | roles_ip

• def request_cluster_state(env)
• request_state = env.params.query["state"]
• job_id = env.params.query["job_id"]

• def request_cluster_state
• request_state = @env.params.query["state"]
• job_id = @env.params.query["job_id"]

ditto.

cluster_id = @redis.hash_get("sched/id2cluster", job_id).not_nil!
cluster_state = ""

@@ -41,10 +41,10 @@ class Sched

  return cluster_state
when "write_state"

•  node_roles = env.params.query["node_roles"]
  

•  node_ip = env.params.query["ip"]
  

•  direct_ips = env.params.query["direct_ips"]
  

•  direct_macs = env.params.query["direct_macs"]
  

•  node_roles = @env.params.query["node_roles"]
  

•  node_ip = @env.params.query["ip"]
  

•  direct_ips = @env.params.query["direct_ips"]
  

•  direct_macs = @env.params.query["direct_macs"]
  

ditto.

  job_info = {"roles"       => node_roles,
              "ip"          => node_ip,

diff --git a/src/scheduler/scheduler.cr b/src/scheduler/scheduler.cr index 5f97567..98b8e2e 100644 --- a/src/scheduler/scheduler.cr +++ b/src/scheduler/scheduler.cr @@ -30,12 +30,17 @@ require "../lib/sched" module Scheduler VERSION = "0.2.0"

• sched = Sched.new

• add_context_storage_type(Sched)

  before_all do |env|

• env.set "sched", Sched.new(env) env.response.headers["Connection"] = "close" end

• def self.get_sched_from_env(env)

• env.get("sched").as(Sched)

• end

• # for debug (maybe kemal debug|logger does better) def self.debug_message(env, response) puts %({"from": "#{env.request.remote_address}", "response": #{response.to_json}})

@@ -53,7 +58,7 @@ module Scheduler # /boot.xxx/host/${hostname} # /boot.yyy/mac/${mac} get "/boot.:boot_type/:parameter/:value" do |env|

• response = sched.find_job_boot(env)

• response = get_sched_from_env(env).find_job_boot

  job_id = response[/tmpfs/(.*)/job.cgz/, 1]? puts %({"job_id": "#{job_id}", "job_state": "boot"}) if job_id

@@ -63,7 +68,7 @@ module Scheduler

# /~lkp/cgi-bin/gpxelinux.cgi?hostname=:hostname&mac=:mac&last_kernel=:last_kernel get "/~lkp/cgi-bin/gpxelinux.cgi" do |env|

• response = sched.find_next_job_boot(env)

• response = get_sched_from_env(env).find_next_job_boot

  job_id = response[/tmpfs/(.*)/job.cgz/, 1]? puts %({"job_id": "#{job_id}", "job_state": "boot"}) if job_id

@@ -75,7 +80,7 @@ module Scheduler # - echo job_id to caller # -- job_id = "0" ? means failed post "/submit_job" do |env|

• job_messages = sched.submit_job(env)

• job_messages = get_sched_from_env(env).submit_job

  job_messages.each do |job_message| puts job_message.to_json

@@ -103,7 +108,7 @@ module Scheduler # curl -X PUT "http://localhost:3000/set_host_mac?hostname=wfg&mac=00-01-02-03-04-05" put "/set_host_mac" do |env| if (client_hostname = env.params.query["hostname"]?) && (client_mac = env.params.query["mac"]?)

•  sched.set_host_mac(client_mac, client_hostname)
  

•  get_sched_from_env(env).set_host_mac(client_mac, client_hostname)
  
  "Done"
  

  else

@@ -114,7 +119,7 @@ module Scheduler # curl -X PUT "http://localhost:3000/set_host2queues?queues=vm-2p8g.aarch64&host=vm-2p8..." put "/set_host2queues" do |env| if (client_queues = env.params.query["queues"]?) && (client_host = env.params.query["host"]?)

•  sched.set_host2queues(client_host, client_queues)
  

•  get_sched_from_env(env).set_host2queues(client_host, client_queues)
  
  "Done"
  

  else

@@ -125,7 +130,7 @@ module Scheduler # curl -X PUT "http://localhost:3000/del_host_mac?mac=00-01-02-03-04-05" put "/del_host_mac" do |env| if client_mac = env.params.query["mac"]?

•  sched.del_host_mac(client_mac)
  

•  get_sched_from_env(env).del_host_mac(client_mac)
  
  "Done"
  

  else

@@ -136,7 +141,7 @@ module Scheduler # curl -X PUT "http://localhost:3000/del_host2queues?host=vm-2p8g.aarch64" put "/del_host2queues" do |env| if client_host = env.params.query["host"]?

•  sched.del_host2queues(client_host)
  

•  get_sched_from_env(env).del_host2queues(client_host)
  
  "Done"
  

  else

@@ -150,7 +155,7 @@ module Scheduler # ?job_file=/lkp/scheduled/job.yaml&job_state=post_run&job_id=10 # ?job_file=/lkp/scheduled/job.yaml&loadavg=0.28 0.82 0.49 1/105 3389&start_time=1587725398&end_time=1587725698&job_id=10 get "/~lkp/cgi-bin/lkp-jobfile-append-var" do |env|

• puts sched.update_job_parameter(env)

• puts get_sched_from_env(env).update_job_parameter

  "Done" end

@@ -173,7 +178,7 @@ module Scheduler # response: get "server ip" from cluster state, # return "server=<server ip>". get "/~lkp/cgi-bin/lkp-cluster-sync" do |env|

• response = sched.request_cluster_state(env)

• response = get_sched_from_env(env).request_cluster_state

  debug_message(env, response)

@@ -187,14 +192,14 @@ module Scheduler # get job_id from request job_id = env.params.query["job_id"]? if job_id

•  puts sched.close_job(job_id)
  

•  puts get_sched_from_env(env).close_job(job_id)
  

  end

  "Done" end

  get "/~lkp/cgi-bin/lkp-wtmp" do |env|

• puts sched.update_tbox_wtmp(env)

• puts get_sched_from_env(env).update_tbox_wtmp

  "Done" end

@@ -205,7 +210,7 @@ module Scheduler job_id = env.params.query["job_id"].to_s

if testbox && ssh_port

•  sched.report_ssh_port(testbox, ssh_port)
  

•  get_sched_from_env(env).report_ssh_port(testbox, ssh_port)
  

  end

  puts %({"job_id": "#{job_id}", "state": "set ssh port", "ssh_port": "#{ssh_port}", "tbox_name": "#{testbox}"})

diff --git a/src/scheduler/submit_job.cr b/src/scheduler/submit_job.cr index 2836275..4e78102 100644 --- a/src/scheduler/submit_job.cr +++ b/src/scheduler/submit_job.cr @@ -2,8 +2,8 @@ # Copyright (c) 2020 Huawei Technologies Co., Ltd. All rights reserved.

class Sched

• def submit_job(env : HTTP::Server::Context)
• body = env.request.body.not_nil!.gets_to_end

• def submit_job

• body = @env.request.body.not_nil!.gets_to_end

  job_content = JSON.parse(body) job = Job.new(job_content, job_content["id"]?)

diff --git a/src/scheduler/update_job_parameter.cr b/src/scheduler/update_job_parameter.cr index 0692025..cee8b9b 100644 --- a/src/scheduler/update_job_parameter.cr +++ b/src/scheduler/update_job_parameter.cr @@ -2,8 +2,8 @@ # Copyright (c) 2020 Huawei Technologies Co., Ltd. All rights reserved.

class Sched

• def update_job_parameter(env : HTTP::Server::Context)
• job_id = env.params.query["job_id"]?

• def update_job_parameter
• job_id = @env.params.query["job_id"]? if !job_id return false end

@@ -13,7 +13,7 @@ class Sched job_content["id"] = job_id

(%w(start_time end_time loadavg job_state)).each do |parameter|

•  value = env.params.query[parameter]?
  

•  value = @env.params.query[parameter]?
  if !value || value == ""
    next
  end
  

-- 2.23.0