[Compass-ci] Re: [PATCH lkp-tests] spec/submit_spec.rb: submit merge_yaml/*.yaml

27 Nov 2020


      ...
+++ b/spec/submit_spec.rb
@@ -52,4 +52,8 @@ describe 'submit job spec' do
  it 'job on fail' do
    submit_job('job_on_fail')
  end


it 'merge yaml' do
submit_job('merge_yaml')
end

That's a bit redundant code structure -- lots of manual submit_job().
I'd suggest this change
def submit_job(submit_item)
          submit_yaml_path = File.join("#{LKP_SRC}/spec/submit", submit_item)
=>
        submit "#{LKP_SRC}/spec/submit/*" one by one
Thanks,
Fengguang

    