[Compass-ci] Re: [PATCH v2 lkp-tests] lib/job.rb: no need puts the a warning

On Wed, Nov 04, 2020 at 04:06:18PM +0800, Luan Shengde wrote:

On Wed, Nov 04, 2020 at 03:53:29PM +0800, Li Ping wrote:

...

[why] we can get hostname from the repo lab-z9 or get hostname from lkp-tests/hosts

---

lib/job.rb | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/lib/job.rb b/lib/job.rb index 5c2c9517..86cf3fa1 100755 --- a/lib/job.rb +++ b/lib/job.rb @@ -340,10 +340,8 @@ class Job lab_hosts_file = get_lab_hosts_file if lab_hosts_file hosts_file = lab_hosts_file

• end
• if File.file?(hosts_file)

•  hosts_file
  

• elsif File.file?(hosts_file)

•  hosts_file
  

according to your old/new version, use: if File.file?(lab_hosts_file) hosts_file = lab_hosts_file else ...

there are two way to check hostname file

Thanks, Luan Shengde

...

else
  puts("hosts_file not exist: #{hosts_file}, maybe need check testbox field")
  nil

-- 2.23.0