[Compass-ci] Re: [PATCH v2 compass-ci] area: refactor multi-qemu to support queues parameter

...

+end

How about use raise: raise options if ARGV.size.zero?

no one will receive this expection, so exit will more clearer

Thanks, Shenwei

...

+options.parse!(ARGV)

# Run multiple QEMU in parallel -HOSTNAME = ARGV[0] || "vm-2p8g--#{ENV['USER']}" -NR_VM = ARGV[1] || 1 +PWD = Dir.pwd +HOSTNAME = opt['hostname_prefix'] || "vm-2p8g.#{ENV['HOSTNAME']}" +NR_VM = opt['nr_vm'] || 1 +QUEUES = opt['queues'] || "#{ENV['HOSTNAME']}.#{RUBY_PLATFORM.split('-')[0]}" +LOG_DIR = '/srv/cci/serial/logs'

-def run(seqno)

• loop do
• start_time = Time.new
• hostname = "#{HOSTNAME}-#{seqno}"
• log_file = "/srv/cci/serial/logs/#{hostname}"

+def main(hostname)

• start_time = record_runtime_log(hostname)
• start_qemu(hostname)
• record_runtime_log(hostname, start_time: start_time, is_start: false)

+end

+def record_runtime_log(hostname, start_time: Time.new, is_start: true)

• log_file = "#{LOG_DIR}/#{hostname}"
• if is_start File.open(log_file, 'w') do |f| # fluentd refresh time is 1s # let fluentd to monitor this file first sleep(2) f.puts "\n#{start_time.strftime('%Y-%m-%d %H:%M:%S')} starting QEMU" end
• return start_time
• end

Pls add one blank line after "return"

Thanks, Xijian