[Compass-ci] Re: [PATCH v2 compass-ci] lib/matrix2.rb remove the *timestamp* from matrix

On Tue, Dec 22, 2020 at 10:28:03AM +0800, Ren Wen wrote:

On Tue, Dec 22, 2020 at 09:34:27AM +0800, Luan Shengde wrote:

...

...

@@ -87,6 +87,8 @@ def create_matrix(job_list) next unless stats

stats.each do |key, value|

•  next if key.include?('timestamp')
  

mostly we use include for a hash include a key, or array include a element. that would be fine use include here, but I think use match? better

A String object holds and manipulates an arbitrary sequence of bytes, typically representing characters.

seems a string menas [] of char in ruby. we can operate a sting like array.

Thanks, Weitao

Thanks, RenWen

...

Thanks, Luan Shengde

...

• matrix[key] = [] unless matrix[key]
  matrix[key] << value
  

  end

-- 2.23.0