[Compass-ci] Re: [PATCH v2 compass-ci] src/lib: add delete function in job.cr

...

• private def get_initialized_keys()

no need to add () for no parameter in

ok

you should use rubocop to check the code.

this is crystal file not ruby.

and you should run 'cd repo_dir; overcommit -i' to install the overcommit to the repo

ok

Thanks, Luan Shengde

...

initialized_keys = [] of String

REQUIRED_KEYS.each do |key|

@@ -350,7 +359,10 @@ class Job "kernel_uri", "kernel_params", "linux_vmlinuz_path"]

• end

• private def initialized?

• initialized_keys = get_initialized_keys initialized_keys.each do |key| return false unless @hash.has_key?(key) end

-- 2.23.0