[Compass-ci] Re: [PATCH v5 compass-ci] feat: build centos initramfs image with one command

On Tue, Oct 20, 2020 at 04:22:07PM +0800, Wu Fengguang wrote:

...

+check_passwd_file() {

check_passwd_file => export_root_passwd

...

• root_pwd_file="$HOME/.config/compass-ci/rootfs-passwd"

local root_passwd_file=...

Ok.

...

•    export ROOT_NEW_PASSWD=
  

That line is not necessary.

got it.

Still not aligned.

ok.

...

•    [ -f "$root_pwd_file" ] || {
  

• echo "[INFO] Please set the password file."
  

• echo "$HOME/.config/compass-ci/rootfs-passwd"
  

• exit 1
  

•    }
  

•    export ROOT_NEW_PASSWD=$(cat "$root_pwd_file")
  

ROOT_NEW_PASSWD => ROOT_PASWD

fixed.

...

+}

+pull_docker_image() +{

• docker pull $image
• if [ $? = 0 ]; then

• echo "finish downloading image"
  

• else

• echo "[INFO] Pull docker image failed."
  

[INFO] => ERROR:

ok

...

• exit
  

exit 1

ok

Thanks, Fengguang

...

•   -e ROOT_NEW_PASSWD=$ROOT_NEW_PASSWD
  

•   -e image_name=$image_name
  

Please use IMAGE_NAME for env var.

Ok.

Thanks, Chenglong

...

•   $image
  

•   /root/bin/create-image
  

+)

+pull_docker_image +${cmd[@]} +docker_cp_image +docker_rm init_docker &> /dev/null

+echo "build finished"

2.23.0