31 Oct
2020
31 Oct
'20
8:57 p.m.
On Thu, Oct 29, 2020 at 07:51:24PM +0800, Xu Xijian wrote:
On Thu, Oct 29, 2020 at 03:55:48PM +0800, Wu Fengguang wrote:
- private def set_kernel_version
- self["kernel_version"] ||= "default"
- end
It might be easier to just leave it empty if user want the default kernel. What do you think?
if $kernel_version not set or empty vmlinuz else vmlinuz-$kernel_version
Thanks, Fengguang
If just use "$kernel_version" with vmlinuz, it will be easier. But there are "modules-$kernel_version.cgz" and "headers-$kernel_version.cgz" that need "$kernel_version" too, so I think to keep "default" may be better. Otherwise, they will be "modules-.cgz" and "headers-.cgz", or to adapt them additionally, it will make code more complex.
Just one line of code..
Do you consider complexity in USER POV?
Thanks, Fengguang