[Compass-ci] Re: [PATCH v4 compass-ci 1/2] fix(sparrow): process will exit if firewalld.service was not installed

On Wed, Sep 30, 2020 at 05:36:42PM +0800, Hu Xuejiao wrote:

When firewalld is inactive, return code of 'systemctl status firewalld' will be 3, and install-tiny has set -e, so this will cause this process exit.

Signed-off-by: Hu XueJiao huxuejiao1@huawei.com

sparrow/2-network/iptables | 22 +++++++++++++--------- 1 file changed, 13 insertions(+), 9 deletions(-)

diff --git a/sparrow/2-network/iptables b/sparrow/2-network/iptables index 092c4ca..7183145 100755 --- a/sparrow/2-network/iptables +++ b/sparrow/2-network/iptables @@ -12,15 +12,19 @@ iptables -I FORWARD 1 -j ACCEPT iptables -t nat -A POSTROUTING -o "$PUB_IFACE" -s $BR0_SUBNET -j MASQUERADE iptables -t nat -A POSTROUTING -o $BR0_IFACE -d $BR0_SUBNET -j MASQUERADE

FYI, "set -e" already removed, so process will not exit.