On Thu, Jan 21, 2021 at 09:13:13AM +0800, Xiao Shenwei wrote:
-check_option_value() +check_kernel() { [ -n "$kernel" ] || { log_info "Can not find job for current hostname: $hostname." @@ -64,10 +64,16 @@ check_option_value() log_error "Can not find kernel file or kernel file is empty: $kernel." exit 1 }
i find this script have more and more function, how about move these function to a lib dir. qemu kvm.sh lib.sh
please give more compelling reasons, and how, when to use if move to lib dir.
Thanks, Yinsi
Thanks, Shenwei
+}
+check_qemu() +{ # debian has both qemu-system-x86_64 and qemu-system-riscv64 command [[ $kernel =~ 'riscv64' ]] && qemu=qemu-system-riscv64 +}
+check_initrds() +{ [ -n "$initrds" ] || { log_error "The current initrds is null." exit 1 @@ -118,6 +124,8 @@ set_qemu() do command -v "$qemu" > /dev/null && break done
- check_qemu
}
print_message() @@ -209,8 +217,10 @@ write_logfile
parse_ipxe_script
+check_kernel +check_initrds
set_options -check_option_value
print_message
-- 2.23.0