[Compass-ci] Re: [PATCH compass-ci] auto_submit: delete commit date as it's redundant

On Fri, Oct 30, 2020 at 09:27:16AM +0800, Sun Yukui wrote:

On Thu, Oct 29, 2020 at 08:55:05PM +0800, Li Yuanchao wrote:

...

bisect get commit date itself, commit date here is unnecessary

Signed-off-by: Li Yuanchao lyc163mail@163.com

sbin/auto_submit | 2 -- 1 file changed, 2 deletions(-)

ok Thanks sunyukui

If you think this patch is good.

Pls reply " Reviewed-by: xx < xx.com >"

It will make a bug about score in review-star.

Thanks, Chenglong

...

diff --git a/sbin/auto_submit b/sbin/auto_submit index 21958d3..8845b13 100755 --- a/sbin/auto_submit +++ b/sbin/auto_submit @@ -31,12 +31,10 @@ class AutoSubmit def submit(newrefs_info, submit_argv) newrefs_info['new_refs']['heads'].each do |branch, commit_id| real_argvs = Array.new(submit_argv)

•  commit_date = `git -C /srv/git/#{newrefs_info['git_repo']}.git log  --format=%ct -1 #{commit_id}`
  real_argvs.push("upstream_branch=#{branch.delete_prefix('refs/heads/')}")
  real_argvs.push("upstream_commit=#{commit_id}")
  tag = %x(git -C /srv/git/#{newrefs_info['git_repo']}.git tag --points-at #{commit_id})
  real_argvs.push("upstream_tag=#{tag}") unless tag.empty?
  

•  real_argvs.push("commit_date=#{commit_date}")
  
  system(real_argvs.join(' '))
  

  end

-- 2.23.0