10 Nov
2020
10 Nov
'20
8:59 p.m.
On Tue, Nov 10, 2020 at 06:41:03PM +0800, Ren Wen wrote:
- # modify submodules address to local server address
- # url = https://github.com/nico/demumble.git
- # =>
- # url = git://172.168.131.113/submodules/b/bloaty/demumble.git
Maybe last 3 lines are useless. It's clear enough.
- if [[ -f ".gitmodules" ]]; then
May use [, [[ is already conditional construct.
local project=${upstream_repo%/*}What's the value of upstream_repo? May need an example in changelog to make review more easier.
ok, Thanks, Liushaofei
Thanks, RenWen
local url="git://${LKP_SERVER}/submodules/${project}/"sed -i "s|url = .*\/|${url}|g" ".gitmodules"- fi
- local ref=origin/HEAD if [[ -n $fragment ]]; then case ${fragment%%=*} in
-- 2.23.0