[Compass-ci] Re: [PATCH lkp-tests 2/4] lib/env.sh: move functions to env.sh

TO ALL

+++ b/lib/env.sh @@ -125,3 +125,33 @@ shell_profile() [ -f "$profile" ] || touch $profile echo $profile }

+write_shell_profile() +{

• shell_profile_file=$(shell_profile)
• if [ $# -gt 0 ]; then

• echo $@ >> $shell_profile_file
  

Please always use "$@" instead of $@

btw, Xuejiao, would you do a new patch to write our shell configs to

~/.config/compass-ci/env.sh

Then source it in $shell_profile_file

Benefits:

- easier to auto upgrade ~/.config/compass-ci/env.sh for users in future - change the hacky source ~/.${SHELL##*/}rc to source ~/.config/compass-ci/env.sh in various places.

Thanks, Fengguang