[Compass-ci] Re: [PATCH lkp-tests] tests/build-pkg: fix syntax errors caused by replacement

On Mon, Nov 23, 2020 at 11:04:52AM +0800, Lin Jiaxin wrote:

error: //PKGBUILD: line 13: syntax error near unexpected token `)' //PKGBUILD: line 13: ` "$_pkgname.desktop")'

The original logic only adapts to the situation where source has only one value.

Signed-off-by: Lin Jiaxin ljx.joe@qq.com

tests/build-pkg | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/build-pkg b/tests/build-pkg index c5d55eda..6ad825d7 100755 --- a/tests/build-pkg +++ b/tests/build-pkg @@ -103,10 +103,10 @@ build_source_pkg() repo_dir="${repo_dir%.git*}::" fi

• upstream_source="source=("${repo_dir}git://${LKP_SERVER}/${upstream_repo}#commit=${upstream_commit}")"
• sed -i "s|^source=.*|${upstream_source}|g" PKGBUILD

• upstream_source="source=("${repo_dir}git://${LKP_SERVER}/${upstream_repo}#commit=${upstream_commit}""
• sed -i "s|^source=[^)]*|${upstream_source}|g" PKGBUILD [ -n "$PKGBUILD_TAG" ] && {

• sed -i "s|^source=.*|${upstream_source}|g" "PKGBUILD-$PKGBUILD_TAG"
  

sed -i "s|^source=[^)]*|${upstream_source}|g" "PKGBUILD-$PKGBUILD_TAG"

Can be put in a method Thanks sunyukui

} }

-- 2.23.0