On Fri, Jan 15, 2021 at 07:22:50PM +0800, Yu Chuan wrote:
@@ -197,8 +197,8 @@ write_logfile
parse_ipxe_script
-set_options check_option_value +set_options
check_option_value have check qemu command, if set_options after check, check_option_value doesn't work for qemu command, the order can like this:
parse_ipxe_script set_qemu check_option_value set_options
Good, so how about move the follow line from check_option_value() to set_qemu() ? [[ $kernel =~ 'riscv64' ]] && qemu=qemu-system-riscv64
Because it looks a set qemu step, and ,when run set_qemu(), we already get var $kernel.
move it or not can refer:
Subject: Re: [PATCH v8 compass-ci] providers/qemu: adapt for x86_64 and riscv64
Subject: [PATCH v2 compass-ci 3/3] providers/qemu: check kernel
because check kernel and set qemu is not the same logic, so not move.
Thanks, Yinsi
Thanks Yu Chuan
Thanks, Yinsi
print_message
-- 2.23.0