[Compass-ci] Re: [PATCH compass-ci] lib/compare_matrixes.rb: refactor format optimization

On Sat, Nov 28, 2020 at 03:19:09PM +0800, Lu Kaiyi wrote:

reduce unnecessary indent to simplify code

Signed-off-by: Lu Kaiyi 2392863668@qq.com

lib/compare_matrixes.rb | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-)

diff --git a/lib/compare_matrixes.rb b/lib/compare_matrixes.rb index d8112e9..23c7931 100644 --- a/lib/compare_matrixes.rb +++ b/lib/compare_matrixes.rb @@ -177,7 +177,7 @@ def get_matrixes_values(matrixes_list, options) end

def remove_unchanged_field(matrixes_values)

• # remove unchanged field from matrixes valus and remove :changed key

• # remove unchanged field from matrixes values and remove :changed key # matrixes_values.each_key do |success| matrixes_values[success].delete_if do |field|

@@ -316,21 +316,20 @@ def get_decimal_length(number, length) end

def get_suitable_number_str(number, length, format_pattern)

• # if number string length can't < target length,

• # if number string length no less than target length,

# if number string length is no less than target length,

Thanks, Xijian